Re: [Rtg-yang-coord] container with presence

> On 29 May 2015, at 18:50, Andy Bierman <andy@yumaworks.com> wrote:
> 
> On Fri, May 29, 2015 at 9:28 AM, Ladislav Lhotka <lhotka@nic.cz> wrote:
>> Mahesh Jethanandani <mjethanandani@gmail.com> writes:
>> 
>>> And the error that will pop up as result will be something like this:
>>> 
>>> Warning: top-level NP container ‘twamp-client' is mandatory
>>> ietf-twamp.yang:59.9: warning(1048): top-level object is mandatory
>>> 
>> 
>> This is actually something else, the case I am writing about leads to
>> this error message in pyang:
>> 
>> knot-dns.yang:322 (at knot-dns.yang:169): error: cannot augment mandatory node record-type
>> 
>> (and it is a hard error rather than warning).
>> 
> 
> 
> It is not an error to augment a mandatory node.
> It is an error to augment any node with mandatory nodes.
> Big difference.

Right, but it is a linguistic problem, ‘record-type’ is a mandatory node inside the augment statement, not the target node.
The error message should thus read "cannot augment with mandatory node record-type”.

Thanks for catching it, I’ve corrected it in the source.

Lada

> 
>> Lada
> 
> Andy
> 
>> 
>>>> On May 28, 2015, at 2:28 AM, Ladislav Lhotka <lhotka@nic.cz> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> I have a suggestion for the authors of all routing protocol modules: the container that encapsulates all configuration data for a given protocol should be a container with presence (see sec. 7.5.1 in RFC 6020) because then the configuration data may include mandatory items that are otherwise forbidden at the top level of an augment.
>>>> 
>>>> See also YANG 1.1 issue Y26:
>>>> 
>>>> https://svn.tools.ietf.org/svn/wg/netmod/yang-1.1/issues.html#sec-27
>>>> 
>>>> For example, in the the ietf-isis it should look like this:
>>>> 
>>>>    augment "/rt:routing/rt:routing-instance/rt:routing-protocols/"
>>>>        +"rt:routing-protocol" {
>>>>      when "rt:type = 'isis:isis'" {
>>>>        description
>>>>         "This augment is only valid when routing protocol
>>>>          instance type is isis.";
>>>>      }
>>>>      presence "IS-IS routing protocol”;
>>>>      ...
>>>>    }
>>>> 
>>>> I am also including this recommendation in the routing-cfg draft.
>>>> 
>>>> Lada
>>>> --
>>>> Ladislav Lhotka, CZ.NIC Labs
>>>> PGP Key ID: E74E8C0C
>>>> 
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Rtg-yang-coord mailing list
>>>> Rtg-yang-coord@ietf.org
>>>> https://www.ietf.org/mailman/listinfo/rtg-yang-coord
>>> 
>>> Mahesh Jethanandani
>>> mjethanandani@gmail.com
>>> 
>>> 
>>> 
>> 
>> --
>> Ladislav Lhotka, CZ.NIC Labs
>> PGP Key ID: E74E8C0C
>> 
>> _______________________________________________
>> Rtg-yang-coord mailing list
>> Rtg-yang-coord@ietf.org
>> https://www.ietf.org/mailman/listinfo/rtg-yang-coord

--
Ladislav Lhotka, CZ.NIC Labs
PGP Key ID: E74E8C0C