Re: [Rtg-yang-coord] container with presence

Hi Sue,

> On 28 May 2015, at 13:18, Susan Hares <shares@ndzh.com> wrote:
> 
> Lada: 
> 
> Thank you for this suggestion. How would you suggest the I2RS yang models for I2RS RIB, I2RS Topology, and I2RS FB-RIB use the 

These models don’t define routing protocols, so why should they augment "rt:routing-protocol”?

However, the use of presence containers is a common workaround for all situation where mandatory data are needed inside an augment. Another example is the if:interface list in the ietf-interfaces module, where config data for a specific interface type (augmented into the list from another module) might include mandatory items.

Another solution that doesn’t need an extra presence container is to use a “must” statement. 

> 
> 
>     augment "/rt:routing/rt:routing-instance/rt:routing-protocols/"
>         +"rt:routing-protocol" {
>       when "rt:type = 'i2rs:i2rs'" {
>         description
>          "This augment is only valid when routing protocol
>           instance type is i2rs.";
>       }
>       presence "I2RS routing protocol”;
>       ...
>     }
> 
> If a modules depends on L1 TEAS model or l2  how should this be tested?

Sorry, I don’t understand, what exactly do you want to test?

Lada

>  
> 
> 
> Sue 
> 
> -----Original Message-----
> From: Rtg-yang-coord [mailto:rtg-yang-coord-bounces@ietf.org] On Behalf Of Ladislav Lhotka
> Sent: Thursday, May 28, 2015 5:29 AM
> To: Rtg-yang-coord@ietf.org
> Subject: [Rtg-yang-coord] container with presence
> 
> Hi,
> 
> I have a suggestion for the authors of all routing protocol modules: the container that encapsulates all configuration data for a given protocol should be a container with presence (see sec. 7.5.1 in RFC 6020) because then the configuration data may include mandatory items that are otherwise forbidden at the top level of an augment.
> 
> See also YANG 1.1 issue Y26:
> 
> https://svn.tools.ietf.org/svn/wg/netmod/yang-1.1/issues.html#sec-27
> 
> For example, in the the ietf-isis it should look like this:
> 
>     augment "/rt:routing/rt:routing-instance/rt:routing-protocols/"
>         +"rt:routing-protocol" {
>       when "rt:type = 'isis:isis'" {
>         description
>          "This augment is only valid when routing protocol
>           instance type is isis.";
>       }
>       presence "IS-IS routing protocol”;
>       ...
>     }
> 
> I am also including this recommendation in the routing-cfg draft.
> 
> Lada
> --
> Ladislav Lhotka, CZ.NIC Labs
> PGP Key ID: E74E8C0C
> 
> 
> 
> 
> _______________________________________________
> Rtg-yang-coord mailing list
> Rtg-yang-coord@ietf.org
> https://www.ietf.org/mailman/listinfo/rtg-yang-coord
> 

--
Ladislav Lhotka, CZ.NIC Labs
PGP Key ID: E74E8C0C