[rtgwg] draft-ietf-rtgwg-mrt-frr-algorithm-03

["Anil Kumar S N (VRP Network BL)" <[e-mail]>]

Hi Authors,

As discussed before, Please find my review comments :

Comment 1: Can we rename parameter which is passed to these functions as real SPF root or GADAG root ?

   Run_DFS(node root)
   Run_Lowpoint(node root)
   Compute_Localroot(root, root)
   Construct_GADAG_via_Lowpoint(topology, root)
   Add_Undirected_Links(topo, root)
   Assign_Block_ID(root, max_block_id)
   Compute_MRT_NextHops(x, root)

Comment 2:  Here parenthesis are not matching, four '(' and five ')'.
           This must be typo mistake.


In_Common_Block(x, y)
  if ( (x.block_id is y.block_id))
       or (x is y.localroot) or (y is x.localroot) )
     return true
  return false


Comment 3:   Is it possible to rephrase "if an MRT doesn't use primary_intf"
What does the sentence "MRT doesn't use primary_intf" mean ? Dose it mean neither Red interface nor Blue interface is same as primary interface ?
What does the sentence "return that MRT color" means ?

Select_Alternates_Internal(S, D, F, primary_intf,
                           D_lower, D_higher, D_topo_order)

    //When D==F, we can do only link protection
    if ((D is F) or (D.order_proxy is F))
        if an MRT doesn't use primary_intf
            indicate alternate is not node-protecting
            return that MRT color


Thanks & Regards
Anil S N

"Be liberal in what you accept, and conservative in what you send" - Jon Postel