Re: New Version Notification for draft-ding-rtgwg-arp-yang-model-01.txt

Hi Xiaojian,

I'm adding Rob who may be able to comment on this (draft-ietf-netmod-sub-intf-vlan-model uses IEEE's vlanid definition).

Regards,
Reshad.

On 2018-04-12, 4:53 AM, "dingxiaojian (A)" <dingxiaojian1@huawei.com> wrote:

    Hi Reshad,

         Sorry for delay.
         We have addressed all your comments except point 2. If we use the type ' ieee: vlanid ', we should import the corresponding YANG module which contains this type.
         We have found that ' ieee-types ' module has been emerged in the 01-version of draft-ietf-netmod-yang-types-01. However, it was deleted in the final version of RFC 6021.
          If we use the import like:

           import ietf-ieee-types {
        prefix ieee;
      }

    The ARP YANG module cannot run correctly on the website http://www.yangvalidator.com/validator,  and has the following error:
    error: module "ietf-ieee-types" not found in search path

    If you have some good suggestions, pls help us to improve the draft. Thanks very much.

    Xiaojian

    -----Original Message-----
    From: Reshad Rahman (rrahman) [mailto:rrahman@cisco.com] 
    Sent: Tuesday, March 20, 2018 10:29 PM
    To: dingxiaojian (A) <dingxiaojian1@huawei.com>; rtgwg@ietf.org
    Subject: Re: New Version Notification for draft-ding-rtgwg-arp-yang-model-01.txt

    Hi Xiaojian,

    Some comments:
    - The uint64 counters should be changed to yang:counter64.
    - For vlanid use ieee:vlanid instead of uint16
    - You have "container global-static-table" which contains " list static-entry". Typically this is done by having the container being in plural form and the list in singular form, e.g. "container static-entries" and "list static-entry".
    - Use yang-version 1.1 in ARP YANG module also
    - Add reference statements for imports (see 6087bis) in both modules
    - The revision statement "2017-10-18" doesn't match the date: 2018-01-27
    - Add a note to RFC Editor to replace RFC XXX 

    Regards,
    Reshad.

    On 2018-02-28, 8:58 AM, "rtgwg on behalf of dingxiaojian (A)" <rtgwg-bounces@ietf.org on behalf of dingxiaojian1@huawei.com> wrote:

        Hi all,

        -01 version addresses the comments received from WG mail list reviews .

        More comments are very welcomed. Thanks.

        Best regards,
        Xiaojian

        -----Original Message-----
        From: internet-drafts@ietf.org [mailto:internet-drafts@ietf.org] 
        Sent: Wednesday, February 28, 2018 4:15 PM
        To: Zhengfeng (Habby) <habby.zheng@huawei.com>; Robert Wilton <rwilton@cisco.com>; dingxiaojian (A) <dingxiaojian1@huawei.com>; dingxiaojian (A) <dingxiaojian1@huawei.com>
        Subject: New Version Notification for draft-ding-rtgwg-arp-yang-model-01.txt

        A new version of I-D, draft-ding-rtgwg-arp-yang-model-01.txt
        has been successfully submitted by Xiaojian Ding and posted to the IETF repository.

        Name:		draft-ding-rtgwg-arp-yang-model
        Revision:	01
        Title:		YANG Data Model for ARP
        Document date:	2018-02-27
        Group:		Individual Submission
        Pages:		17
        URL:            https://www.ietf.org/internet-drafts/draft-ding-rtgwg-arp-yang-model-01.txt
        Status:         https://datatracker.ietf.org/doc/draft-ding-rtgwg-arp-yang-model/
        Htmlized:       https://tools.ietf.org/html/draft-ding-rtgwg-arp-yang-model-01
        Htmlized:       https://datatracker.ietf.org/doc/html/draft-ding-rtgwg-arp-yang-model-01
        Diff:           https://www.ietf.org/rfcdiff?url2=draft-ding-rtgwg-arp-yang-model-01

        Abstract:
           This document defines a specification of one YANG module and one
           submodule.  Together they form the Address Resolution Protocol (ARP)
           data model that performs as a guideline for configuring ARP
           capabilities on a system.  It is intended these modules be used by
           service providers who manipulate devices from different vendors in a
           standard way.

        Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org.

        The IETF Secretariat

        _______________________________________________
        rtgwg mailing list
        rtgwg@ietf.org
        https://www.ietf.org/mailman/listinfo/rtgwg