RE: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02

Mach Chen <mach.chen@huawei.com> Thu, 02 August 2018 01:59 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57DC6124D68; Wed, 1 Aug 2018 18:59:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.89
X-Spam-Level:
X-Spam-Status: No, score=-1.89 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6rmT1eRCgGVI; Wed, 1 Aug 2018 18:59:02 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9DBAA130DCA; Wed, 1 Aug 2018 18:59:01 -0700 (PDT)
Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 954B3C5DF0765; Thu, 2 Aug 2018 02:58:54 +0100 (IST)
Received: from DGGEML421-HUB.china.huawei.com (10.1.199.38) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.399.0; Thu, 2 Aug 2018 02:58:55 +0100
Received: from DGGEML510-MBX.china.huawei.com ([169.254.2.219]) by dggeml421-hub.china.huawei.com ([10.1.199.38]) with mapi id 14.03.0382.000; Thu, 2 Aug 2018 09:58:52 +0800
From: Mach Chen <mach.chen@huawei.com>
To: Robert Wilton <rwilton@cisco.com>, "draft-ding-rtgwg-arp-yang-model.all@ietf.org" <draft-ding-rtgwg-arp-yang-model.all@ietf.org>, "rtgwg-chairs@ietf.org" <rtgwg-chairs@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: RE: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02
Thread-Topic: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02
Thread-Index: AQHUKa2PPOdTPzBbrE2iVqXPmjrLTKSrtLxw
Date: Thu, 2 Aug 2018 01:58:52 +0000
Message-ID: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE292566105@dggeml510-mbx.china.huawei.com>
References: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE292563246@dggeml510-mbx.china.huawei.com> <30620f3f-be62-bdbd-72fb-fab27439351b@cisco.com>
In-Reply-To: <30620f3f-be62-bdbd-72fb-fab27439351b@cisco.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.194.201]
Content-Type: multipart/alternative; boundary="_000_F73A3CB31E8BE34FA1BBE3C8F0CB2AE292566105dggeml510mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/Qrb1qWMM9-sMaM1cfrxEyIs70_Q>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 01:59:04 -0000

Hi Rob,

Looks good to me!

Best regards,
Mach

From: Robert Wilton [mailto:rwilton@cisco.com]
Sent: Wednesday, August 01, 2018 11:37 PM
To: Mach Chen <mach.chen@huawei.com>;; draft-ding-rtgwg-arp-yang-model.all@ietf.org; rtgwg-chairs@ietf.org
Cc: rtg-dir@ietf.org; rtgwg@ietf.org
Subject: Re: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02


Hi Mach,

Thanks for the comments, we will address all of these.

Specifically for the abstract, I propose changing the text to:

"

   This document defines a YANG data model for the management of the

   Address Resolution Protocol (ARP).  It extends the basic ARP

   functionality contained in the ietf-ip YANG data model, defined in

   [RFC8344], to provide management of optional ARP features and

   statistics.



   The YANG data model in this document conforms to the Network

   Management Datastore Architecture defined in [RFC8342].

"
Thanks,
Rob

On 01/08/2018 09:48, Mach Chen wrote:

Hello



I have been selected to do a routing directorate “early” review of this draft.

​ https://tools.ietf.org/html/draft-ding-rtgwg-arp-yang-model-02



The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached. As this document is in working group last call, my focus for the review was to determine whether the document is ready to be published. Please consider my comments along with the other working group last call comments.



For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir



Document: draft-ding-rtgwg-arp-yang-model-02

 Reviewer: Mach Chen

 Review Date: 01 August 2018

 Intended Status: Standards Track



Summary



The draft  defines a YANG model for ARP configurations, which covers static ARP, ARP caching, proxy ARP and gratuitous ARP. The model is very short and the content is straightforward. It can be a reasonable start point for WG adoption call.



General comments:



Although I am not a native English speaker, I also feel that the document needs some enhancements on its wording and grammar to make it more clean and readable.



For example,  the following text needs some rewording or may be removed.

Abstract:

"The data model performs as

   a guideline for configuring ARP capabilities on a system.  It is

   intended this model be used by service providers who manipulate

   devices from different vendors in a standard way."



Specific comments:



1. It's lack of the IANA section.



2. Section 3.1 and Section 3.3,  suggest to add relevant references to ARP caching and gratuitous ARP.



3.  import ietf-interfaces {

    prefix if;

    description

      "A Network Management Datastore Architecture (NMDA)

       compatible version of the ietf-interfaces module

       is required.";

  }

  import ietf-ip {

    prefix ip;

    description

      "A Network Management Datastore Architecture (NMDA)

       compatible version of the ietf-ip module is

       required.";

  }



Lack of the reference RFCs.

And the descriptions seem not appropriate, some of other descriptions in this document have the similar issue, suggest to revise those descriptions.



In addition, idnits tool shows:



== Missing Reference: 'RFC826' is mentioned on line 77, but not defined



  == Missing Reference: 'RFC6536' is mentioned on line 583, but not defined



  ** Obsolete undefined reference: RFC 6536 (Obsoleted by RFC 8341)



  == Unused Reference: 'I-D.ietf-netmod-rfc7223bis' is defined on line 606,

     but no explicit reference was found in the text



  == Unused Reference: 'RFC0826' is defined on line 636, but no explicit

     reference was found in the text





Best regards,

Mach