RE: Genart last call review of draft-ietf-rtgwg-yang-rip-06

Xufeng Liu <Xufeng_Liu@jabil.com> Thu, 14 December 2017 14:53 UTC

Return-Path: <Xufeng_Liu@jabil.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F5F1126D3F; Thu, 14 Dec 2017 06:53:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.699
X-Spam-Level:
X-Spam-Status: No, score=-4.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=jabil.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bs19M7ywn4EM; Thu, 14 Dec 2017 06:53:27 -0800 (PST)
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0109.outbound.protection.outlook.com [104.47.34.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48E56126C89; Thu, 14 Dec 2017 06:53:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jabil.onmicrosoft.com; s=selector1-jabil-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xHf1SPERVitGQd5LMsvPKjSiaMZ4S18Rxz2Xp91C0ko=; b=MWQuH+1cfEK0C+HHCRMHXo4/j9jSJZjecgT82TaLFx7hfrLfhhp7Xt/HgA8/rVoPcjv7ef0BzZOIlUI3efTzsCBPIY/JggS0cK5zlq7zWkGRR5LnBpjjJMeCQKncRsqEM4dmFZWAkcZZ515AuoezubzhuO2vC3o4yjdzZpcuIqo=
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com (10.160.154.13) by BN3PR0201MB0867.namprd02.prod.outlook.com (10.160.154.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Thu, 14 Dec 2017 14:53:21 +0000
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) by BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) with mapi id 15.20.0302.017; Thu, 14 Dec 2017 14:53:21 +0000
From: Xufeng Liu <Xufeng_Liu@jabil.com>
To: Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "rtgwg@ietf.org" <rtgwg@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-rtgwg-yang-rip.all@ietf.org" <draft-ietf-rtgwg-yang-rip.all@ietf.org>
Subject: RE: Genart last call review of draft-ietf-rtgwg-yang-rip-06
Thread-Topic: Genart last call review of draft-ietf-rtgwg-yang-rip-06
Thread-Index: AQHTcaSi7YbHb0OFr0uvb46nJUSruaNC8lng
Date: Thu, 14 Dec 2017 14:53:21 +0000
Message-ID: <BN3PR0201MB0867A3887C05DE1730ECEFCFF10A0@BN3PR0201MB0867.namprd02.prod.outlook.com>
References: <151290299991.21913.13558438364274541815@ietfa.amsl.com>
In-Reply-To: <151290299991.21913.13558438364274541815@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNceGxpdVxhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLTg0ZDhjMWU1LWUwZGUtMTFlNy05YzNjLTE4NWUwZmUzYzQ1Y1xhbWUtdGVzdFw4NGQ4YzFlNy1lMGRlLTExZTctOWMzYy0xODVlMGZlM2M0NWNib2R5LnR4dCIgc3o9IjE4MTEiIHQ9IjEzMTU3NzM2Nzk5NDI0NzgwOCIgaD0iQllZZ0RYQlJTeFVxczU1U0RNTnZjMkJ1SlpBPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg==
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Xufeng_Liu@jabil.com;
x-originating-ip: [98.191.72.170]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN3PR0201MB0867; 6:8bmJkX6eI/051qPYHFpQq6nTInTpZx6EVf3eNaH87F5w3D5UPQYZEXLNr6EZzgm7Qbbmvi11wkeEaZUm3hC1tY6iG2xd0f5BQbbOMxS98KGpigU99DmklKL7y2YM5jP9MYM1m3NXihXFcgQB7eYknVTifMunhexW6F//AYtfDohFX8iccP98uHkb3M6nzY3RxfciN9O177jLsZ1kbwgzjnsOYlKgAaMW1E19e3Cnlc0N+5ohEbreqvtrgieBaBo3cYTRbSxQfQyKA1AHrzSv9pCL4iBWVGhqq3P2eB6jOgDJKh5nu5BfA/dZtuq3UnZhO9wShdsXfnj4E1BJ1GnIDeNV++nI1OqxKVKrz7Sv0Y4=; 5:BNswQhEUrxEFNAb6vaYF8ZGq8GE0+ST3h7h3DaUVccN2BZMYrTdeDvWkx9JepKxRu7K9s1pfuS3KOsfkYhsW9Xc69ZgUIWcg0hXayM2KTNCjz33P+rGQVdI+sAsagw+0O5jR9B5byXA/WT13IoRdwRXpK9fb4CBq/17/leZrY6A=; 24:AHUPr0ePI8HfmYWHUhjCFa7Vwob3B43zjhH7sTpBVs6PuBJLS2u3Lfz24jMz6bxgmluR5lvtioGTmML8REtBoLTUraqUBAFN01ZL+SP8rag=; 7:YxGVqldXYEqry3vuP5WgJHNnwpWIVcn98lQC0DELPc0GJjQBRoZJockKsvaxL++chBjHdtULDbDBEFAeCWOpqRupgG50FVHlaNvg3IxMof2bmsoJsXnPwgFaXNXpyltyFCbXtfPb3tMmEpas/DBEcTTkgwIzl8Yt7yxKpb1odOpJp5d0H5AasDyzXTTiv2PpEqpQHmyNTSt7Lonch+4FFm2XGI+PRVdoBv7oKFlxHVUl0HbUVSnhQSqxTUVeteWf
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 46f7d255-6efb-478b-9071-08d543026bb6
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:BN3PR0201MB0867;
x-ms-traffictypediagnostic: BN3PR0201MB0867:
x-microsoft-antispam-prvs: <BN3PR0201MB08678F1FD220C4CAC9005EA5F10A0@BN3PR0201MB0867.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011); SRVR:BN3PR0201MB0867; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR0201MB0867;
x-forefront-prvs: 05214FD68E
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(39860400002)(376002)(366004)(13464003)(199004)(189003)(51914003)(377424004)(86362001)(2900100001)(6436002)(110136005)(54906003)(3846002)(229853002)(66066001)(3660700001)(8676002)(53936002)(478600001)(76176011)(77096006)(316002)(80792005)(6506007)(68736007)(102836003)(97736004)(53546011)(6116002)(4001150100001)(2501003)(2906002)(6306002)(55016002)(9686003)(99286004)(6246003)(305945005)(8936002)(72206003)(966005)(5660300001)(3280700002)(14454004)(7736002)(7696005)(25786009)(33656002)(230783001)(74316002)(106356001)(4326008)(81166006)(81156014)(39060400002)(2950100002)(105586002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0201MB0867; H:BN3PR0201MB0867.namprd02.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: jabil.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: jabil.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46f7d255-6efb-478b-9071-08d543026bb6
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 14:53:21.7665 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bc876b21-f134-4c12-a265-8ed26b7f0f3b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0867
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/ZiUp4gJbyQOSY7FfjJB4jsJTh_Q>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2017 14:53:30 -0000

Hi Roni,

Thanks for the review and comments.

We have posted a updated version https://tools.ietf.org/html/draft-ietf-rtgwg-yang-rip-07, which contains the fixes for the two items that you listed below.

Thanks,
- Xufeng

> -----Original Message-----
> From: Roni Even [mailto:ron.even.tlv@gmail.com]
> Sent: Sunday, December 10, 2017 5:50 AM
> To: gen-art@ietf.org
> Cc: rtgwg@ietf.org; ietf@ietf.org; draft-ietf-rtgwg-yang-rip.all@ietf.org
> Subject: Genart last call review of draft-ietf-rtgwg-yang-rip-06
> 
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for the
> IETF Chair.  Please treat these comments just like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-rtgwg-yang-rip-??
> Reviewer: Roni Even
> Review Date: 2017-12-10
> IETF LC End Date: 2017-12-12
> IESG Telechat date: 2018-01-11
> 
> Summary:
> The document is ready for publication with nits as a standard track RFC
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1.  in section  4  " type enumeration {
>                enum 1 {
>                  description "IS-IS level 1 routes.";
>                }
>                enum 2 {
>                  description "IS-IS level 1  routes.";
>                }"
> 
> enum 2 is IS-IS level 2 routes
> 
> 2. In Appendix A , the figure with eth0 and the data tree with eth1. Also there is
> "ipv4-prefix": "198.51.100.0/24" which are not in the figure
>