Re: I-D Action: draft-ietf-rtgwg-qos-model-00.txt

tom petch <ietfa@btconnect.com> Thu, 10 October 2019 16:29 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D39C012006E for <rtgwg@ietfa.amsl.com>; Thu, 10 Oct 2019 09:29:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.248
X-Spam-Level:
X-Spam-Status: No, score=0.248 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XeVKXcBnNHNh for <rtgwg@ietfa.amsl.com>; Thu, 10 Oct 2019 09:29:10 -0700 (PDT)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20136.outbound.protection.outlook.com [40.107.2.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D24651200EF for <rtgwg@ietf.org>; Thu, 10 Oct 2019 09:29:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2KSyS+o5qutOkdozqvEAK1slp1zC4+wapEhOAwi4SbCRl3MveuPfHMPZWpQ0SMX5Ekxx6KJOt3s/gQe29gAXAEupWUpMyV91Kid2cX9/UIJzUCgbou/8Mj4obEvmM/48muvXBY7tzAgF9ClO6UanU2Kz8TeJ0/aiRW6FZCyfJfH8/feizzxeaUc/uNZ1zJJW3r/Sg9t5oS+/frFcVnFGXI5zJUuNS6+DifPmSI3PiqqQssExpPP5j3tPFPo3iqwKf2VEEgAWjNvCHU9PuXZe6fywF8wZCbPPnJwteto+8KVGQniFX5VxJFckgsVH84YT0/dxQVWQT1bwD3K4JJaFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31fM6WPATilR0g3Fl6aVp2F3+CCJnj1+FEUK9lKGCig=; b=lybBfN3X5sq+4GFQnimjRdWTsGFCQnTlny2M6cO4f1iybwo2xOq8D4PSAzp5nXgo9HndOENp4PohHasxk43RtnHw6oP3yWCVBxl/ynrbDycHtfH5mswAm9I2yRp+h85N5+TkjOCrRwVeL5fExbBNU8zcpi8BDw/uU4y9ZexQbV4fQLndDjgeIOBK/W5L0TtU27aK0M+fFyCBFeAK7Tw8U30T0hH+Hre5BhGib8BaVlpLz42WcopYinV0igV+WnHWplH5ZtTwQcINd7roVx1HhAWrdB4fFowrZg5ttTe0dJEpBjp9L/h8WNhNCTU8VeRKJqbExbgGTNN2WCnoYOF7jQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31fM6WPATilR0g3Fl6aVp2F3+CCJnj1+FEUK9lKGCig=; b=UltEjOKgYg0Y1m9QPsqUGywMAzWPnkVG6nTT4sA763YekjxmmXG7hgx/JryeRcXZNfVqtt7x8LPiahoGdE9VY6s2vDw5k+q32pVQouF9XaYE2anoJcurr0jVKmNUqtsHVwnGs2W6qe6U/wCI8mHeGGKMW5m0lIRhhYOJeimBuBA=
Received: from DB7PR07MB5451.eurprd07.prod.outlook.com (20.178.45.149) by DB7PR07MB5643.eurprd07.prod.outlook.com (20.178.44.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.15; Thu, 10 Oct 2019 16:29:07 +0000
Received: from DB7PR07MB5451.eurprd07.prod.outlook.com ([fe80::590d:7158:1659:6519]) by DB7PR07MB5451.eurprd07.prod.outlook.com ([fe80::590d:7158:1659:6519%3]) with mapi id 15.20.2347.016; Thu, 10 Oct 2019 16:29:07 +0000
From: tom petch <ietfa@btconnect.com>
To: "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: Re: I-D Action: draft-ietf-rtgwg-qos-model-00.txt
Thread-Topic: I-D Action: draft-ietf-rtgwg-qos-model-00.txt
Thread-Index: AQHVf4fWaoOl9xu7NUaUSY12uzT/9g==
Date: Thu, 10 Oct 2019 16:29:06 +0000
Message-ID: <010101d57f87$875b0760$4001a8c0@gateway.2wire.net>
References: <157066001829.26921.17198705939501698982@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LNXP265CA0033.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::21) To DB7PR07MB5451.eurprd07.prod.outlook.com (2603:10a6:10:76::21)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfa@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.211.103]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fdd54eae-dffa-4c71-e99a-08d74d9ef898
x-ms-traffictypediagnostic: DB7PR07MB5643:
x-ms-exchange-purlcount: 6
x-microsoft-antispam-prvs: <DB7PR07MB56432CB6254503E455F65AB6A2940@DB7PR07MB5643.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-forefront-prvs: 018632C080
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(366004)(136003)(396003)(346002)(13464003)(199004)(189003)(1556002)(52116002)(1730700003)(256004)(14444005)(81166006)(81156014)(2351001)(8676002)(6506007)(386003)(14496001)(8936002)(102836004)(81816011)(81686011)(316002)(76176011)(86362001)(66066001)(44716002)(62236002)(25786009)(14454004)(71200400001)(66574012)(71190400001)(5660300002)(305945005)(99286004)(4720700003)(61296003)(50226002)(7736002)(6916009)(476003)(446003)(6116002)(3846002)(6246003)(5640700003)(2501003)(229853002)(486006)(478600001)(6436002)(6486002)(44736005)(186003)(66476007)(66556008)(64756008)(66446008)(2906002)(66946007)(26005)(6512007)(6306002)(9686003)(966005)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB5643; H:DB7PR07MB5451.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: PCbW5BvpJdExvP6ENbzSWVtPmGeGCmuvPl26TJBY12wjlC2h3wEAFPSL0BA96kMXxCcbPfvXkI2BzdWtFtpek+evXY4yReEOy5n5tWiE0mN8NNKZ1Svu0ttkNisPBOrX68RXiJe+VTjzoE6Z/ushcjAFQ2c4b7Byjpl0udeGVA1p1UkoQQGTfMpbPyMK1nDDc0rYNTryWWC8+cf0zP61YbOpQKhLTyPhdLV0pcR6YeBNwQ5ULjhWtC5EbkeFqRxtdhVvIG2ImrNbs5mE18TU5/mX7//MpZc696pcUilYOOzD+CMjhJ8RdnbCkTU0WsFHsXjSemWlRgCKrlwwsLBICMpplEVADigLVug/78NGcQrJrn1JwTu6ZzfzD/VzaKTh6d0f+EkTohq/hDdTVa8ZWagZK3UlPdrKHkbYROkhW6TPXMi0zjRtge0PwFCKJWDjpwV/Vh0HrKdeuK/I3eKFEA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5E8ECDC1CACB3C488F0488C677079CA5@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdd54eae-dffa-4c71-e99a-08d74d9ef898
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2019 16:29:06.8266 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0QfbRP4s02HTCfvaaG7nHVcsM386x0XgC+WTKAtuXSLMMygRTJXWPBuVs3ErYRrtSnCMayhtVnhDctMwgh/coQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB5643
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/cgSFC76kW7yPubhm5wC4tBRLekY>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Oct 2019 16:29:12 -0000

uh huh; some stray thoughts on this I-D

s.9
   MITRE has approved this document for Public Release, Distribution
   Unlimited, with Public Release Case Number 19-3027.

Is this the beginnings of an IPR issue to be resolved? I don't know.


YANG Model for QoS

QoS is a very general concept for me, seeeing it more in the context of
system and application performance rather than just network so I would
like something in the title to make it clear that this is 'only'
routing;  ditto - especially - the Abstract.  Current RFC have something
in the title that makes this clear.

s.1
(NMDA) [RFC8342 [RFC8342]].
looks odd with [[ ]]

YANG has conditionals which many modellers overuse (IMHO:-)
Here I would like more.  You twice have min and max and so could require
that max> or >=  min.  Is it valid to have the one value, ie min = max,
or just a min?

contact (times seven)
     contact
       "WG Web:   <http://tools.ietf.org/wg/rtgwg/>
        WG List:  <mailto:rtgwg@ietf.org>
        WG Chair: Chris Bowers
                  <mailto:cbowers@juniper.net>
        WG Chair: Jeff Tantsura
                  <mailto:jefftant.ietf@gmail.com>
should not have the WG chair therein- they are too ephemeral ! - just
web, list, editors

There is a mismatch between the editors of the I-D and those of the YANG
modules; is this intended?

References in the YANG module - I would like more! e.g.
  identity one-rate-two-color-meter-type {
       base meter-type;
       description
         "one rate two color meter type";
     }
     identity one-rate-tri-color-meter-type { ...
        reference  "RFC2697: A Single Rate Three Color Marker";
     identity two-rate-tri-color-meter-type { ...
       reference    "RFC2698: A Two Rate Three Color Marker";

while some modules lack any such references for the identity; needs to
be consistent

or, still on Reference,

     grouping protocol-cfg {
       list protocol-cfg { key "protocol-min protocol-max";
         description  "list of ranges of protocol values";

which I read as being IPv4 only - IPv6 does not have protocol!  Perhaps
a name change or explanatory note plus a reference to the IANA website.


           choice drop-algorithm {
has only one case; if intended, an explanatory note would be useful


     augment "/if:interfaces/if:interface" {
is unqualified so this will be added to all interfaces in the box; I am
unclear if this is a good idea.


IANA !

Security !

s.A.1
            "RFC 6020: YANG - A Data Modeling Language ...

Tom Petch

----- Original Message -----
From: <internet-drafts@ietf.org>
To: <i-d-announce@ietf.org>
Cc: <rtgwg@ietf.org>
Sent: Wednesday, October 09, 2019 11:26 PM
Subject: I-D Action: draft-ietf-rtgwg-qos-model-00.txt


>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Routing Area Working Group WG of the
IETF.
>
>         Title           : YANG Model for QoS
>         Authors         : Aseem Choudhary
>                           Mahesh Jethanandani
>                           Norm Strahle
>                           Ebben Aries
>                           Ing-Wher Chen
> Filename        : draft-ietf-rtgwg-qos-model-00.txt
> Pages           : 89
> Date            : 2019-10-07
>
> Abstract:
>    This document describes a YANG model for Quality of Service (QoS)
>    configuration and operational parameters.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-rtgwg-qos-model/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-rtgwg-qos-model-00
> https://datatracker.ietf.org/doc/html/draft-ietf-rtgwg-qos-model-00
>
>
> Please note that it may take a couple of minutes from the time of
submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt