Re: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07

"Salz, Rich" <rsalz@akamai.com> Sat, 16 December 2017 07:46 UTC

Return-Path: <rsalz@akamai.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76CBC1270A3; Fri, 15 Dec 2017 23:46:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ICQdWWDKcFup; Fri, 15 Dec 2017 23:46:06 -0800 (PST)
Received: from mx0a-00190b01.pphosted.com (mx0a-00190b01.pphosted.com [IPv6:2620:100:9001:583::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 714B3126D85; Fri, 15 Dec 2017 23:46:06 -0800 (PST)
Received: from pps.filterd (m0122332.ppops.net [127.0.0.1]) by mx0a-00190b01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBG7goGm005380; Sat, 16 Dec 2017 07:46:05 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=jan2016.eng; bh=7xjZX+YXstt1rfp3txBslL5vr0LttYw4cWqJ78ndvFE=; b=FrxbHqy+Qm4eTg7zIIrACh2LnMR6bgPKETNbrLYicfDulrY9a60USq5s7i0zlK+6gA95 hdu/vsGRotGyQe2FEqH1CoB0Y6J0NsVvjZsmfzq0eq0uzkA90gir93+80b+hPwyTz+O+ eph3+M81Vqv9ZOuSKxwMm+9ROkJ+PqokpliTXmmzfv+tCNzHp6sxbFtZWboiGzY+rfpK JSe5LOJWlhw4U6Cre0G90YksoCDkGy/yCAQ7YpIUhAiSr6SZMffsLzeqFmbLS/+RXwhS +KSc2cYX7abkSHndgqkFvrBdNfwATQgOZsIJUrLzBAatpNlSKw3Mq2uEj/oC96w3oIeu xg==
Received: from prod-mail-ppoint1 (prod-mail-ppoint1.akamai.com [184.51.33.18]) by mx0a-00190b01.pphosted.com with ESMTP id 2evvdkgb9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Dec 2017 07:46:05 +0000
Received: from pps.filterd (prod-mail-ppoint1.akamai.com [127.0.0.1]) by prod-mail-ppoint1.akamai.com (8.16.0.21/8.16.0.21) with SMTP id vBG7ekMA017594; Sat, 16 Dec 2017 02:46:04 -0500
Received: from email.msg.corp.akamai.com ([172.27.123.31]) by prod-mail-ppoint1.akamai.com with ESMTP id 2evwhfr9fx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 16 Dec 2017 02:46:04 -0500
Received: from USMA1EX-DAG1MB1.msg.corp.akamai.com (172.27.123.101) by usma1ex-dag1mb3.msg.corp.akamai.com (172.27.123.103) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Sat, 16 Dec 2017 02:46:03 -0500
Received: from USMA1EX-DAG1MB1.msg.corp.akamai.com ([172.27.123.101]) by usma1ex-dag1mb1.msg.corp.akamai.com ([172.27.123.101]) with mapi id 15.00.1263.000; Sat, 16 Dec 2017 02:46:03 -0500
From: "Salz, Rich" <rsalz@akamai.com>
To: Xufeng Liu <Xufeng_Liu@jabil.com>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-rtgwg-yang-vrrp.all@ietf.org" <draft-ietf-rtgwg-yang-vrrp.all@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: Re: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
Thread-Topic: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
Thread-Index: AQHTdhtyAEo6q5OIrk27kJy52+Wiz6NF63KA
Date: Sat, 16 Dec 2017 07:46:03 +0000
Message-ID: <393FFD7E-FBEF-4DC4-9CCC-6C5DDD5E2941@akamai.com>
References: <151250038233.23003.7660980675190435187@ietfa.amsl.com> <BN3PR0201MB0867D18791FCDFFACE8794C5F1080@BN3PR0201MB0867.namprd02.prod.outlook.com>
In-Reply-To: <BN3PR0201MB0867D18791FCDFFACE8794C5F1080@BN3PR0201MB0867.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.27.0.171010
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.19.152.103]
Content-Type: text/plain; charset="utf-8"
Content-ID: <E113F078439AE548AC8F06EA73D2053A@akamai.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-12-16_04:, , signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712160123
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-12-16_04:, , signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712160124
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/csenRkj_OOz7gvAkn72wCPgu68I>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Dec 2017 07:46:08 -0000

Looks good to me thanks!

On 12/16/17, 3:10 AM, "Xufeng Liu" <Xufeng_Liu@jabil.com> wrote:

    Hi Rich,
    
    Thanks for the review. We have posted an updated version of the draft https://tools.ietf.org/html/draft-ietf-rtgwg-yang-vrrp-08 to address your comments.
    
    Thanks,
    - Xufeng
    
    > -----Original Message-----
    > From: Rich Salz [mailto:rsalz@akamai.com]
    > Sent: Tuesday, December 5, 2017 2:00 PM
    > To: secdir@ietf.org
    > Cc: draft-ietf-rtgwg-yang-vrrp.all@ietf.org; ietf@ietf.org; rtgwg@ietf.org
    > Subject: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
    > 
    > Reviewer: Rich Salz
    > Review result: Ready
    > 
    > I did this review for the Security Directorate (SECDIR) to help the Security AD's.
    > 
    > This document is ready.
    > 
    > Section 1.2 gives an augmented diagram syntax; is that common? Should it be
    > added to "yang proper"?
    
    [Xufeng] This section in the previous version used an older convention to describe the diagram syntax. Because of the new available draft-ietf-netmod-yang-tree-diagrams-02, we have updated this section to use the new convention.
    
    > 
    > The security considerations is short and to the point. This document describes a
    > data model, so the security considerations properly point call out requirements
    > on any transport mechanism used.  Calling out particularly vulnerable nodes is
    > good practice. Perhaps add a sentence saying that "implemented should review
    > all the nodes for security concerns" might be useful.
    
    [Xufeng] Added the sentence as suggested.
    >