Re: I-D Action: draft-ietf-rtgwg-yang-vrrp-06.txt

Robert Wilton <rwilton@cisco.com> Fri, 27 October 2017 09:11 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6216D13A902; Fri, 27 Oct 2017 02:11:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HN2jhRNpueRt; Fri, 27 Oct 2017 02:11:41 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EE0113A5CF; Fri, 27 Oct 2017 02:11:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7555; q=dns/txt; s=iport; t=1509095500; x=1510305100; h=subject:to:references:from:message-id:date:mime-version: in-reply-to; bh=/ddhbLnmLSl4MqlGfKeaUMZaPQ1wIQ1c6XbFWx2aoNs=; b=TS9r1OQoW9PuWKugJ0rumyxeQgZOHY2yW3ZhkHnFKqt4zUE/H9M9Lb2u cCLAWkYh9/86VVG3O5/eybefzhMT7R/qjyX/a8KYy1/b8iJsuwYQs6rHr wV6HsNSrwxYyjtddiOO+X7fUfTNRrxjRaj0qRfo77KvxehHWqMw6AVSWQ w=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CfAAAl9/JZ/xbLJq1bGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgm9CgRJuJ4N6ih90j3ImkH2FRYIRChgBCoUYAoUEGAECAQEBAQE?= =?us-ascii?q?BAWsohR4BAQEDAQEhSxsLGCoCAicwBgEMBgIBAYofEKkHgicmikgBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEdgy6DV4FpKQuCdoMyhGiCYQWiAodmjRWCFV6FIoNfhzm?= =?us-ascii?q?KK4IzgUeHaYE5HziBaDQhCB0VHyqCZAmEV0A2i2wBAQE?=
X-IronPort-AV: E=Sophos;i="5.44,304,1505779200"; d="scan'208,217";a="656611346"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2017 09:11:38 +0000
Received: from [10.63.23.64] (dhcp-ensft1-uk-vla370-10-63-23-64.cisco.com [10.63.23.64]) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v9R9Bcp9001782; Fri, 27 Oct 2017 09:11:38 GMT
Subject: Re: I-D Action: draft-ietf-rtgwg-yang-vrrp-06.txt
To: "draft-ietf-rtgwg-yang-vrrp@ietf.org" <draft-ietf-rtgwg-yang-vrrp@ietf.org>, rtgwg@ietf.org
References: <150904446702.24061.12203024588322384758@ietfa.amsl.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <4b6d7953-8d9f-4658-327a-b41d629de8b0@cisco.com>
Date: Fri, 27 Oct 2017 10:11:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <150904446702.24061.12203024588322384758@ietfa.amsl.com>
Content-Type: multipart/alternative; boundary="------------60ED932BB4050A23EFC1A58B"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/fsv8QQLyhivOrqTWKg8yzWyqBXI>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Oct 2017 09:11:43 -0000

Hi authors,

One minor nit, I think that you need to update the tree diagram to show 
that the top level "vrrp" container is config false.

E.g.

OLD:

    module: ietf-vrrp
       +--rw vrrp
          +--ro <global operational states>
          +--ro statistics
             +--ro discontinuity-datetime?   yang:date-and-time
             +--ro <global statistics>

NEW:


    module: ietf-vrrp
       +--ro vrrp
          +--ro <global operational states>
          +--ro statistics
             +--ro discontinuity-datetime?   yang:date-and-time
             +--ro <global statistics>


Otherwise, looks good to me!

Thanks,
Rob


On 26/10/2017 20:01, internet-drafts@ietf.org wrote:
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Routing Area Working Group WG of the IETF.
>
>          Title           : A YANG Data Model for Virtual Router Redundancy Protocol (VRRP)
>          Authors         : Xufeng Liu
>                            Athanasios Kyparlis
>                            Ravi Parikh
>                            Acee Lindem
>                            Mingui Zhang
> 	Filename        : draft-ietf-rtgwg-yang-vrrp-06.txt
> 	Pages           : 42
> 	Date            : 2017-10-26
>
> Abstract:
>     This document describes a data model for Virtual Router Redundancy
>     Protocol (VRRP).  Both version 2 and version 3 of VRRP are covered.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-vrrp/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-rtgwg-yang-vrrp-06
> https://datatracker.ietf.org/doc/html/draft-ietf-rtgwg-yang-vrrp-06
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-rtgwg-yang-vrrp-06
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> rtgwg mailing list
> rtgwg@ietf.org
> https://www.ietf.org/mailman/listinfo/rtgwg
> .
>