Re: FW: New Version Notification for draft-ding-rtgwg-arp-yang-model-00.txt

Robert Wilton <rwilton@cisco.com> Tue, 16 January 2018 16:53 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C58A131562 for <rtgwg@ietfa.amsl.com>; Tue, 16 Jan 2018 08:53:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xJdvKeeA_ChA for <rtgwg@ietfa.amsl.com>; Tue, 16 Jan 2018 08:53:44 -0800 (PST)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9C751315DE for <rtgwg@ietf.org>; Tue, 16 Jan 2018 08:53:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4078; q=dns/txt; s=iport; t=1516121616; x=1517331216; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=QTLnPpXPSigfCVqi8ZOaPDhfyFN+I6KM6JqEh/YOXyo=; b=gZzM9i7kw47jiPbszpIs7GWo+LVcaj9O0vKuEZvqvlyzARSOmGR2ZBOo npgopj2ywPcAQihShRiE5GjFEUJDk17K+ZgwsI5tnEijm0/ouO9b+Lwry K7pnyS5Nz4y+sPx7OYTNPEpUGbH3v5/Pz7wQbsnlERH9dStbt4Rtoy9pV 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0B3AQBnLV5a/xbLJq1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQndCeEE4sYjzwymUIKGA2FFgKFHxQBAQEBAQEBAQFrKIUjAQE?= =?us-ascii?q?BAwEBASEPAQU2CQIFBwQLEQEDAQEBAgIjAwICJx8DBQEIBg0GAgEBiicIEKUyg?= =?us-ascii?q?ieJSwEBAQEBAQEBAQEBAQEBAQEBAQEBAR2BD4cZgWkpgwWDLwEBAgEBhQSCZQW?= =?us-ascii?q?KXYdKkT2IDI0/ghlnhTaDbyaHRY0+gV6ICYE8NiKBUDIaCBsVGSSCKgmETkE3A?= =?us-ascii?q?YxPAQEB?=
X-IronPort-AV: E=Sophos;i="5.46,369,1511827200"; d="scan'208";a="1437312"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 16:53:33 +0000
Received: from [10.63.23.131] (dhcp-ensft1-uk-vla370-10-63-23-131.cisco.com [10.63.23.131]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id w0GGrXHd020110; Tue, 16 Jan 2018 16:53:33 GMT
Subject: Re: FW: New Version Notification for draft-ding-rtgwg-arp-yang-model-00.txt
To: "dingxiaojian (A)" <dingxiaojian1@huawei.com>
Cc: "rtgwg@ietf.org" <rtgwg@ietf.org>
References: <151577042484.18747.17258702775261292793.idtracker@ietfa.amsl.com> <3B110B81B721B940871EC78F107D848C010753B3@DGGEMM506-MBS.china.huawei.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <56c39ddb-8afa-6cfb-43a6-91d0de2497dc@cisco.com>
Date: Tue, 16 Jan 2018 16:53:33 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <3B110B81B721B940871EC78F107D848C010753B3@DGGEMM506-MBS.china.huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/j1uk2F4jfgCS11UCcBmy0TPLW5Y>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 16:53:46 -0000

Hi Xiaojian,

Just some quick (mostly structural) comments from a cursory review of 
the tree structure:

1) I don't think that you need the arp-static-tables container at all, 
since "if:interfaces/if:interface/ipv4/neighbor" can be used to 
configure static ARP entries.

2) I would rename the "arp-statistics" container to "statistics", since 
it is already under the "arp" top level container.

3) I would delete the "arp/arp-statistics/local-statistics" container.  
These statistics can just be specified directly under the interface.

4) It looks like "augment 
/if:interfaces/if:interface/ip:ipv4/ip:neighbor:" is empty and can be 
deleted?

5) Not sure about the "vrf-name" augmentation to 
"/if:interfaces-state/if:interface/ip:ipv4/ip:neighbor", shouldn't the 
VRF binding be at the interface level rather than ARP entry level?

6) Put the interface augmentations under an "arp" sub-container, then 
you can lose the "arp" prefix on the individual leaves.

7) Perhaps make "arp-gratuitous" a container with presence with 
arp-gratuitous-interval underneath, probably renamed just to "interval".

8) All the "config false" state variables should follow the NMDA 
architecture.  I.e. for this draft, I would suggest just augmenting them 
under the config tree, and depend on RFC 7223bis.  So all the ARP 
interface counters should probably go under 
/if:interfaces/if:interface:/arp:arp/arp:statistics

9) This is just a stylistic preference, but I would reduce (or perhaps 
avoid) groupings, I think that the YANG file is easier to read without them.

10) In terms of naming the statistics, I would suggest aligning them to 
the statistics style in RFC 7223 if possible.

Anyway, hopefully these comments are useful.

Thanks,
Rob


On 15/01/2018 03:04, dingxiaojian (A) wrote:
> Hi rtgwg,
>
> After IETF 100, we have received some valuable suggestions for improving the ARP YANG module. According to the suggestion of WG chair, we put the work on RTGWG and submit a new draft for ARP YANG module.
> In the new version, we have also clarified some functions (e.g., arp-static-table configuration) are different from the previously defined ones (e.g., arp static tables defined in RFC 7277).
> Please have a look and provide comments on the list.
> Best Regards,
> Xiaojian
>
> -----Original Message-----
> From: internet-drafts@ietf.org [mailto:internet-drafts@ietf.org]
> Sent: Friday, January 12, 2018 11:20 PM
> To: Zhengfeng (Habby) <habby.zheng@huawei.com>;; dingxiaojian (A) <dingxiaojian1@huawei.com>;; dingxiaojian (A) <dingxiaojian1@huawei.com>;
> Subject: New Version Notification for draft-ding-rtgwg-arp-yang-model-00.txt
>
>
> A new version of I-D, draft-ding-rtgwg-arp-yang-model-00.txt
> has been successfully submitted by Xiaojian Ding and posted to the IETF repository.
>
> Name:		draft-ding-rtgwg-arp-yang-model
> Revision:	00
> Title:		YANG Data Model for ARP
> Document date:	2018-01-11
> Group:		Individual Submission
> Pages:		16
> URL:            https://www.ietf.org/internet-drafts/draft-ding-rtgwg-arp-yang-model-00.txt
> Status:         https://datatracker.ietf.org/doc/draft-ding-rtgwg-arp-yang-model/
> Htmlized:       https://tools.ietf.org/html/draft-ding-rtgwg-arp-yang-model-00
> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ding-rtgwg-arp-yang-model-00
>
>
> Abstract:
>     This document defines a YANG data model to describe Address
>     Resolution Protocol (ARP) configurations.  It is intended this model
>     be used by service providers who manipulate devices from different
>     vendors in a standard way.
>
>                                                                                    
>
>
> Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org.
>
> The IETF Secretariat
>
> _______________________________________________
> rtgwg mailing list
> rtgwg@ietf.org
> https://www.ietf.org/mailman/listinfo/rtgwg
> .
>