RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02

Mach Chen <mach.chen@huawei.com> Wed, 01 August 2018 08:48 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39C7F130DFD; Wed, 1 Aug 2018 01:48:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level:
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LNRu04dmk_C0; Wed, 1 Aug 2018 01:48:50 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FF60130DF1; Wed, 1 Aug 2018 01:48:50 -0700 (PDT)
Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 8AAAF16CDB53F; Wed, 1 Aug 2018 09:48:44 +0100 (IST)
Received: from DGGEML422-HUB.china.huawei.com (10.1.199.39) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.399.0; Wed, 1 Aug 2018 09:48:46 +0100
Received: from DGGEML510-MBX.china.huawei.com ([169.254.2.219]) by dggeml422-hub.china.huawei.com ([10.1.199.39]) with mapi id 14.03.0382.000; Wed, 1 Aug 2018 16:48:43 +0800
From: Mach Chen <mach.chen@huawei.com>
To: "draft-ding-rtgwg-arp-yang-model.all@ietf.org" <draft-ding-rtgwg-arp-yang-model.all@ietf.org>, "rtgwg-chairs@ietf.org" <rtgwg-chairs@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02
Thread-Topic: RtgDir Early review: draft-ding-rtgwg-arp-yang-model-02
Thread-Index: AdQpbPZGpZjDvuQVSkSl2W0Je7u8pg==
Date: Wed, 1 Aug 2018 08:48:43 +0000
Message-ID: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE292563246@dggeml510-mbx.china.huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.194.201]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/pvwoUn16sVZf-I4Zg1aCRMf4qBw>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 08:48:54 -0000

Hello 

I have been selected to do a routing directorate “early” review of this draft. 
​ https://tools.ietf.org/html/draft-ding-rtgwg-arp-yang-model-02 

The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached. As this document is in working group last call, my focus for the review was to determine whether the document is ready to be published. Please consider my comments along with the other working group last call comments. 

For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir 

Document: draft-ding-rtgwg-arp-yang-model-02 
 Reviewer: Mach Chen 
 Review Date: 01 August 2018 
 Intended Status: Standards Track 

Summary 

The draft  defines a YANG model for ARP configurations, which covers static ARP, ARP caching, proxy ARP and gratuitous ARP. The model is very short and the content is straightforward. It can be a reasonable start point for WG adoption call. 

General comments:

Although I am not a native English speaker, I also feel that the document needs some enhancements on its wording and grammar to make it more clean and readable. 

For example,  the following text needs some rewording or may be removed. 
Abstract:
"The data model performs as
   a guideline for configuring ARP capabilities on a system.  It is
   intended this model be used by service providers who manipulate
   devices from different vendors in a standard way."

Specific comments:

1. It's lack of the IANA section.

2. Section 3.1 and Section 3.3,  suggest to add relevant references to ARP caching and gratuitous ARP.

3.  import ietf-interfaces {
    prefix if;
    description
      "A Network Management Datastore Architecture (NMDA)
       compatible version of the ietf-interfaces module
       is required.";
  }
  import ietf-ip {
    prefix ip;
    description
      "A Network Management Datastore Architecture (NMDA)
       compatible version of the ietf-ip module is
       required.";
  }

Lack of the reference RFCs. 
And the descriptions seem not appropriate, some of other descriptions in this document have the similar issue, suggest to revise those descriptions. 

In addition, idnits tool shows:

== Missing Reference: 'RFC826' is mentioned on line 77, but not defined

  == Missing Reference: 'RFC6536' is mentioned on line 583, but not defined

  ** Obsolete undefined reference: RFC 6536 (Obsoleted by RFC 8341)

  == Unused Reference: 'I-D.ietf-netmod-rfc7223bis' is defined on line 606,
     but no explicit reference was found in the text

  == Unused Reference: 'RFC0826' is defined on line 636, but no explicit
     reference was found in the text


Best regards,
Mach