Genart last call review of draft-ietf-rtgwg-lne-model-05

Russ Housley <housley@vigilsec.com> Sat, 20 January 2018 23:36 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: rtgwg@ietf.org
Delivered-To: rtgwg@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B845C1270AC; Sat, 20 Jan 2018 15:36:38 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley <housley@vigilsec.com>
To: <gen-art@ietf.org>
Cc: draft-ietf-rtgwg-lne-model.all@ietf.org, ietf@ietf.org, rtgwg@ietf.org
Subject: Genart last call review of draft-ietf-rtgwg-lne-model-05
X-Test-IDTracker: no
X-IETF-IDTracker: 6.69.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151649139871.3209.16979766632857661358@ietfa.amsl.com>
Date: Sat, 20 Jan 2018 15:36:38 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/tTb-eUZShXgQOgSiRoMdwVUHv1I>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Jan 2018 23:36:39 -0000

Reviewer: Russ Housley
Review result: Not Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-rtgwg-lne-model-05
Reviewer: Russ Housley
Review Date: 2018-01-20
IETF LC End Date: 2018-01-31
IESG Telechat date: 2018-02-08

Summary: Not Ready

Major Concerns:

Section 4 listed three data nodes that are sensitive or vulnerable:
   -  /logical-network-elements/logical-network-element
   -  /logical-network-elements/logical-network-element/managed
   -  /if:interfaces/if:interface/bind-lne-name

All three of them deserve a bit more discussion, although the middle
one is covered in much more detail than the other two.  If a bad actor
gets "unauthorized access" is there something more specific about each
of these that can be said?  The characterization of "network
malfunctions, delivery of packets to inappropriate destinations, and
other problems" seems very broad.  Consequences that are specific to
these data nodes would be more helpful to the reader.


Minor Concerns:

Section 1.1: Please update the first paragraph to reference RFC 8174
in addition to RFC 2119, as follows: 

   The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
   "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and
   "OPTIONAL" in this document are to be interpreted as described in BCP
   14 [RFC2119] [RFC8174] when, and only when, they appear in all
   capitals, as shown here.


Nits:

Abstract: YANG appears in the title and the introduction.  So, I was a
bit surprised that YANG did not appear anywhere in the Abstract.

This document seems to refer to itself as "RFC XXXX" and "RFC TBD".
Please pick one and use it throughout the document.