RE: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07

Xufeng Liu <Xufeng_Liu@jabil.com> Sat, 16 December 2017 03:10 UTC

Return-Path: <Xufeng_Liu@jabil.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE90E124D85; Fri, 15 Dec 2017 19:10:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.919
X-Spam-Level:
X-Spam-Status: No, score=-1.919 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=jabil.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zc2porCErVKx; Fri, 15 Dec 2017 19:10:35 -0800 (PST)
Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0128.outbound.protection.outlook.com [104.47.42.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7FC20124B18; Fri, 15 Dec 2017 19:10:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jabil.onmicrosoft.com; s=selector1-jabil-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y+NSRtLShmjpSXS5x7Yl8kLKnug8JlFTDnQiKUF2INc=; b=w5hSz/QpMsiduMMvf3TQIyMCI6tlVQ4QeWnLVg0QpsYEWw3+IvIVHbbFaw2W1LFpfP9OQucE/pqWiSGo4q352SSfpiJ7y36CL3bacweOqL+r22ydx2eHinoIpHVHvVL+f4pUL1kDP0E1zabviMS/gbkDZUUU8m80RRZ0mQOwAIg=
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com (10.160.154.13) by BN3PR0201MB0868.namprd02.prod.outlook.com (10.160.154.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Sat, 16 Dec 2017 03:10:33 +0000
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) by BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) with mapi id 15.20.0302.017; Sat, 16 Dec 2017 03:10:33 +0000
From: Xufeng Liu <Xufeng_Liu@jabil.com>
To: Rich Salz <rsalz@akamai.com>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-rtgwg-yang-vrrp.all@ietf.org" <draft-ietf-rtgwg-yang-vrrp.all@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: RE: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
Thread-Topic: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
Thread-Index: AQHTbfs5HZyHCpQDe0CooPKi1JZM26NFWQ8g
Date: Sat, 16 Dec 2017 03:10:33 +0000
Message-ID: <BN3PR0201MB0867D18791FCDFFACE8794C5F1080@BN3PR0201MB0867.namprd02.prod.outlook.com>
References: <151250038233.23003.7660980675190435187@ietfa.amsl.com>
In-Reply-To: <151250038233.23003.7660980675190435187@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNceGxpdVxhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLWFjYmIyOTc4LWUyMGUtMTFlNy05YzNjLTE4NWUwZmUzYzQ1Y1xhbWUtdGVzdFxhY2JiMjk3YS1lMjBlLTExZTctOWMzYy0xODVlMGZlM2M0NWNib2R5LnR4dCIgc3o9IjE1MjUiIHQ9IjEzMTU3ODY3NDMyNTE3NDc3OSIgaD0iOHVseGNaZ3l0MmI0NmpPVlJsckF3S1k0eG5jPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg==
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Xufeng_Liu@jabil.com;
x-originating-ip: [72.209.195.86]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN3PR0201MB0868; 6:gomOLmLzI+DGgW379MJLv2wF29STIlfB47FS6g1r2KtQMGoZB71L2LcJCgWgpHzAfBt+807ztcRyJWmbjBp5FKw0txZUGPM6W/frBgNiesGckHLDmYSvERCKS0Rv9S8DCj740wlkO+CbQUCaQet44Zj8skVnD8Q/i0QB3wiv8/8W2DOUMEahv7TzXspxh/N44YWQeA9i6kldKJPxHwZ30s9BL70yN+M+97m4MiRGNXDixAr/fhnczi+V5jkK53B7zMdVXPNsRdMv3361occkUpUdwDW7+ocUESr2VScpYxgZRtkAfnV5BUK0op4wttFAj79wknDb0olGYR5zMsClQ+nzuscoxLpr2GM82OVRDsw=; 5:H4XTUGzp4V79AwatnS2slCW7rLWU0puSWErUB2oA00vcsgczXFFJ0wTTWl/fqbbTU3GfguhMjPMulolkCj7VBbgUKAVu4shozZTainDZHEJpz6hVdgsB4s+ilKazm9OXOBM2lTKNoBe2AB5VDBdGcgI1t+dwlybtZdrW0YVvv+o=; 24:JIjg0yWijhnzyut+hfjBSmvxdFmCIOI9rrohsSQ1mgBwKDDEaaJb0QoUtyrwFg3Wtl0474YaGAN0CjkLge3FcUw83DSdW56TXjdLSy7+vJE=; 7:aNyFXiRfyEUAMOyycUwf2id77UbjO+VrsFXVdpZ7jpgWf7TSYTMhpmj3Cc/7szsic/k3sgp3KxyW5FqcrwLbYc3Uole6Zpf+zd/o4fqvGye2lHvRkHA3cFdYr1mU5B96oeuZSxcqMnoH+Xi0y1f+XuH1vOLsQM8qRmKFNOKu4Ja8vFuC6XxxrTNUxjjo14Uqn0bub6wM9EAFYScNx9Phb6OBJN8eOd6wpDa2y1p1HBuGl6NLXWCUZk+56tT19k58
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 2dae4e7b-5213-4c25-0fa8-08d544329231
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:BN3PR0201MB0868;
x-ms-traffictypediagnostic: BN3PR0201MB0868:
x-microsoft-antispam-prvs: <BN3PR0201MB086816457152DC5E8F9933D7F1080@BN3PR0201MB0868.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(192374486261705);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231023)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN3PR0201MB0868; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR0201MB0868;
x-forefront-prvs: 0523CF0711
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(346002)(396003)(376002)(39860400002)(199004)(189003)(51914003)(13464003)(72206003)(230783001)(66066001)(106356001)(33656002)(105586002)(3280700002)(3660700001)(76176011)(2906002)(2900100001)(316002)(81156014)(25786009)(8676002)(68736007)(81166006)(99286004)(14454004)(966005)(478600001)(6506007)(7696005)(3846002)(55016002)(6116002)(7736002)(305945005)(53936002)(86362001)(2501003)(8936002)(2950100002)(74316002)(6246003)(9686003)(77096006)(6436002)(4326008)(5660300001)(229853002)(80792005)(59450400001)(97736004)(54906003)(6306002)(53546011)(110136005)(102836003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0201MB0868; H:BN3PR0201MB0867.namprd02.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: jabil.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: jabil.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dae4e7b-5213-4c25-0fa8-08d544329231
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2017 03:10:33.2660 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bc876b21-f134-4c12-a265-8ed26b7f0f3b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0868
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/ysGCj2JIvFxT7T_t_bN5sHY2oi8>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Dec 2017 03:10:39 -0000

Hi Rich,

Thanks for the review. We have posted an updated version of the draft https://tools.ietf.org/html/draft-ietf-rtgwg-yang-vrrp-08 to address your comments.

Thanks,
- Xufeng

> -----Original Message-----
> From: Rich Salz [mailto:rsalz@akamai.com]
> Sent: Tuesday, December 5, 2017 2:00 PM
> To: secdir@ietf.org
> Cc: draft-ietf-rtgwg-yang-vrrp.all@ietf.org; ietf@ietf.org; rtgwg@ietf.org
> Subject: Secdir last call review of draft-ietf-rtgwg-yang-vrrp-07
> 
> Reviewer: Rich Salz
> Review result: Ready
> 
> I did this review for the Security Directorate (SECDIR) to help the Security AD's.
> 
> This document is ready.
> 
> Section 1.2 gives an augmented diagram syntax; is that common? Should it be
> added to "yang proper"?

[Xufeng] This section in the previous version used an older convention to describe the diagram syntax. Because of the new available draft-ietf-netmod-yang-tree-diagrams-02, we have updated this section to use the new convention.

> 
> The security considerations is short and to the point. This document describes a
> data model, so the security considerations properly point call out requirements
> on any transport mechanism used.  Calling out particularly vulnerable nodes is
> good practice. Perhaps add a sentence saying that "implemented should review
> all the nodes for security concerns" might be useful.

[Xufeng] Added the sentence as suggested.
>