Re: [saag] AD sponsoring draft-josefsson-scrypt-kdf

Stephen Farrell <stephen.farrell@cs.tcd.ie> Mon, 10 August 2015 23:25 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: saag@ietfa.amsl.com
Delivered-To: saag@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C86CC1A1A68 for <saag@ietfa.amsl.com>; Mon, 10 Aug 2015 16:25:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.311
X-Spam-Level:
X-Spam-Status: No, score=-4.311 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LXw1Y4w8TSlA for <saag@ietfa.amsl.com>; Mon, 10 Aug 2015 16:25:46 -0700 (PDT)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A12F51A1A8B for <saag@ietf.org>; Mon, 10 Aug 2015 16:25:45 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id 6CF71BE8B for <saag@ietf.org>; Tue, 11 Aug 2015 00:25:44 +0100 (IST)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XPqH_na4B8ta for <saag@ietf.org>; Tue, 11 Aug 2015 00:25:42 +0100 (IST)
Received: from [10.87.48.73] (unknown [86.46.29.218]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id 592BABE87 for <saag@ietf.org>; Tue, 11 Aug 2015 00:25:42 +0100 (IST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cs.tcd.ie; s=mail; t=1439249142; bh=DR5LUPgGDVbgUYij3pPx6WdOJD41jj79alkbobNBpT4=; h=Date:From:To:Subject:References:In-Reply-To:From; b=cgWI2ldx8KwYRCYKvTiEAk3PdqYIP7NL7lcUVK5miWOFQsfOlpAY8wFLHQH/Wp7i8 lb2WA9vts8iWg36CJOh9WNaqdX0cT479SSIZvNQIk8k4f8XYXznCkr7qtuBvlssmoE tGdkRy5CtxGNXYaK+Vz1Aj4gkEeLZFOF9MC0JO18=
Message-ID: <55C932F6.7080203@cs.tcd.ie>
Date: Tue, 11 Aug 2015 00:25:42 +0100
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: "saag@ietf.org" <saag@ietf.org>
References: <559153E0.5050102@cs.tcd.ie>
In-Reply-To: <559153E0.5050102@cs.tcd.ie>
OpenPGP: id=D66EA7906F0B897FB2E97D582F3C8736805F8DA2; url=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/saag/-ghE4pTMxGgMEV1sxdf0_sN5iqA>
Subject: Re: [saag] AD sponsoring draft-josefsson-scrypt-kdf
X-BeenThere: saag@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Advisory Group <saag.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/saag>, <mailto:saag-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/saag/>
List-Post: <mailto:saag@ietf.org>
List-Help: <mailto:saag-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/saag>, <mailto:saag-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2015 23:25:50 -0000

With apologies to the author/shepherd, I forgot about this one;-(

I'm going to start IETF last call now. My own comments below can
be handled with any other last call comments.

Cheers,
S.


- intro: Maybe take a look at the intro to RFC7539. I think
it does a good job of presenting the background (for a
similar DJB production:-) so it might be worth seeing if
there's anything you want to copy from that.

- intro, para 1: some more references (or one ref to a
survey paper) would be good

- intro, para 2: "as Bernstein pointed out" requires a
reference

- section 13: whassup with that? why isn't the usual IETF
boilerplate ok?

- section 16: saying the reader "must" follow crypto
research is silly as you cannot ensure readers will do that
(and you know they won't:-). I think you mean that if you
don't keep up to date then you might miss out when issues
are found with this algorithm. If so, saying so would be
better.

- 17: I'm not sure the RFC editor will like references that
only point to http://cr.yp.to/ or tarsnap.com. If you have
better citations in addition that'd be good.