Re: [saag] AD Sponsorship of draft-housley-ers-asn1-modules
Russ Housley <housley@vigilsec.com> Sun, 20 June 2021 15:40 UTC
Return-Path: <housley@vigilsec.com>
X-Original-To: saag@ietfa.amsl.com
Delivered-To: saag@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6063E3A1A78 for <saag@ietfa.amsl.com>; Sun, 20 Jun 2021 08:40:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.003
X-Spam-Level:
X-Spam-Status: No, score=0.003 tagged_above=-999 required=5 tests=[SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wn42TlmOfkcH for <saag@ietfa.amsl.com>; Sun, 20 Jun 2021 08:40:21 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12B093A1A77 for <saag@ietf.org>; Sun, 20 Jun 2021 08:40:21 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id B7634300BEC for <saag@ietf.org>; Sun, 20 Jun 2021 11:40:19 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id euatJ6ne3pFk for <saag@ietf.org>; Sun, 20 Jun 2021 11:40:13 -0400 (EDT)
Received: from a860b60074bd.fios-router.home (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 1E63D300B2C; Sun, 20 Jun 2021 11:40:12 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <023101d765ad$e27e6200$a77b2600$@gondrom.org>
Date: Sun, 20 Jun 2021 11:40:12 -0400
Cc: "Roman D. Danyliw" <rdd@cert.org>, IETF SAAG <saag@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AAA93914-AA90-4477-AF68-DD6280E4928E@vigilsec.com>
References: <12861641c9f345868f3201bfac6c3db9@cert.org> <2474C9E1-2860-4648-BD94-1A084CFA21A4@sn3rd.com> <023101d765ad$e27e6200$a77b2600$@gondrom.org>
To: Tobias Gondrom <tobias.gondrom@gondrom.org>, Sean Turner <sean@sn3rd.com>
X-Mailer: Apple Mail (2.3445.104.21)
Archived-At: <https://mailarchive.ietf.org/arch/msg/saag/X9l2MPhqtEcQA4dunFhBMj4NQcs>
Subject: Re: [saag] AD Sponsorship of draft-housley-ers-asn1-modules
X-BeenThere: saag@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Advisory Group <saag.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/saag>, <mailto:saag-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/saag/>
List-Post: <mailto:saag@ietf.org>
List-Help: <mailto:saag-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/saag>, <mailto:saag-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Jun 2021 15:40:26 -0000
Thanks to Sean and Tobias for their reviews. As discussed by Carl in a previous response, item (0) in Sean's review is not a problem. No change there. In the -02 version of the document, all but one of the rest were addressed. Sean said: > Since the ExpandedWantBacks are All, New, and ERS might consider > reorganizing them in the ASN to match that pattern. The AllWantBacks is imported, so it necessarily comes at the top. Then, NewWantBacks and ERSWantBacks are in the order listed. If a change is needed, I'm not seeing it. Russ > On Jun 20, 2021, at 4:25 AM, <tobias.gondrom@gondrom.org> <tobias.gondrom@gondrom.org> wrote: > > I took a review/look at this update as well. > It has been a while since I last worked on ERS, so am a bit rusty... > But reviewed and no problems as far as I can tell. > > Best regards, Tobias > > > -----Original Message----- > From: saag <saag-bounces@ietf.org> On Behalf Of Sean Turner > Sent: Wednesday, June 9, 2021 11:04 PM > To: Roman Danyliw <rdd@cert.org> > Cc: saag@ietf.org > Subject: Re: [saag] AD Sponsorship of draft-housley-ers-asn1-modules > > Roman, > > I have but one point to raise and then some cosmetic nits (cosmetic because > compilers ignore whitespace). > > 0) Point to Raise: > > re: AllWantBacks. I am not entirely sure whether what is there for > swb-ers-all WANT-BACK merely defines the new value or whether it also adds > it to the list of available AllWantBacks. AllWantBacks is imported from RFC > 5912: > > AllWantBacks WANT-BACK ::= { > WantBackSet | ACertWantBackSet | AnyWantBackSet, ... > } > > To add swb-ers-all to the list, I wonder whether merely defining it is > enough. Is there something more that needs to be done to get it into the > list as the fourth option? > > 1) Cosmetic Nits: > > Header: > > s/New ASN.1 Modules for the Evidence Recor /New ASN.1 Modules for the > Evidence Record > > s2 (remove space, add space): > > s/{ v1(1) } ,/{ v1(1) }, > s/AttributeSet{{ERSAttrSet}}/AttributeSet {{ERSAttrSet}} > > s3: > > Since the ExpandedWantBacks are All, New, and ERS might consider > reorganizing them in the ASN to match that pattern. > > s (fix indention of evidence record)/ > EvidenceRecordWantBack ::= SEQUENCE { > targetWantBack WANT-BACK.&id ({ExpandedWantBacks}), > evidenceRecord EvidenceRecord OPTIONAL } / EvidenceRecordWantBack ::= > SEQUENCE { > targetWantBack WANT-BACK.&id ({ExpandedWantBacks}), > evidenceRecord EvidenceRecord OPTIONAL } > > s/{id-swb 16 }/{ id-swb 16 } > s/{id-swb 17 }/{ id-swb 17 } > s/{id-swb 18 }/{ id-swb 18 } > s/{id-swb 19 }/{ id-swb 19 } > s/{id-swb 20 }/{ id-swb 20 } > >> On May 14, 2021, at 16:45, Roman Danyliw <rdd@cert.org> wrote: >> >> Hi! >> >> Per the community interest and dispatch result at IETF 110 [1], I am AD > sponsoring draft-housley-ers-asn1-modules [2]. >> >> I welcome early feedback or reviews on this document. >> >> Regards, >> Roman >> >> [1] https://datatracker.ietf.org/doc/minutes-110-secdispatch/ >> [2] https://datatracker.ietf.org/doc/draft-housley-ers-asn1-modules/ >> >> _______________________________________________ >> saag mailing list >> saag@ietf.org >> https://www.ietf.org/mailman/listinfo/saag > > _______________________________________________ > saag mailing list > saag@ietf.org > https://www.ietf.org/mailman/listinfo/saag > > _______________________________________________ > saag mailing list > saag@ietf.org > https://www.ietf.org/mailman/listinfo/saag
- [saag] AD Sponsorship of draft-housley-ers-asn1-m… Roman Danyliw
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Sean Turner
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Carl Wallace
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Russ Housley
- Re: [saag] AD Sponsorship of draft-housley-ers-as… tobias.gondrom
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Russ Housley
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Sean Turner
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Sean Turner
- Re: [saag] AD Sponsorship of draft-housley-ers-as… Roman Danyliw