IETF Logo Mail Archive

Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Addressed comments from WGLC reviewers. (#13)

Henk Birkholz <notifications@github.com> Thu, 25 July 2019 04:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E18A120074 for <sacm@ietfa.amsl.com>; Wed, 24 Jul 2019 21:12:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r0DKi9nmsr-X for <sacm@ietfa.amsl.com>; Wed, 24 Jul 2019 21:12:55 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C64F8120047 for <sacm@ietf.org>; Wed, 24 Jul 2019 21:12:54 -0700 (PDT)
Date: Wed, 24 Jul 2019 21:12:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1564027973; bh=kycswQbgE4B8cSvWtFvwaO4/uuOYDgaeDPnpQZQxKjA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cJlSUt6vOGzOv+n+SKWMhobDu0uGcJ1rA8C8gPXnyq8ZEbRarKuqyU82jvVc0tktQ 9HgAzXcxPe89ZJqD9Wwx0Yuy/7uIWEiNTY8j26/c7uDTTFmTxMG6bbl5MGABYBR7PF FgKvnDxgppQi9TXRTNW38wqaa4x6pf38o8ns/t0Q=
From: Henk Birkholz <notifications@github.com>
Reply-To: sacmwg/draft-ietf-sacm-coswid <reply+ACTMJUKLAPSI63ZSNJUG5OV3IZPMLEVBNHHBYKUYNA@reply.github.com>
To: sacmwg/draft-ietf-sacm-coswid <draft-ietf-sacm-coswid@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <sacmwg/draft-ietf-sacm-coswid/pull/13/review/266392386@github.com>
In-Reply-To: <sacmwg/draft-ietf-sacm-coswid/pull/13@github.com>
References: <sacmwg/draft-ietf-sacm-coswid/pull/13@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d392c456c2c0_7ffb3fec3c8cd9681240df"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: henkbirkholz
X-GitHub-Recipient: sacm
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: sacm@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/PaxmxVzh3bNCAdQLa98GHP9eDPU>
Subject: Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Addressed comments from WGLC reviewers. (#13)
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.29
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2019 04:12:56 -0000

henkbirkholz approved this pull request.

I agree with all of Alex's comments, which are not addressed by this current merge and have to be addressed after merging. There are some new rage definitions for values, e.g. -256 - 65536 (if I remember correctly) these can be include in the CDDL specification with controls.

Text improvement is significant and strongly accepted.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/sacmwg/draft-ietf-sacm-coswid/pull/13#pullrequestreview-266392386

v2.23.0 | Report a Bug | By Email