IETF Logo Mail Archive

[sacm] [sacmwg/draft-ietf-sacm-coswid] wrong CDDL in global-attributes group definition (#25)

Thomas Fossati <notifications@github.com> Fri, 09 October 2020 09:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 857613A0DAD for <sacm@ietfa.amsl.com>; Fri, 9 Oct 2020 02:03:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.208
X-Spam-Level:
X-Spam-Status: No, score=-3.208 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 40v7s2E5jWam for <sacm@ietfa.amsl.com>; Fri, 9 Oct 2020 02:03:47 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EF7E13A0DAA for <sacm@ietf.org>; Fri, 9 Oct 2020 02:03:46 -0700 (PDT)
Received: from github.com (hubbernetes-node-a03fbd1.va3-iad.github.net [10.48.25.56]) by smtp.github.com (Postfix) with ESMTPA id 1F88BE05A0 for <sacm@ietf.org>; Fri, 9 Oct 2020 02:03:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1602234226; bh=OVoaHaVK7QjqiievwWzjqRaxwpB0UBzLB57WZmlC7pg=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=068zR1LoSy3Kk+P3WcbUG3a4vQlUczdk+w/1xU3VUymesXSUK5K7Bk7GPW4bMsUBd xb4is2WLTpRzk5sdiokLBQNCjGS1latwNFV2voFCBIyoU17L4+NVFTL2lmxKxF+Cbz xXPFelFwEqKOhoFbq6b63AXFslMN2Ng+X+AtgWcE=
Date: Fri, 09 Oct 2020 02:03:46 -0700
From: Thomas Fossati <notifications@github.com>
Reply-To: sacmwg/draft-ietf-sacm-coswid <reply+ACTMJUK6VI66DCD377HIEJN5RQEHFEVBNHHCVS4FLI@reply.github.com>
To: sacmwg/draft-ietf-sacm-coswid <draft-ietf-sacm-coswid@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <sacmwg/draft-ietf-sacm-coswid/issues/25@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f8027721b8ec_5719b41192e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: thomas-fossati
X-GitHub-Recipient: sacm
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: sacm@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/Pivm4OdbFSEUaIiLkYJ29Qycmnw>
Subject: [sacm] [sacmwg/draft-ietf-sacm-coswid] wrong CDDL in global-attributes group definition (#25)
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.29
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Oct 2020 09:03:49 -0000

In section 2.5 `global-attributes` is defined as
```
   global-attributes = (
     ? lang,
     * any-attribute,
   )
```
Instead, it should be:
```
   global-attributes = (
     ? lang => text,
     * any-attribute,
   )
```
This kind of copy&paste error could be avoided by having one true CDDL source; an example [here](https://github.com/thomas-fossati/draft-psa-token/tree/master/cddl).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/sacmwg/draft-ietf-sacm-coswid/issues/25

v2.23.0 | Report a Bug | By Email