IETF Logo Mail Archive

Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Fixing remaining issues from IESG eval (PR #50)

David Waltermire <notifications@github.com> Thu, 12 May 2022 12:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 73FECC157B50 for <sacm@ietfa.amsl.com>; Thu, 12 May 2022 05:59:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.261
X-Spam-Level:
X-Spam-Status: No, score=-2.261 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rkHRPhAK4Tq6 for <sacm@ietfa.amsl.com>; Thu, 12 May 2022 05:59:36 -0700 (PDT)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6FAAC14F739 for <sacm@ietf.org>; Thu, 12 May 2022 05:59:36 -0700 (PDT)
Received: from github-lowworker-0a631d0.ash1-iad.github.net (github-lowworker-0a631d0.ash1-iad.github.net [10.56.22.65]) by smtp.github.com (Postfix) with ESMTP id E6AFC840AB9 for <sacm@ietf.org>; Thu, 12 May 2022 05:59:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1652360375; bh=7Q/O7pk7HDm3Sj5Q0cD38avQ7wPD1r5W4kDmrGnAOao=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hk+lzqPtZXX890SsMpBfYf9RuQ9YwdDLOC34uaRJNlJU/qMDpamVXauyWLtrkyEoj yK+//+VhP+eWJDty6+6tnrPGCIkW7ThUvHOrVktYWsnx+8p9tSrhDzgqRtNAJT2Ath +efeMNTVjfADHKhB9mVIu+eIZdyCG0wyWzzdnw/w=
Date: Thu, 12 May 2022 05:59:35 -0700
From: David Waltermire <notifications@github.com>
Reply-To: sacmwg/draft-ietf-sacm-coswid <reply+ACTMJUKBM6XOCDLO6QHQJIGARI3TPEVBNHHESZAOSA@reply.github.com>
To: sacmwg/draft-ietf-sacm-coswid <draft-ietf-sacm-coswid@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <sacmwg/draft-ietf-sacm-coswid/pull/50/review/970805750@github.com>
In-Reply-To: <sacmwg/draft-ietf-sacm-coswid/pull/50@github.com>
References: <sacmwg/draft-ietf-sacm-coswid/pull/50@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_627d04b7d925b_2e2ad4087355cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: david-waltermire-nist
X-GitHub-Recipient: sacm
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: sacm@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/QAEcgk7mXBCYN1wS8j55VvWh1r8>
Subject: Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Fixing remaining issues from IESG eval (PR #50)
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.34
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2022 12:59:37 -0000

@david-waltermire-nist commented on this pull request.



> @@ -965,7 +963,7 @@ The following describes each child item of this group.
 
 - resource-collection: The resource-collection group described in {{model-resource-collection}}.
 
-- date (index 35): The date and time the information was collected pertaining to the evidence item.
+- date (index 35): The date and time the information was collected pertaining to the evidence item in Epoch-Based Date/Time format as specified in Section 3.4.2. in {{RFC8949}}.

```suggestion
- date (index 35): The date and time the information was collected pertaining to the evidence item in Epoch-Based Date/Time format as specified in Section 3.4.2 of {{RFC8949}}.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/sacmwg/draft-ietf-sacm-coswid/pull/50#pullrequestreview-970805750
You are receiving this because you are subscribed to this thread.

Message ID: <sacmwg/draft-ietf-sacm-coswid/pull/50/review/970805750@github.com>

v2.23.0 | Report a Bug | By Email