[sacm] ECP 04 review

Chris Inacio <inacio@cert.org> Wed, 27 March 2019 01:05 UTC

Return-Path: <inacio@cert.org>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 46A861202C9; Tue, 26 Mar 2019 18:05:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DpPB8oc-ePg1; Tue, 26 Mar 2019 18:05:36 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C608A120498; Tue, 26 Mar 2019 18:05:36 -0700 (PDT)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x2R15XAO019316; Tue, 26 Mar 2019 21:05:33 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu x2R15XAO019316
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1553648733; bh=Xb7AcXQ96DJTTALQ1F5t/jBwIcJ6S2q77M5XX+Ae1sI=; h=From:To:Subject:Date:From; b=IsT6YyMKS5ORCNJHoC8gf20CfcrcUJx6jyiqZ4lcNnDl2MC9Imy8w9nqQz1rtvoec zcU5NxaLi8HNA+ylRNiWl2T6uev15rg5hAl4Oxmdx2FtmWAanUC3HIKtrg7xqcw1Nk Xd8BPd0vVmzGLdrCJTYF1b7njr4bWLfxt99jP6Uk=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x2R15WnO031921; Tue, 26 Mar 2019 21:05:32 -0400
Received: from MARCHAND.ad.sei.cmu.edu ([10.64.28.251]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0435.000; Tue, 26 Mar 2019 21:05:32 -0400
From: Chris Inacio <inacio@cert.org>
To: "draft-ietf-sacm-ecp@ietf.org" <draft-ietf-sacm-ecp@ietf.org>, "sacm@ietf.org" <sacm@ietf.org>
Thread-Topic: ECP 04 review
Thread-Index: AQHU5DksatVyMrifXUijc5CZEH0Bew==
Date: Wed, 27 Mar 2019 01:05:31 +0000
Message-ID: <etPan.5c9acc5b.24692faf.4f43@cert.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.201.21]
Content-Type: multipart/alternative; boundary="_000_etPan5c9acc5b24692faf4f43certorg_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/gzwi4baeGCLP2q37_nOQtvKgUZE>
Subject: [sacm] ECP 04 review
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 01:05:39 -0000

Sorry, I’m late with this, but here it is.

3.1:

Picture: I’m a little confused by “Administrative Interface and API” because it doesn’t connect to anything. I’m going to assume those apply across the components, but maybe some text would help there.

3.1.1.1: Please don’t start sentences with “It”.

Also, it appears that this definition creates an agent that can only operate in “polled” mode. Was that intentional?

3.2.3: So this states that posture collection is driven by the agent on the endpoint (of course it is called “Event Driven Collection”), but that seems at odds with the description in 3.1.1.1

3.2.4: Title needs to be refined, because there are multiple “Query” lines in the 3.1 diagram, and I think this only refers to the right most one. Also, this is back to polling; not event based. But doesn’t contradict 3.2.3.

You punctuate your other lists in the document (see section 3) but you don’t punctuate this one?

9.1.2 Can you reword so the text before the itemize list goes together with the list.

NITS:

3: Last paragraph “insupport” -> “in support”

3.1.6 Missing period at end of paragraph.

4.5.3.1. List without punctuation again; while most lists do.

Okay, actually you just change list punctuation later in the document.



--
Chris Inacio
inacio@cert.org