Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Editorial suggestions from Benjamin Kaduk's IESG Evaluation (PR #49)

Henk Birkholz <notifications@github.com> Thu, 26 January 2023 15:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B042C14CF0D for <sacm@ietfa.amsl.com>; Thu, 26 Jan 2023 07:37:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.772
X-Spam-Level:
X-Spam-Status: No, score=-3.772 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zGMMq5vYwooI for <sacm@ietfa.amsl.com>; Thu, 26 Jan 2023 07:37:30 -0800 (PST)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99D22C14CF0C for <sacm@ietf.org>; Thu, 26 Jan 2023 07:37:30 -0800 (PST)
Received: from github-lowworker-f5fb877.va3-iad.github.net (github-lowworker-f5fb877.va3-iad.github.net [10.48.109.70]) by smtp.github.com (Postfix) with ESMTP id E408F8405BD for <sacm@ietf.org>; Thu, 26 Jan 2023 07:37:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1674747449; bh=haEMGT2g6JEFLjxmKiz3MU9TPjy8ju1xvnvStiRTjqw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tjtx8GUDI+7SipGkQlVpfcfYzqskHYJ6HrQZCPrCB1M6prvyvU3vIHbJMUbBBfbdv n6hYan6izROmEGc7GcKJhxDYurHgeuM4NgxxYmTotq+mM+XErRCciolRDguQapndwc a1jwAZaxLlBiMzLPoZY3Ap8HH70prb7qh49XEPA4=
Date: Thu, 26 Jan 2023 07:37:29 -0800
From: Henk Birkholz <notifications@github.com>
Reply-To: sacmwg/draft-ietf-sacm-coswid <reply+ACTMJUJCQ5GOKMQTKLGAKM6B37ILTEVBNHHEHWKL2Q@reply.github.com>
To: sacmwg/draft-ietf-sacm-coswid <draft-ietf-sacm-coswid@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <sacmwg/draft-ietf-sacm-coswid/pull/49/review/1271290587@github.com>
In-Reply-To: <sacmwg/draft-ietf-sacm-coswid/pull/49@github.com>
References: <sacmwg/draft-ietf-sacm-coswid/pull/49@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_63d29e39d5a54_787bc5bc57796"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: henkbirkholz
X-GitHub-Recipient: sacm
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: sacm@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/iJo_Y28DFdicsoSNeCa623Rcif4>
Subject: Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] Editorial suggestions from Benjamin Kaduk's IESG Evaluation (PR #49)
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.39
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2023 15:37:31 -0000

@henkbirkholz commented on this pull request.



> @@ -1,6 +1,6 @@
 COSE-Sign-coswid<payload> = [
     protected: bstr .cbor protected-signed-coswid-header1,
-    unprotected: unprotected-signed-coswid-header,
+    unprotected: unprotected-sign-coswid-header,

it should be "signed" consistently. So we'll abandon this PR, but I'll push a type-names branch after this.
(this is a late reply, but we were stuck in another "branch" of the publication process)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/sacmwg/draft-ietf-sacm-coswid/pull/49#discussion_r1088010863
You are receiving this because you are subscribed to this thread.

Message ID: <sacmwg/draft-ietf-sacm-coswid/pull/49/review/1271290587@github.com>