IETF Logo Mail Archive

Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] reodering of global-attribute in text and full cddl (#37)

cabo <notifications@github.com> Thu, 18 February 2021 16:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: sacm@ietfa.amsl.com
Delivered-To: sacm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3DE513A140A for <sacm@ietfa.amsl.com>; Thu, 18 Feb 2021 08:10:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.124
X-Spam-Level:
X-Spam-Status: No, score=-7.124 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e8P64mSqtzHV for <sacm@ietfa.amsl.com>; Thu, 18 Feb 2021 08:10:37 -0800 (PST)
Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 85D483A1A60 for <sacm@ietf.org>; Thu, 18 Feb 2021 08:08:34 -0800 (PST)
Received: from github.com (hubbernetes-node-766b7fc.ac4-iad.github.net [10.52.16.37]) by smtp.github.com (Postfix) with ESMTPA id C863D5608F5 for <sacm@ietf.org>; Thu, 18 Feb 2021 08:08:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1613664513; bh=yZ+g/db/OFXB5AQfn5rMbyvMij3emqc5mM3lIGh+y6M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vzHXGUH8kgJBi0Dlrm6SEITDBVL1y2nJKSS91Nf9Ty//lf435W1oLSpXhDZHwOYre njbce8FWICPygpT2Le+c1PWtWo2iTvcGUC1/KOCDBZhBaKvBcH8j4+1hwXvDbWVNsG SsI7DzLvgH2UWrSXC4n9cdHs139J1AFtLMI8Hbz0=
Date: Thu, 18 Feb 2021 08:08:33 -0800
From: cabo <notifications@github.com>
Reply-To: sacmwg/draft-ietf-sacm-coswid <reply+ACTMJUN4FVITGWNEK3PFFGF6HJZADEVBNHHDAWS6UM@reply.github.com>
To: sacmwg/draft-ietf-sacm-coswid <draft-ietf-sacm-coswid@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <sacmwg/draft-ietf-sacm-coswid/pull/37/review/593384296@github.com>
In-Reply-To: <sacmwg/draft-ietf-sacm-coswid/pull/37@github.com>
References: <sacmwg/draft-ietf-sacm-coswid/pull/37@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_602e9101c4f78_5d1a546394f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: cabo
X-GitHub-Recipient: sacm
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: sacm@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/sacm/nVNXkuIscSqfYnJul_yMaYP_mPI>
Subject: Re: [sacm] [sacmwg/draft-ietf-sacm-coswid] reodering of global-attribute in text and full cddl (#37)
X-BeenThere: sacm@ietf.org
X-Mailman-Version: 2.1.29
List-Id: SACM WG mail list <sacm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sacm>, <mailto:sacm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sacm/>
List-Post: <mailto:sacm@ietf.org>
List-Help: <mailto:sacm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sacm>, <mailto:sacm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2021 16:10:38 -0000

@cabo commented on this pull request.



>  }
 
 evidence-entry = {
   resource-collection,
-  ? date => time,
+  ? date => #6.1(int),

I think it would be better style to add a

```
integer-time = #6.1(int)
```

and reference that here.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/sacmwg/draft-ietf-sacm-coswid/pull/37#pullrequestreview-593384296

v2.23.0 | Report a Bug | By Email