[SAM] Review of draft-samrg-sam-baseline-protocol-00

Marc Petit-Huguenin <petithug@acm.org> Sun, 06 November 2011 18:12 UTC

Return-Path: <petithug@acm.org>
X-Original-To: sam@ietfa.amsl.com
Delivered-To: sam@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1C8E521F85A7 for <sam@ietfa.amsl.com>; Sun, 6 Nov 2011 10:12:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.647
X-Spam-Level:
X-Spam-Status: No, score=-102.647 tagged_above=-999 required=5 tests=[AWL=-0.047, BAYES_00=-2.599, NO_RELAYS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UY22lyJ9cZc1 for <sam@ietfa.amsl.com>; Sun, 6 Nov 2011 10:12:01 -0800 (PST)
Received: from implementers.org (implementers.org [IPv6:2604:3400:dc1:41:216:3eff:fe5b:8240]) by ietfa.amsl.com (Postfix) with ESMTP id 7FDF921F85A8 for <sam@irtf.org>; Sun, 6 Nov 2011 10:12:01 -0800 (PST)
Received: from [IPv6:2001:470:1f05:616:213:d4ff:fe04:3e08] (shalmaneser.org [IPv6:2001:470:1f05:616:213:d4ff:fe04:3e08]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client CN "petithug", Issuer "implementers.org" (verified OK)) by implementers.org (Postfix) with ESMTPS id 3813D20138 for <sam@irtf.org>; Sun, 6 Nov 2011 18:02:54 +0000 (UTC)
Message-ID: <4EB6CDEE.6020408@acm.org>
Date: Sun, 06 Nov 2011 10:11:58 -0800
From: Marc Petit-Huguenin <petithug@acm.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15
MIME-Version: 1.0
To: sam@irtf.org
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [SAM] Review of draft-samrg-sam-baseline-protocol-00
X-BeenThere: sam@irtf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "For use by members of the Scalable Adaptive Multicast \(SAM\) RG" <sam.irtf.org>
List-Unsubscribe: <http://www.irtf.org/mailman/options/sam>, <mailto:sam-request@irtf.org?subject=unsubscribe>
List-Archive: <http://www.irtf.org/mail-archive/web/sam>
List-Post: <mailto:sam@irtf.org>
List-Help: <mailto:sam-request@irtf.org?subject=help>
List-Subscribe: <http://www.irtf.org/mailman/listinfo/sam>, <mailto:sam-request@irtf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2011 18:12:02 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sorry for the delay in reviewing this.  I waited to base the review on an
implementation, but unfortunately I never got the time to do so.  So this is
only a partial review.


1. Title

I do not know if the rules are different for the IRTF, but shouldn't this draft
been called draft-irtf-samrg-sam-baseline-protocol instead?


2. Section 7.2.1 "...peer id closest to and less than the GroupId"

This idea of a Node-ID been close to another ID is specific to certain types of
overlays (like the CHORD-RELOAD default), but will probably do not make sense
for other types.  The text either need to be modified to work with any type of
overlay, or to explicitly say that this draft is only for RELOAD overlays in
which this make sense.


3. Section 7.2.1 structure definition

The Dictionary type is not defined in this spec.

Also I would suggest to follow the standard convention of using lowercase for
the character of a field.


4. Section 7.2.[2-5]

RELOAD message are client/server based.  A request is sent and retransmitted
until a matching response is received.  I am sure how the
Join/JoinAccept/JoinConfirm/JoinDecline mechanism is working inside this framework.


5. Section 10.1. Data Model section

The Data Model is probably SINGLE here.


6. Section 10.1. Access Control section

The Access Control policy NODE-MATCH assumes that the Resource Name is the
Node-ID of signer of the ALMtree entry.  If you want to use the SessionKey as
Resource Name, you probably need to define a new Access Control policy.


Nits
- ----

- - Section 5

s/Register Kind-ID points/Register Kind-ID codepoints/

- - Section 7.3.3

s/diffent/different/

- - Section 7.2.6

s/idenfied/identified/

- - Section 8.2

s/rendevous/rendezvous/

- - Section 8.5

s/conirm/confirm/

- -- 
Marc Petit-Huguenin
Personal email: marc@petit-huguenin.org
Professional email: petithug@acm.org
Blog: http://blog.marc.petit-huguenin.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk62ze0ACgkQ9RoMZyVa61cC4ACdGKlVx8bm1sQr017foMaDhyze
Eg4AnR557TEUHu6CTi1qcyrRGnACiuHO
=cqrN
-----END PGP SIGNATURE-----