[secdir] Re: Secdir last call review of draft-ietf-opsawg-ipfix-tcpo-v6eh-11

Tero Kivinen <kivinen@iki.fi> Tue, 14 May 2024 14:31 UTC

Return-Path: <kivinen@iki.fi>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B250EC14F69F; Tue, 14 May 2024 07:31:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.741
X-Spam-Level:
X-Spam-Status: No, score=-4.741 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.944, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=iki.fi
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yn0AqcdBoS0I; Tue, 14 May 2024 07:31:14 -0700 (PDT)
Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A7E0C14F5EC; Tue, 14 May 2024 07:31:11 -0700 (PDT)
Received: from fireball.acr.fi (fireball.acr.fi [83.145.195.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kivinen@iki.fi) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4VdzLP1Y0yz49PvR; Tue, 14 May 2024 17:31:08 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1715697069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHlxP6jAqHzzXulImTqaw0E92vQZGcBWFCaz33G2hf0=; b=YCmoh/V6g2Vpmb+1R9u5Z4WmCwYhaU1U+P8AwBPv+Hau6VD6T99pLCdc284JeGxejGrkzH wfHsMnRCDrL/Ucu5DyrtBnM41kw2FWMMkIen8eVQDyY3ecpRDd/KsxabxrcArdhhLeHfsX NxCQvvhujw4oSseb9nM95e+nAa2xwR9AndfgJEIxVQC9WzJwoHQyWwSmrsONmPfzoqN9zN a1EOQl2bH8cgyR7XZEFkWFk1kCGiL3MycUvAd19lSZhp96+ksudS+4j0SYTzulBUK7AzDy 4OEp5zQ3iJg0cxH46PNKQI3cl/KdSc5Mv8cVy8POMsO1zfBFtT67Q7A0EpnFzg==
ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1715697069; a=rsa-sha256; cv=none; b=SiNfF+uSQRf/O2iD3yxNn8bVt52QJfVwBD0RNylNeR7PPYBI5YSGUWTiZwpXoR0o287BKB eZIV7SkGavqhXjZShVg9pWDMLAzHnjuX8YKIqPjcta73k+M1kgKKetHFXdeBWT/9O3LsW8 cqAQOnn/1EBvnSO0U4BXi86RQzEobpib7zih33SEbFVNxlGmH1GapX8Neat5f/HhrjRjmy e7kvmJJr4Q1gtyeRWsNALTOobaxFrFRRhi7rfJghxPMT4WA0iAzNu+teHmgr55yV/s1Z5R YLGoz4Qod+xBzj7Y31OFwTJF/vbvwmHZVmbbgXfY9LchYwNoK6F7nqiY19suPA==
ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=kivinen@iki.fi smtp.mailfrom=kivinen@iki.fi
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1715697069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHlxP6jAqHzzXulImTqaw0E92vQZGcBWFCaz33G2hf0=; b=Bowp5H4dyhIiGowlxr7B2EwhMuUm+HWag+ZMNbm7PA9Uu+Co3CD3dBN++ntRPqNMWg3g8z c1jy0LGaWbuBgS3B2lIF1mUxL6NR7wFXuMRJ5LfV7kJAL71/mqpgtL2w0exqVGZSaqQ4rd FD9BayuC42FdI5RrmV75qPWYkL+51l4Y/Z483ZFirpTr8RvpK64HTobx28jaZUchVThq1l LRU38IBiBT8oGE93nnU4JuIcKtjy3mjkIj+fH3lFJ9MUMI65dIvKjLNAMOaP/A08UovZvG nvHf3suODA17e+Vyvw+7IILLJIlamOp3kVppStjKeU3+ieORbjyik+HE1SS/hg==
Received: by fireball.acr.fi (Postfix, from userid 15204) id B304125C0E35; Tue, 14 May 2024 17:31:08 +0300 (EEST)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-ID: <26179.30124.656180.463251@fireball.acr.fi>
Date: Tue, 14 May 2024 17:31:08 +0300
From: Tero Kivinen <kivinen@iki.fi>
To: mohamed.boucadair@orange.com
In-Reply-To: <DU2PR02MB101607CD2621FF2E93D18AF6688E22@DU2PR02MB10160.eurprd02.prod.outlook.com>
References: <171526890711.64710.8472349123140714328@ietfa.amsl.com> <DU2PR02MB101607CD2621FF2E93D18AF6688E22@DU2PR02MB10160.eurprd02.prod.outlook.com>
X-Mailer: VM 8.2.0b under 26.3 (x86_64--netbsd)
X-Edit-Time: 7 min
X-Total-Time: 7 min
Message-ID-Hash: NXR2UD5O2Z4FFGCLUN55G3FDAVXOLI4K
X-Message-ID-Hash: NXR2UD5O2Z4FFGCLUN55G3FDAVXOLI4K
X-MailFrom: kivinen@iki.fi
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-opsawg-ipfix-tcpo-v6eh.all@ietf.org" <draft-ietf-opsawg-ipfix-tcpo-v6eh.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [secdir] Re: Secdir last call review of draft-ietf-opsawg-ipfix-tcpo-v6eh-11
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/0wfUeoAoS--JxHk2FA0uPzqOYhk>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

mohamed.boucadair@orange.com writes:
> > In section 8.3 change
> > 
> > 					This type MUST be encoded per
> >    Section 6.1.1 of [RFC7011].  Reduced-Size encoding (Section
> > 6.2 of
> >    [RFC7011]) applies to this data type.
> > 
> > to
> > 
> > 					This type MUST be encoded per
> >    Section 6.1.1 of IPFIX specification [RFC7011]. Reduced-Size
> >    encoding (Section 6.2 of IPFIX specification [RFC7011])
> > applies to
> >    this data type.
> > 
> > --
> 
> [Med] This is a matter of editing taste. I'm not fun of expanding
> the ref title.

I think it is important for lowering the bar to getting people
involved in the IETF protocols. If you need to learn mapping of
tens or hundreds of rfc numbers to the actual titles, before you can
easily read documents it makes it much harder to read the document,
and causes extra work for the reader.

Expanding it by the author once, will save that mapping to be done by
people who read it. There are RFCs where there is less readers than
writers, but I hope that is exception not a norm.

When I was reviewing that draft, I had to google the RFC numbers
multiple times (even the same ones) just to make sure which one is
which.

Also it is bad form of using reference as a noun. It makes [1] to [2]
text when some of the [3] is not near the part using it.

[1] https://dictionary.cambridge.org/dictionary/english/difficult
[2] https://dictionary.cambridge.org/dictionary/english/read
[3] https://dictionary.cambridge.org/dictionary/english/text

> > Section 9.1 [IANA-EH] url is wrong, it points to the "Next Header
> > Types" registry, not to the "IPv6 Extension Header Types"
> > registry.
> 
> [Med] This is on purpose because the RFC Editor does not cite the specific URLs, only the URL of the registry group.
> 
> > Correct url is
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2
> > Fwww.iana.org%2Fassignments%2Fipv6-parameters%2Fipv6-
> > parameters.xhtml%23extension-
> > header&data=05%7C02%7Cmohamed.boucadair%40orange.com%7Ce04d445565
> > be47dc729308dc703d9ca0%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0
> > %7C638508657119400747%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
> > iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdat
> > a=sAElkvoUqJFN0K5eFgX%2F73LEbbqAWqerHq0IDzQsy%2Bo%3D&reserved=0

The link I provided pointed directly to the registry you referenced
to. If yo go to the registry itself the beginning of it has table of
contents, which provides links to exact registries.
-- 
kivinen@iki.fi