Re: [secdir] review of draft-ietf-netconf-nmda-restconf-04

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 26 July 2018 22:08 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2F54131242; Thu, 26 Jul 2018 15:08:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3nXMeIRLpQ7M; Thu, 26 Jul 2018 15:08:15 -0700 (PDT)
Received: from mail-pl0-x234.google.com (mail-pl0-x234.google.com [IPv6:2607:f8b0:400e:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C03FC13123B; Thu, 26 Jul 2018 15:08:15 -0700 (PDT)
Received: by mail-pl0-x234.google.com with SMTP id b1-v6so1400608pls.5; Thu, 26 Jul 2018 15:08:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=B+H7z1iJKOJrNej/Wb2wJFy4U2kFLz8gzkGje0mncz8=; b=sIyvsFS909ocffPDil4hiqnWzRArfmSEmpK5dPTF7ReeXpenxfL+0j5Hu1aiBJrkid U9syvR3RDYdX7OgTQgr+GRQtq7IRGj065lI3c/riUMrDlX1xQKdve788VNPEhLvbr9rN YzoNMWa53z9zIrfzGsd3rzP74n9+Juv4vAf++Q2PGkn7mSfEK4BnUASYhXWFFpAmTRdM yESPSaNbd+bwVDlR19cOTK8OtRwQnFbeww4qBVbk60eVvsOINVASxzDR7DAdKMm5kruP eeiQcQy/M0SoPrMosbC9H9P/E33ZLA45IG4PI5OMqzsY6diSZURG9T2jeUeN/8xAUizr 6xzg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=B+H7z1iJKOJrNej/Wb2wJFy4U2kFLz8gzkGje0mncz8=; b=jARc5mSTkmFBRlv/mCsCI0O8VPQj2jfGppSnh4dd7M8CCxC5VST8pnId/52WoYAT6e vHXLShxv23JiYIAEUOAsaWc5tR/HStVka2+fM0r6NRBRQ3ereAQGjKk+AUiMy700+2Qh 6rgUcOyB6Af4o2wpy714IZPPEsCs3yQdE6mHO9vDEvUZUyN1a+3/uz8gppFhTohyENUM d3OznHBDIupN1FBpFTQyEOx7jUhYjYhn7SScn8vEvAjbgG76D7/z1a+4p47SOIZBhIdy nJXMKr8sFVyknjIA4kAyaHJ7pE1CNFCMI/b6Bne4Dw3tbOZGnaJI3ZGY/ZfqpxMJyYr7 d/fQ==
X-Gm-Message-State: AOUpUlH3J9KEhWk5P8OS89UV3b0Ihm7cLJqeHFl19nlGjRIKr5zSZFL6 S9sDf+L17MLIZSITz+1feyc41QZK
X-Google-Smtp-Source: AAOMgpdGpoKIHCLYT9VFDEw7NuxHqiB+KBEbjcgL6yqTVTdeSmoDaoIuDJ0KdmUNGMeRdUTFkO9GAw==
X-Received: by 2002:a17:902:c6b:: with SMTP id 98-v6mr3478928pls.233.1532642895312; Thu, 26 Jul 2018 15:08:15 -0700 (PDT)
Received: from ?IPv6:2601:647:4700:1280:c591:d2f4:a72b:c1de? ([2601:647:4700:1280:c591:d2f4:a72b:c1de]) by smtp.gmail.com with ESMTPSA id r22-v6sm4234534pfl.112.2018.07.26.15.08.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 15:08:14 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <C805D3F9-33B2-4D4F-96A8-86184E647DA7@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_E65F9D6C-2A65-4AA4-83AC-83CF4BD3C7CF"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 26 Jul 2018 15:08:11 -0700
In-Reply-To: <20180716104225.hlg3r3x62q4ipq2x@anna.jacobs.jacobs-university.de>
Cc: Daniel Harkins <dharkins@lounge.org>, Kent Watsen <kwatsen@juniper.net>, The IESG <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-netconf-nmda-restconf.all@ietf.org" <draft-ietf-netconf-nmda-restconf.all@ietf.org>, Russ Housley <housley@vigilsec.com>
To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
References: <f919a44f-d93b-f399-cc5d-1353c1c5b57d@lounge.org> <20180704124128.qpr7tunjw5quiex6@anna.jacobs.jacobs-university.de> <9b2f8091-9ead-e188-ee34-1acfead2dcd2@lounge.org> <20180704183436.zjzwz4vowqi5phz7@anna.jacobs.jacobs-university.de> <14e7ae2d-90ae-32c5-c814-a2d31e9f1a4e@lounge.org> <DB8ED828-D18F-4AEF-A7AB-884D085ECDA7@juniper.net> <8dbe0263-de63-0ddd-86db-04fa7744155c@lounge.org> <99EB8497-BCC0-45A3-A412-6FC5036243F6@gmail.com> <20180716104225.hlg3r3x62q4ipq2x@anna.jacobs.jacobs-university.de>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/0xhhQAnUATrAncb4HWCJBNmBgDk>
Subject: Re: [secdir] review of draft-ietf-netconf-nmda-restconf-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 22:08:19 -0000

[Adding Russ Housley]

> On Jul 16, 2018, at 3:42 AM, Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>; wrote:
> 
> On Mon, Jul 09, 2018 at 05:48:53PM -0700, Mahesh Jethanandani wrote:
>> There have been a few comments that have been made to the version of the draft that has been submitted to IESG. While we wait for other comments to be provided, and direction of when an update should be provided, who amongst the authors is updating GitHub with these changes? 
>> 
>> I am concerned we might lose track of the changes that need to be made.
>> 
>> Here are the changes that I am aware of for nmda-restconf. I can compile a similar list for nmda-netconf if needed.
> 
> Having a list of outstanding edits for nmda-netconf would be nice as well
> so we can make the edits on github.

Let me compile a list of edits that are applicable for nmda-netconf.

> 
>> Kent’s comment on nmda-restconf operations (thread <https://www.ietf.org/mail-archive/web/netconf/current/msg14998.html> from today).
> 
> Given that lock and unlock require session semantics, I think the
> resolution should be to add.
> 
>   A RESTCONF server supporting NMDA datastores MAY implement the
>   "ietf-netconf-nmda" [I-D. ietf-netconf-nmda-netconf] module to
>   enable the NETCONF operations defined in this draft to appear
>   under the {+restconf}/operations resource.
> 
> But then, what is the value of this? You do not need get-data and
> edit-data with RESTCONF since you can send GET/POST/PATCH straight to
> the datastore resources. I guess I am still unclear which problem we
> are trying to solve by adding this (or a similar) statement.

I am responding to the last sentence that was made on that thread, where Kent asked the question.

> So, adding something like this to nmda-restconf would be good?

It likely does not hurt to be clear that this option of using NETCONF
operations in RESTCONF exists.
/js
If you and the authors now believe that the clarification is not needed, then please state so.

> 
>> Dan’s comment on this thread (also from today, but is not on netconf mailing list)
> 
> Not sure which one you mean.

I mean all the the OLD and NEW suggestions from Kent. Basically replace “optional to support” with RFC 2119 use of MAY.

> 
>> Russ’s Genart review (thread <https://www.ietf.org/mail-archive/web/netconf/current/msg14834.html> from June 28)
> 
> Not sure what the resolution is, removing the example text or trying
> to better explain that this is example text.

I believe either of the options would be ok with Russ. I have added him to confirm.

> 
>> Rohit’s change-2 comments provided for nmda-netconf, that are applicable for nmda-restconf (thread <https://www.ietf.org/mail-archive/web/netconf/current/msg14607.html> from June 1)
> 
> The inclusion of an example showing the usage of
> negated-origin-filter? This was an nmda netconf command. We do not
> seem to have an origin filter in nmda restconf, this is an nmda
> netconf only feature?

Again, I am responding to the last comment that Robert made on the follow up e-mail where he proposed changes for NETCONF and said:

Similar updates will need to also be done to RESTCONF, but let's agree the NETCONF text first.

Maybe he can clarify what he had in mind for RESTCONF.

Cheers.

> 
>> Anything else that I missing?
> 
> Not that I recall.
> 
> /js
> 
> -- 
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>

Mahesh Jethanandani
mjethanandani@gmail.com