Re: [secdir] SECDIR Review of draft-pd-dispatch-msrp-websocket-12

"Gonzalo Salgueiro (gsalguei)" <gsalguei@cisco.com> Wed, 20 July 2016 16:17 UTC

Return-Path: <gsalguei@cisco.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4643D12D745; Wed, 20 Jul 2016 09:17:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.808
X-Spam-Level:
X-Spam-Status: No, score=-15.808 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4r_eW1ZngJ0N; Wed, 20 Jul 2016 09:17:44 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6BB8212D4FB; Wed, 20 Jul 2016 09:17:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1545; q=dns/txt; s=iport; t=1469031464; x=1470241064; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=k23SDWqEMcyrCzQSNvJLape+tDbwE9imyuRDlVq2udU=; b=ZXhhvCGOgnfjKg3CmZifm7yKX8X1Qg4s/XsrtV0OKwl7vzSoSjrupC8Y Cj07nvT8QvL6FLWq3nWwPNzDuZ9qm58G+fDUq578D3g7nmypcrAl+Fu83 AHpOa9MyyMSvh8pn36rt+FeuBAe2ZpbQxJK5XIyxsGQLQ9KntYqKn+htF Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AfAgDWo49X/5RdJa1aA4M/gVIGrDuKD?= =?us-ascii?q?IIPgXqGGgKBMzgUAQEBAQEBAWUnhFwBAQQBOj8FCwIBCA4KHhAhESUCBA4FiBY?= =?us-ascii?q?DDwi5LQ2ECAEBAQEBAQEBAQEBAQEBAQEBAQEBARyGKoF4glWCQ4F9ISaCZYIvB?= =?us-ascii?q?ZhyNAGMQ4IejzmIJYd6AR42g3Nuhih/AQEB?=
X-IronPort-AV: E=Sophos;i="5.28,395,1464652800"; d="scan'208";a="298333080"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jul 2016 16:17:43 +0000
Received: from XCH-RCD-008.cisco.com (xch-rcd-008.cisco.com [173.37.102.18]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id u6KGHhnE003661 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 20 Jul 2016 16:17:43 GMT
Received: from xch-aln-009.cisco.com (173.36.7.19) by XCH-RCD-008.cisco.com (173.37.102.18) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 20 Jul 2016 11:17:42 -0500
Received: from xch-aln-009.cisco.com ([173.36.7.19]) by XCH-ALN-009.cisco.com ([173.36.7.19]) with mapi id 15.00.1210.000; Wed, 20 Jul 2016 11:17:42 -0500
From: "Gonzalo Salgueiro (gsalguei)" <gsalguei@cisco.com>
To: Donald Eastlake <d3e3e3@gmail.com>
Thread-Topic: SECDIR Review of draft-pd-dispatch-msrp-websocket-12
Thread-Index: AQHR1mwKOKLbBiieG02Ud0rnTNWPgqAh63SA
Date: Wed, 20 Jul 2016 16:17:42 +0000
Message-ID: <04408A34-8FBA-4E60-8D8D-6B4501714E9A@cisco.com>
References: <CAF4+nEGxcon=cSo9sZeTep+2Xu4+s06kziNNsfy60C0Xds2G5w@mail.gmail.com>
In-Reply-To: <CAF4+nEGxcon=cSo9sZeTep+2Xu4+s06kziNNsfy60C0Xds2G5w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.171.33]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15243651D9AE6944A7F9DACD754FE140@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/2oc1SEdDIVBJ_ZOQQGNGJHXcUdw>
Cc: "iesg@ietf.org" <iesg@ietf.org>, "draft-pd-dispatch-msrp-websocket.all@ietf.org" <draft-pd-dispatch-msrp-websocket.all@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [secdir] SECDIR Review of draft-pd-dispatch-msrp-websocket-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jul 2016 16:17:46 -0000

Hi Donald - 

Thanks for the review. Inline...

> On Jul 5, 2016, at 5:18 AM, Donald Eastlake <d3e3e3@gmail.com> wrote:
> 
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  Document editors and WG chairs should treat these comments just
> like any other last call comments.
> 
> This draft specifies a new WebSocket sub-protocol as a reliable
> transport mechanism between MSRP (Message Session Relay Protocol)
> clients and relays. It depends on the use of secure WebSocket
> connections (TLS) and existing authentication mechanisms. I am not
> particularly familiar with WebSockets or MSRP but the Security
> Considerations section looks adequate to me.
> 
> There are a lot of example message flows in this document that i don't
> really know enough to evaluate.
> 
> Nits:
> 
> It is peculiar that Sections 10, Section 11, and Appendix A have only
> a single subsection aa their entire content. In the case of Sections
> 10 and 11, I think the 10.1 and 11.1 headers should just be
> eliminated. In the case of Appendix A, probably the A.1 heading should
> be moved up to the A level.

Agreed.  We have made all your suggested changes.

Thanks,

Gonzalo

> 
> Thanks,
> Donald
> ===============================
> Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
> 155 Beaver Street, Milford, MA 01757 USA
> d3e3e3@gmail.com