Re: [secdir] Secdir review of draft-ietf-jose-json-web-signature-31

Mike Jones <Michael.Jones@microsoft.com> Sat, 06 September 2014 00:57 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E5331A06E1; Fri, 5 Sep 2014 17:57:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjehyfZrMp5D; Fri, 5 Sep 2014 17:57:27 -0700 (PDT)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0756.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::1:756]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 485091A0709; Fri, 5 Sep 2014 17:57:13 -0700 (PDT)
Received: from BN3PR0301CA0072.namprd03.prod.outlook.com (25.160.152.168) by BN1PR03MB252.namprd03.prod.outlook.com (10.255.200.24) with Microsoft SMTP Server (TLS) id 15.0.1019.16; Sat, 6 Sep 2014 00:56:49 +0000
Received: from BN1AFFO11FD008.protection.gbl (2a01:111:f400:7c10::183) by BN3PR0301CA0072.outlook.office365.com (2a01:111:e400:401e::40) with Microsoft SMTP Server (TLS) id 15.0.1019.16 via Frontend Transport; Sat, 6 Sep 2014 00:56:50 +0000
Received: from mail.microsoft.com (131.107.125.37) by BN1AFFO11FD008.mail.protection.outlook.com (10.58.52.68) with Microsoft SMTP Server (TLS) id 15.0.1010.11 via Frontend Transport; Sat, 6 Sep 2014 00:56:49 +0000
Received: from TK5EX14MBXC292.redmond.corp.microsoft.com ([169.254.1.60]) by TK5EX14HUBC102.redmond.corp.microsoft.com ([157.54.7.154]) with mapi id 14.03.0195.002; Sat, 6 Sep 2014 00:56:14 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Tero Kivinen <kivinen@iki.fi>, "iesg@ietf.org" <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-jose-json-web-signature.all@tools.ietf.org" <draft-ietf-jose-json-web-signature.all@tools.ietf.org>
Thread-Topic: Secdir review of draft-ietf-jose-json-web-signature-31
Thread-Index: AQHPyDgrWdMUgOdf8EqNa4N9Ytbe4ZvzQwog
Date: Sat, 6 Sep 2014 00:56:14 +0000
Message-ID: <4E1F6AAD24975D4BA5B16804296739439AE9DD47@TK5EX14MBXC292.redmond.corp.microsoft.com>
References: <21512.21725.209461.976375@fireball.kivinen.iki.fi>
In-Reply-To: <21512.21725.209461.976375@fireball.kivinen.iki.fi>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [157.54.51.70]
Content-Type: multipart/alternative; boundary="_000_4E1F6AAD24975D4BA5B16804296739439AE9DD47TK5EX14MBXC292r_"
MIME-Version: 1.0
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:131.107.125.37; CTRY:US; IPV:CAL; IPV:NLI; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019017)(438002)(199003)(377454003)(51914003)(189002)(13464003)(43784003)(16297215004)(19580395003)(44976005)(15975445006)(84326002)(77096002)(21056001)(68736004)(99396002)(15202345003)(6806004)(92726001)(50986999)(2201001)(85852003)(77982001)(2656002)(86362001)(87936001)(97736003)(92566001)(104016003)(55846006)(83072002)(19617315012)(90102001)(76482001)(84676001)(4396001)(83322001)(19580405001)(19300405004)(85806002)(81342001)(512954002)(71186001)(31966008)(2501002)(74502001)(74662001)(79102001)(16236675004)(81156004)(76176999)(54356999)(106466001)(64706001)(86612001)(46102001)(26826002)(19625215002)(106116001)(66066001)(69596002)(95666004)(81542001)(85306004)(107046002)(80022001)(33656002)(230783001)(20776003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR03MB252; H:mail.microsoft.com; FPR:; MLV:ovrnspm; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:;
X-O365ENT-EOP-Header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY)
X-Forefront-PRVS: 03264AEA72
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 131.107.125.37 as permitted sender) receiver=protection.outlook.com; client-ip=131.107.125.37; helo=mail.microsoft.com;
Authentication-Results: spf=pass (sender IP is 131.107.125.37) smtp.mailfrom=Michael.Jones@microsoft.com;
X-OriginatorOrg: microsoft.onmicrosoft.com
Archived-At: http://mailarchive.ietf.org/arch/msg/secdir/36Zz_kwQkRyrUC4ilj7Q5xFDquE
Cc: "jose@ietf.org" <jose@ietf.org>
Subject: Re: [secdir] Secdir review of draft-ietf-jose-json-web-signature-31
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Sep 2014 00:57:34 -0000

Thanks for the useful review, Tero.  I've cc'ed the working group to make them aware of the contents of your review.  Also, Richard Barnes, please see a request for a reply from you on one issue below.  Replies are inline below...



-----Original Message-----
From: Tero Kivinen [mailto:kivinen@iki.fi]
Sent: Thursday, September 04, 2014 5:03 AM
To: iesg@ietf.org; secdir@ietf.org; ietf@ietf.org; draft-ietf-jose-json-web-signature.all@tools.ietf.org
Subject: Secdir review of draft-ietf-jose-json-web-signature-31



I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.



Summary: This document has issues.



This document is part of the jose-json document set, and describres the JSON Web Signatures.



The security considerations section includes text which says:



   The entire list of security considerations is beyond the scope of

   this document, but some significant considerations are listed here.





but also lists quite a lot of security considerations. I think the security considerations covering this document should be in scope with the document. Of course there are generic security considerations which might be outside the scope of this document, but I do not think we need to explictly mention those.



Several reviewers have objected to this sentence.  Its removal is planned.



Also, additional security considerations will be described in the process of resolving Russ Housley's gen-art review comments.



I have following issues about the draft:



   1) "alg" and Protected Header



   2) Hash inside "alg" and inside the signature



   3) There is no explict warning about the "alg" "none".



   4) Thumbprint formats



There is also following nit:



   5) Terminology ordering.



----------------------------------------------------------------------



1) "alg" and Protected Header



Question: Shouldn't the "alg" header parameter be protected by the signature, i.e. wouldn't it make sense to say MUST be in the "Protected Header"?



If it is part of the "Unprotected Header" and is not protected by the signature, that would allow all kind of attacks, i.e. changing the "alg" to be "none" or changing the hash algorithm of the signature.



If it should be part of the "Protected Header" then that would mean that "Proteced Header" cannot be empty, as "alg" is mandatory header parameter, and MUST be present.



There are several cases where the text indicates that "Protected Header" could be empty, which would mean that "alg" could be part of the "Unprotected Header". (Section 5.1, 4. bullet; section 7.2, "protected" element and other places in same section). In all examples the "alg" is always in the "Proteced Header".



I think the draft needs text saying something about the situation where "alg" is not in "Protected Header" in the security sections section. I.e. either say, that it has been analyzed that there is no problem even when the "alg" is not protected, and reference to such analysis, or otherwise add text/warning that it MUST/SHOULD be in the "Protected Header". I do not know enough about the proposed signature algorithms to know which one is true, especially as there might be new algorithms in the future.



Richard Barnes, do you want to answer this one?  You were the primary advocate for allowing the algorithm to be unprotected in the JSON Serialization.



As I recall, the motivation had to do with the fact that, by default, CMS does not protect the algorithm (although it was later extended to enable it to be protected).  Some others in the working group thought that having unprotected algorithms was a bad idea, in line with your comment above.



--



2) Hash inside "alg" and inside the signature



Also in some cases the signature itself has the hash function stored internally, i.e. RSASSA-PKCS1-V1_5 contains the hash function oid inside the signature, so what should the implementation do if the "alg" parameter outside the signature does not match the oid inside the signature? I.e the signature using "alg" of "RS256", but inside the signature the oid is using the "SHA1". Most crypto libraries will just take the oid from the signature, and use that to verify the message. Adding some description what to do in such situation would be needed.



I think there's some confusion here, since the JWS spec does not use any OIDs or ASN.1 for signatures.  Rather, the cryptographic operations to be performed are fully specified by the "alg" value and the signatures are represented as base64url encoded octet sequences representing the signature values produced by the signature algorithms.



--



3) There is no explict warning about the "alg" "none".



In the section 5.2 it says that "at least one signature ... MUST successfully validate", but that does not limit alg "none" out from it. I.e. if the application policy is to "one signature needs to validate", and it gets JWS that has "none" as one of the algorithms, then it will accept it.



I think there should be warning here or in the security considerations section about the "none" algorithm, especially as the algorithm itself is defined in the different draft (perhaps just reference to the section 8.5 of the [JWA] draft).



This warning is present in the spec where the algorithm is defined - specifically http://tools.ietf.org/html/draft-ietf-jose-json-web-algorithms-31#section-8.5.  (Note that the working group decided to define algorithms in a separate spec than the ones in which they are used.)



Also note that it is up to applications which algorithms are acceptable in a given context - not just "none" but also other algorithms that might be deprecated or inappropriate for some other reason.  Unless the signature algorithm used is acceptable to the application, it should not accept the JWT.



--



4) Thumbprint formats



Section 4.1.7 and 4.1.8 defines a x5t and x5t#S256 thumbprints, but those are over the whole certificate.



With the thumbprints, it has been noted lately, that quite often it is more useful to use the hash of the SubjectPublicKeyInfo object of the

X.509 certificate, than the full X.509 certificate. This method has been used in the raw public key methods (draft-ietf-tls-oob-pubkey, draft-kivinen-ipsecme-oob-pubkey), and also in the DANE (it has two options one for the full certificate and another for the SubjectPublicKeyInfo object of the certificate).



Using hash of the SubjectPublicKeyInfo object allows changing the certificate without invalidiating the certificates, i.e. when changing CAs, or switching from SHA1 to SHA2 in certificates, or just renewing the certificate. It also allows using raw public keys which do not have defined X.509 certificate format, but which can be converted to the SubjectPublicKeyInfo object when calculating the thumbprints. This is very important in the Internet of Things type of things, which might not be using the full X.509 certificates.



This thumbprint definition matches existing practice in commonly used software packages.  For instance, both openssl and Windows use certificate thumbprints of this kind.



That being said, there's nothing preventing another specification from defining a different thumbprint calculation over the SPKI information and a header parameter used to represent it.  The header parameters are extensible via a registry.



--



5) Terminology ordering.



Terminology is not in any order. It would be useful to have it either in logical order (i.e. define terms before they are used), or in alphabetical order.



Now for example the "JWS Protected Header" is used before it is defined in the "JWS Signature", and "Header Paramater" is between "JWS Signature" and "JWS Protected Header", also "JWS Signature" uses both "JWS Payload" and "JWS Protected Header", and one of those is defined before and one after the "JWS Signature".



The terms are listed in top-down order, with related terms grouped together.  Thus "JSON Web Signature" is first, the members that make up a JWS object are listed together in the order that they appear in a JWS, etc.  That being said, I'll plan to review the orderings and make sure that they consistently follow those ordering rules.



--

kivinen@iki.fi<mailto:kivinen@iki.fi>



                                                                Thanks again,

                                                                -- Mike