Re: [secdir] Secdir review of draft-ietf-trill-multilevel-unique-nickname-05

Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Wed, 07 March 2018 03:19 UTC

Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ADCED126CC7; Tue, 6 Mar 2018 19:19:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RvQS1Hi1N_Bf; Tue, 6 Mar 2018 19:19:55 -0800 (PST)
Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0C9B9124BE8; Tue, 6 Mar 2018 19:19:55 -0800 (PST)
Received: by mail-oi0-x22d.google.com with SMTP id c83so638181oib.1; Tue, 06 Mar 2018 19:19:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rgnyq2ePgCAnY7uWAFUBPKp1tFY6IQaS8nvjXj9Brfg=; b=UU/EskVSolob9e8vHxM94WwqYbXq24DmHsyKQ9hf9tqysuuciOzVRbAVlDWVf78V7M RDv4c9/DkMkaGnpcc88pR0twCq1feMeGi20vxz8I7ZjetIBR9vDBY1sCHAJ1kPDNJI1D ig/6mzEe9nlGoCss1bPy3RfflL0EakwqbkFieadDN6N4psqKZswDfofYO/q2NyhYV0pP fUlmJoMITKg60fyKnMZavpm5AoIGNrAgZvC06Ky11oSoe+tJr7RJxCybTuIwR1Qmgu9Z TIF4ElpQvhHJvxoJOKzt0yEN+S2FJqFLx8Y9eH1BVQ/WF8Dm7drSOKHab5457E1Fg/6U U/Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rgnyq2ePgCAnY7uWAFUBPKp1tFY6IQaS8nvjXj9Brfg=; b=RudrHvnXZ+ggpb3t4satfJUQig5f4O7kYxGx3rkzlfNSI4/A8XN9eg6uaWu2XoFkAC 6bSwmPlXjjC0GNNvvFVywfrAGyQXiiQZDM+i4o58o2lpvvtHEhjodhS/gESlDEZA/EbP ies9v/LAC+Rjt37TDU1XabXNh5ecblpw5pEYjkkxhXpiARBng9MOX8RmS7gFuYII941K hsZ9dKaOv6cksvm/kIlLwXzbJSGIVQpaMzfhn/rrKp8O1vC9tjolrZubX4d8+4wzolgr BvS32x/HLuB9iTBEy/2uxXWHsc8Rquf90JX99XAcsZXcI6hLhApXk7ok90jnn8zjEhl6 RcXQ==
X-Gm-Message-State: AElRT7FE0C19bgi1CHY5sFdMEe/r3vA7ecaYm7qsd//j0PnJ/PdEP44B LE+AUPzAc9FtxgiImnW6TzMMgFflXHNtGa/jZCw=
X-Google-Smtp-Source: AG47ELtAlKqhRcypBY2tQY1z1kUDoRBemyLhZ3ukuYjsUxyJKqwvyI7QlM3CYaxthbHSYHp/dGXIaaRZFyHMDr9fK84=
X-Received: by 10.202.64.131 with SMTP id n125mr14043514oia.26.1520392794423; Tue, 06 Mar 2018 19:19:54 -0800 (PST)
MIME-Version: 1.0
Received: by 10.157.46.119 with HTTP; Tue, 6 Mar 2018 19:19:14 -0800 (PST)
In-Reply-To: <4552F0907735844E9204A62BBDD325E7AAFE7004@NKGEML515-MBX.china.huawei.com>
References: <359EC4B99E040048A7131E0F4E113AFC0137F6E1D1@marathon> <359EC4B99E040048A7131E0F4E113AFC0137F70C6B@marathon> <4552F0907735844E9204A62BBDD325E7AAFE7004@NKGEML515-MBX.china.huawei.com>
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Date: Tue, 6 Mar 2018 22:19:14 -0500
Message-ID: <CAHbuEH6NDzxHNmZ8gSCVYV=tFaF-ApE=dSrO6m-cKpPqZaQWpw@mail.gmail.com>
To: "Zhangmingui (Martin)" <zhangmingui@huawei.com>
Cc: Roman Danyliw <rdd@cert.org>, "iesg@ietf.org" <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-trill-multilevel-unique-nickname.all@ietf.org" <draft-ietf-trill-multilevel-unique-nickname.all@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/3xHUauIIsrQfP3Apk8Ay7s2rhK0>
Subject: Re: [secdir] Secdir review of draft-ietf-trill-multilevel-unique-nickname-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 03:19:57 -0000

Thank you, Roman for the review and authors for the responses and updates!

Kathleen

On Tue, Mar 6, 2018 at 10:15 PM, Zhangmingui (Martin)
<zhangmingui@huawei.com>; wrote:
> Hi Roman,
>
> All changes you suggested in item (8) are fair. I've made these changes into the 07 version. Awaiting for uploading.
>
> Thanks,
> Mingui
>
>> -----Original Message-----
>> From: Roman Danyliw [mailto:rdd@cert.org]
>> Sent: Wednesday, March 07, 2018 12:32 AM
>> To: iesg@ietf.org; secdir@ietf.org;
>> draft-ietf-trill-multilevel-unique-nickname.all@ietf.org
>> Subject: RE: Secdir review of draft-ietf-trill-multilevel-unique-nickname-05
>>
>> Hi Donald and Mingui!
>>
>> Thanks for the changes in -06.  Any thoughts on item (8)?
>>
>> Roman
>>
>> > -----Original Message-----
>> > From: Roman Danyliw
>> > Sent: Friday, March 02, 2018 9:01 PM
>> > To: iesg@ietf.org; secdir@ietf.org;
>> > draft-ietf-trill-multilevel-unique-
>> > nickname.all@ietf.org
>> > Subject: Secdir review of
>> > draft-ietf-trill-multilevel-unique-nickname-05
>>
>> [snip]
>>
>> > (8) There appear to be a few instances of key protocol behavior not
>> > using
>> > RFC2119 language.  I'd suggest:
>> >
>> > Section 3.2.2, Global Distribution Tree, Page 6
>> > (old) Also, this border RBridge needs to advertise the set of local
>> > distribution trees by providing another set of nicknames
>> > (new) Also, this border RBridge MUST advertise the set of local
>> > distribution trees by providing another set of nicknames
>> >
>> > Section 3.2.2, Global Distribution Tree, Page 6
>> > (old) If a border RBridge has been assigned both as a global tree root
>> > and a local tree root, it has to acquire both a global tree root
>> > nickname(s) and local tree root nickname(s)
>> > (new) If a border RBridge has been assigned both as a global tree root
>> > and a local tree root, it MUST acquire both a global tree root
>> > nickname(s) and local tree root nickname(s)
>> >
>> > Section 4.3, Nickname Announcements, Page 9
>> > (old) Besides its own nickname(s), a border RBridge needs to announce,
>> > in its area, the ownership of all external nicknames that are
>> > reachable from this border RBridge.
>> > (new) Besides its own nickname(s), a border RBridge MUST announce, in
>> > its area, the ownership of all external nicknames that are reachable
>> > from this border RBridge.
>> >
>> > Section 4.3, Nickname Announcements, Page 9
>> > (old) Also, a border RBridge needs to announce, in Level 2, the
>> > ownership of all nicknames within its area. From listening to these
>> > Level 2 announcements, border RBridges can figure out the nicknames used
>> by other areas.
>> > (new) Also, a border RBridge MUST announce, in Level 2, the ownership
>> > of all nicknames within its area. From listening to these Level 2
>> > announcements, border RBridges can figure out the nicknames used by other
>> areas.
>> >
>> > Section 4.3, Nickname Announcements, Page 9
>> > (old) To address this issue, border RBridges should make use of the
>> > NickBlockFlags APPsub-TLV to advertise into the Level 1 area the
>> > inclusive range of nicknames that are available or not for self
>> > allocation by the Level 1 RBridges in that area.
>> > (new) To address this issue, border RBridges SHOULD use the
>> > NickBlockFlags APPsub-TLV to advertise into the Level 1 area the
>> > inclusive range of nicknames that are available or not for self
>> > allocation by the Level 1 RBridges in that area.
>> >
>> > Section 4.4, Capability Indication, Page 11
>> > (old) If there are RBridges that do not understand the NickBlockFlags
>> > APPsub-TLV, border RBridges of the area will also use the traditional
>> > Nickname Sub-TLV [RFC7176] to announce into the area those nicknames
>> > covered by the nickname blocks of the NickBlockFlags APPsub-TLV whose
>> > OK is 0.
>> > (new) If there are RBridges that do not understand the NickBlockFlags
>> > APPsub-TLV, border RBridges of the area MUST also use the traditional
>> > Nickname Sub-TLV [RFC7176] to announce into the area those nicknames
>> > covered by the nickname blocks of the NickBlockFlags APPsub-TLV whose
>> > OK is 0.
>> >
>> > Section 5, Mix with Aggregated nickname Areas, Page 11
>> > (old) Usage of nickname space must be planed so that nicknames used in
>> > any one unique nickname area and Level 2 are never used in any other
>> > areas which includes unique nickname areas as well as aggregated nickname
>> areas
>



-- 

Best regards,
Kathleen