Re: [secdir] secdir review of draft-ietf-teas-gmpls-lsp-fastreroute-09

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Tue, 04 July 2017 14:55 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF0FD131938; Tue, 4 Jul 2017 07:55:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.522
X-Spam-Level:
X-Spam-Status: No, score=-14.522 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fTglljUxum-U; Tue, 4 Jul 2017 07:55:50 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0882C1320C8; Tue, 4 Jul 2017 07:55:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=15048; q=dns/txt; s=iport; t=1499180149; x=1500389749; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=LTCFvmj06heFuioHfp1G3RPSMiw5JfUPX4p+QTpKpVI=; b=X2mjED5knQauou13l8uc2b/B0FimLm1T3w6eqj8FZBlHbqJzqZ7ANR9O IZeqRv7krZv9e8kPOra9/9Y3repjX6dc+x4VKxCNHe5BI+6BVN8N+7+cz q9U1X6SD+xyGOJXxwLD9SYUDZq6K3XWdvUkFx/lFPP2eEgRUp5ebFYtIC c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DxAAC/q1tZ/4MNJK1cGQEBAQEBAQEBAQEBBwEBAQEBgm9qY4EQB4NoihmRdYgsiCiFLIIRhhwCGoJwPxgBAgEBAQEBAQFrKIUYAQEBAQMjVhACAQgRAwECKwICAh8RHQgCBAENBYlLTAMVsGuCJimHCg2EBQEBAQEBAQEBAQEBAQEBAQEBAQEBAR2DJ4NMgWABK4J5gleBWVoGgm0wgjEFlymHIjsCjxmEagySEot0iT4BHziBCnUVWwGFAByBZnaIHQGBDAEBAQ
X-IronPort-AV: E=Sophos;i="5.40,307,1496102400"; d="scan'208,217";a="268816393"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jul 2017 14:55:48 +0000
Received: from XCH-ALN-020.cisco.com (xch-aln-020.cisco.com [173.36.7.30]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v64EtlSu029918 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 4 Jul 2017 14:55:48 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-ALN-020.cisco.com (173.36.7.30) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 4 Jul 2017 09:55:47 -0500
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1210.000; Tue, 4 Jul 2017 09:55:47 -0500
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>, "draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org" <draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, The IESG <iesg@ietf.org>
CC: DEBORAH BRUNGARD <db3546@att.com>, Lou Berger <lberger@labn.net>, Vishnu Pavan Beeram <vishnupavan@gmail.com>
Thread-Topic: [secdir] secdir review of draft-ietf-teas-gmpls-lsp-fastreroute-09
Thread-Index: AQHS9MsUKApW2nmrDkSMbsBbOiyZvqJD0ouA
Date: Tue, 04 Jul 2017 14:55:47 +0000
Message-ID: <E6C94EE4-C51B-47E2-AF0C-50AF1E967F44@cisco.com>
References: <CAGL6epL36m-j_UHLZ7zK+rTVNdOOTpnww1Q0i5zowxLp=+V1RA@mail.gmail.com>
In-Reply-To: <CAGL6epL36m-j_UHLZ7zK+rTVNdOOTpnww1Q0i5zowxLp=+V1RA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.213.85]
Content-Type: multipart/alternative; boundary="_000_E6C94EE4C51B47E2AF0C50AF1E967F44ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/4xgxnaap-dSMTxjjcKmzcsrbhNA>
Subject: Re: [secdir] secdir review of draft-ietf-teas-gmpls-lsp-fastreroute-09
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jul 2017 14:55:53 -0000

Thanks Rifaat for the review of this document.

Hi Deborah, Lou, Pavan,

Any thoughts on the following suggestion?

“Because the document extends RFC4090, it should add "Updates: 4090" at the top of the document.”

Thanks,
Rakesh


From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Tuesday, July 4, 2017 at 9:32 AM
To: "draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org" <draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>, The IESG <iesg@ietf.org>
Subject: [secdir] secdir review of draft-ietf-teas-gmpls-lsp-fastreroute-09
Resent-From: <alias-bounces@ietf.org>
Resent-To: "=SMTP:mtaillon@cisco. com" <mtaillon@cisco.com>, <tsaad@cisco.com>, "=SMTP:rgandhi@cisco. com" <rgandhi@cisco.com>, Zafar Ali <zali@cisco.com>, <manav.bhatia@nokia.com>, <mhartley@cisco.com>, Lou Berger <lberger@labn.net>, <vbeeram@juniper.net>, <aretana@cisco.com>, DEBORAH BRUNGARD <db3546@att.com>, <akatlas@gmail.com>
Resent-Date: Tuesday, July 4, 2017 at 9:40 AM

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should treat
these comments just like any other last call comments.

Summary: Ready with Nits


I did not have enough background on MLPS and GMPLS and their related RFCs,
so I had to do some reading to get some familiarity with this subject to be
able to provide some reasonable review of this document.

This document builds on an existing mechanism, "Fast Reroute Extensions to
RSVP-TE for LSP Tunnels" defined in RFC4090, which defines a mechanism to
establish a backup tunnels for local LSP tunnels. One limitation of the
existing mechanism is that in some situations it might assign different
uni-directional bypass tunnels for the forward and reverse directions.

This document extends the mechanism defined in RFC4090, by adding a new
BYPASS_ASSIGNMENT subobject to the existing RECORD_ROUTE Object (RRO) used
in PATH and RESV requests, to allow the establishment of a bi-directional
bypass tunnel.

The security of the existing mechanism still applies with the new mechanism,
and the security section discusses the implications of the new subobject and
the new error associated with that, which seems reasonable.

The document also points to an MPLS/GMPLS Security Framework (RFC5920)
document that has an extensive discussion of the security of MPLS/GMPLS
network in general that also applies to this document.


Nits

Because the document extends RFC4090, it should add "Updates: 4090" at the
top of the document.

Regards,
 Rifaat