Return-Path: <prvs=9364ce0616=hshah@ciena.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 9BE321ACD36;
 Tue, 14 Oct 2014 14:08:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.266
X-Spam-Level: 
X-Spam-Status: No, score=-2.266 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, IP_NOT_FRIENDLY=0.334,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id SibjsAZx7SKr; Tue, 14 Oct 2014 14:08:07 -0700 (PDT)
Received: from mx0b-00103a01.pphosted.com (mx0b-00103a01.pphosted.com
 [67.231.152.227])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id ABE601ACD29;
 Tue, 14 Oct 2014 14:08:04 -0700 (PDT)
Received: from pps.filterd (m0002317.ppops.net [127.0.0.1])
 by mx0b-00103a01.pphosted.com (8.14.5/8.14.5) with SMTP id s9EL54gK017503;
 Tue, 14 Oct 2014 17:07:55 -0400
Received: from mdwvexchht01.ciena.com (LIN1-118-36-28.ciena.com [63.118.36.28])
 by mx0b-00103a01.pphosted.com with ESMTP id 1q13wds52b-1
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
 Tue, 14 Oct 2014 17:07:55 -0400
Received: from ONWVEXCHHT04.ciena.com (10.128.6.44) by MDWVEXCHHT01.ciena.com
 (10.4.156.175) with Microsoft SMTP Server (TLS) id 8.3.298.1;
 Tue, 14 Oct 2014 17:07:54 -0400
Received: from ONWVEXCHMB04.ciena.com ([::1]) by ONWVEXCHHT04.ciena.com
 ([::1]) with mapi; Tue, 14 Oct 2014 17:07:54 -0400
From: "Shah, Himanshu" <hshah@ciena.com>
To: "Zhangdacheng (Dacheng)" <zhangdacheng@huawei.com>,
 "draft-ietf-l2vpn-ipls@tools.ietf.org"
 <draft-ietf-l2vpn-ipls.all@tools.ietf.org>
Date: Tue, 14 Oct 2014 17:07:52 -0400
Thread-Topic: Secdir review of draft-ietf-l2vpn-ipls-14
Thread-Index: Ac+tbKBmSURf/kQdQ6KYONVa4goh8A6YqBzQ
Message-ID: <40746B2300A8FC4AB04EE722A593182B7B575438@ONWVEXCHMB04.ciena.com>
References: <C72CBD9FE3CA604887B1B3F1D145D05E7BCAD63E@nkgeml507-mbs.china.huawei.com>
In-Reply-To: <C72CBD9FE3CA604887B1B3F1D145D05E7BCAD63E@nkgeml507-mbs.china.huawei.com>
Accept-Language: en-US, en-CA
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US, en-CA
X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-21022.003
X-TM-AS-Result: No--15.970600-8.000000-31
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
Content-Type: multipart/alternative;
 boundary="_000_40746B2300A8FC4AB04EE722A593182B7B575438ONWVEXCHMB04cie_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52, 1.0.28, 
 0.0.0000
 definitions=2014-10-14_08:2014-10-14,2014-10-14,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
 suspectscore=0 phishscore=0
 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=7.0.1-1402240000 definitions=main-1410140202
Archived-At: http://mailarchive.ietf.org/arch/msg/secdir/BB5y-z5shWbp4mAXYL3I1tSoIeg
X-Mailman-Approved-At: Tue, 14 Oct 2014 14:13:09 -0700
Cc: IESG <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [secdir] Secdir review of draft-ietf-l2vpn-ipls-14
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>,
 <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>,
 <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Oct 2014 21:08:11 -0000

--_000_40746B2300A8FC4AB04EE722A593182B7B575438ONWVEXCHMB04cie_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Dacheng,
Thanks for your review and suggestions for improvements.
I also apologize for the delay in the response.

My comments in line.

Regards,
himanshu

From: Zhangdacheng (Dacheng) [mailto:zhangdacheng@huawei.com]
Sent: Friday, August 01, 2014 2:40 AM
To: draft-ietf-l2vpn-ipls@tools.ietf.org
Cc: IESG; secdir@ietf.org
Subject: Secdir review of draft-ietf-l2vpn-ipls-14


Hello,

I have reviewed this document as part of the security directorate's ongoing=
 effort to review all IETF documents being processed by the IESG.  These co=
mments were written primarily for the benefit of the security area director=
s.  Document editors and WG chairs should treat these comments just like an=
y other last call comments.

This document proposes a 'simplified' type of VPLS which only support IP. I=
n addition, in this solution the maintenance of the MAC forwarding tables i=
s done via a control plane protocol, rather than via the MAC address learni=
ng procedures specified in [IEEE 802.1D]

I think this document is almost ready for publication. Two comments are as =
follows:

1)       In security consideration, MD5 should not be recommended. So, "aut=
henticating the LDP messages using MD5 authentication." could be changed to=
 "authenticating the LDP messages by verifying keyed digests."

Himanshu> OK, I will change the text.

2) In this solution, a PE actively detects the presence of local CEs by sno=
oping IP and ARP frames received over the ACs. As the PE discovers each loc=
ally attached CE, a unicast multipoint- to-point pseudowire (mp2p PW) assoc=
iated exclusively with that CE is created by distributing the MAC address a=
nd optionally IP address of the CE along with a PW-Label to all the remote =
PE peers that participate in the same IPLS instance. So, IMHO, DDoS attacks=
 by generating large amounts of bogus IP and ARP frames should be considere=
d, and counter measures should be provided. For instance, MAC addresses of =
CEs should be distributed only in a limited frequency.

[himanshu>] I believe the rate control should be left up to the implementat=
ion.

Cheers

Dacheng

--_000_40746B2300A8FC4AB04EE722A593182B7B575438ONWVEXCHMB04cie_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV=3D"Content-Type" CONTENT=
=3D"text/html; charset=3Dus-ascii"><meta name=3DGenerator content=3D"Micros=
oft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:SimSun;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Cambria;
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Tahoma;
	panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
	{font-family:"\@SimSun";
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:Consolas;
	panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	text-align:justify;
	font-size:10.5pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
	{mso-style-priority:99;
	mso-style-link:"Plain Text Char";
	margin:0in;
	margin-bottom:.0001pt;
	font-size:10.5pt;
	font-family:"Calibri","sans-serif";}
pre
	{mso-style-priority:99;
	mso-style-link:"HTML Preformatted Char";
	margin:0in;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:SimSun;}
span.HTMLPreformattedChar
	{mso-style-name:"HTML Preformatted Char";
	mso-style-priority:99;
	mso-style-link:"HTML Preformatted";
	font-family:"Consolas","serif";}
span.PlainTextChar
	{mso-style-name:"Plain Text Char";
	mso-style-priority:99;
	mso-style-link:"Plain Text";
	font-family:"Consolas","serif";}
span.EmailStyle21
	{mso-style-type:personal;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
p.a, li.a, div.a
	{mso-style-name:\7EAF\6587\672C;
	mso-style-link:"\7EAF\6587\672C Char";
	margin:0in;
	margin-bottom:.0001pt;
	text-align:justify;
	font-size:10.5pt;
	font-family:"Calibri","sans-serif";}
span.Char
	{mso-style-name:"\7EAF\6587\672C Char";
	mso-style-priority:99;
	mso-style-link:\7EAF\6587\672C;
	font-family:"Calibri","sans-serif";}
p.HTML, li.HTML, div.HTML
	{mso-style-name:"HTML \9884\8BBE\683C\5F0F";
	mso-style-link:"HTML \9884\8BBE\683C\5F0F Char";
	margin:0in;
	margin-bottom:.0001pt;
	text-align:justify;
	font-size:10.5pt;
	font-family:"Calibri","sans-serif";}
span.HTMLChar
	{mso-style-name:"HTML \9884\8BBE\683C\5F0F Char";
	mso-style-priority:99;
	mso-style-link:"HTML \9884\8BBE\683C\5F0F";
	font-family:SimSun;}
span.EmailStyle26
	{mso-style-type:personal-reply;
	font-family:"Cambria","serif";
	color:#0040C0;
	font-weight:normal;
	font-style:italic;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
	{page:WordSection1;}
/* List Definitions */
@list l0
	{mso-list-id:459108879;
	mso-list-type:hybrid;
	mso-list-template-ids:-736610202 67698705 67698713 67698715 67698703 67698=
713 67698715 67698703 67698713 67698715;}
@list l0:level1
	{mso-level-text:"%1\)";
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level2
	{mso-level-number-format:alpha-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level3
	{mso-level-number-format:roman-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:right;
	text-indent:-9.0pt;}
@list l0:level4
	{mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level5
	{mso-level-number-format:alpha-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level6
	{mso-level-number-format:roman-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:right;
	text-indent:-9.0pt;}
@list l0:level7
	{mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level8
	{mso-level-number-format:alpha-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level9
	{mso-level-number-format:roman-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:right;
	text-indent:-9.0pt;}
ol
	{margin-bottom:0in;}
ul
	{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]--></head><body lang=3DEN-US link=3Dblue vli=
nk=3Dpurple style=3D'text-justify-trim:punctuation'><div class=3DWordSectio=
n1><p class=3DMsoNormal><i><span style=3D'font-size:11.0pt;font-family:"Cam=
bria","serif";color:#0040C0'>Hi Dacheng,<o:p></o:p></span></i></p><p class=
=3DMsoNormal><i><span style=3D'font-size:11.0pt;font-family:"Cambria","seri=
f";color:#0040C0'>Thanks for your review and suggestions for improvements.<=
o:p></o:p></span></i></p><p class=3DMsoNormal><i><span style=3D'font-size:1=
1.0pt;font-family:"Cambria","serif";color:#0040C0'>I also apologize for the=
 delay in the response.<o:p></o:p></span></i></p><p class=3DMsoNormal><i><s=
pan style=3D'font-size:11.0pt;font-family:"Cambria","serif";color:#0040C0'>=
<o:p>&nbsp;</o:p></span></i></p><p class=3DMsoNormal><i><span style=3D'font=
-size:11.0pt;font-family:"Cambria","serif";color:#0040C0'>My comments in li=
ne.<o:p></o:p></span></i></p><p class=3DMsoNormal><i><span style=3D'font-si=
ze:11.0pt;font-family:"Cambria","serif";color:#0040C0'><o:p>&nbsp;</o:p></s=
pan></i></p><p class=3DMsoNormal><i><span style=3D'font-size:11.0pt;font-fa=
mily:"Cambria","serif";color:#0040C0'>Regards,<o:p></o:p></span></i></p><p =
class=3DMsoNormal><i><span style=3D'font-size:11.0pt;font-family:"Cambria",=
"serif";color:#0040C0'>himanshu<o:p></o:p></span></i></p><p class=3DMsoNorm=
al><i><span style=3D'font-size:11.0pt;font-family:"Cambria","serif";color:#=
0040C0'><o:p>&nbsp;</o:p></span></i></p><div><div style=3D'border:none;bord=
er-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=3DMsoNormal =
align=3Dleft style=3D'text-align:left'><b><span style=3D'font-size:10.0pt;f=
ont-family:"Tahoma","sans-serif"'>From:</span></b><span style=3D'font-size:=
10.0pt;font-family:"Tahoma","sans-serif"'> Zhangdacheng (Dacheng) [mailto:z=
hangdacheng@huawei.com] <br><b>Sent:</b> Friday, August 01, 2014 2:40 AM<br=
><b>To:</b> draft-ietf-l2vpn-ipls@tools.ietf.org<br><b>Cc:</b> IESG; secdir=
@ietf.org<br><b>Subject:</b> Secdir review of draft-ietf-l2vpn-ipls-14<o:p>=
</o:p></span></p></div></div><p class=3DMsoNormal align=3Dleft style=3D'tex=
t-align:left'><o:p>&nbsp;</o:p></p><p class=3DMsoPlainText style=3D'margin-=
top:15.6pt'><span style=3D'mso-fareast-language:ZH-CN'>Hello,<o:p></o:p></s=
pan></p><p class=3DMsoPlainText style=3D'margin-top:15.6pt'><span style=3D'=
mso-fareast-language:ZH-CN'>I have reviewed this document as part of the se=
curity directorate's ongoing effort to review all IETF documents being proc=
essed by the IESG.&nbsp; These comments were written primarily for the bene=
fit of the security area directors.&nbsp; Document editors and WG chairs sh=
ould treat these comments just like any other last call comments.<o:p></o:p=
></span></p><p class=3DMsoPlainText style=3D'margin-top:15.6pt'><span style=
=3D'mso-fareast-language:ZH-CN'>This document proposes a </span><span style=
=3D'font-family:"Courier New";mso-fareast-language:ZH-CN'>&#8216;</span><sp=
an style=3D'mso-fareast-language:ZH-CN'>simplified</span><span style=3D'fon=
t-family:"Courier New";mso-fareast-language:ZH-CN'>&#8217;</span><span styl=
e=3D'mso-fareast-language:ZH-CN'> type of VPLS which only support IP. In ad=
dition, in this solution the maintenance of the MAC forwarding tables is do=
ne via a control plane protocol, rather than via the MAC address learning p=
rocedures specified in [IEEE 802.1D]<o:p></o:p></span></p><p class=3DMsoPla=
inText style=3D'margin-top:15.6pt'><span style=3D'mso-fareast-language:ZH-C=
N'>I think this document is almost ready for publication. Two comments are =
as follows:<o:p></o:p></span></p><p class=3DMsoPlainText style=3D'mso-margi=
n-top-alt:15.6pt;margin-right:0in;margin-bottom:0in;margin-left:.5in;margin=
-bottom:.0001pt;text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportL=
ists]><span style=3D'mso-fareast-language:ZH-CN'><span style=3D'mso-list:Ig=
nore'>1)<span style=3D'font:7.0pt "Times New Roman"'>&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp; </span></span></span><![endif]><span style=3D'mso-fareast-la=
nguage:ZH-CN'>In security consideration, MD5 should not be recommended. So,=
 &quot;authenticating the LDP messages using MD5 authentication.&quot; coul=
d be changed to &quot;authenticating the LDP messages by verifying keyed di=
gests.&quot;<o:p></o:p></span></p><p class=3DMsoPlainText style=3D'margin-t=
op:15.6pt'><span style=3D'color:#0040C0;mso-fareast-language:ZH-CN'>Himansh=
u&gt; OK, I will change the text.<o:p></o:p></span></p><p class=3DMsoPlainT=
ext style=3D'margin-top:15.6pt'><span style=3D'mso-fareast-language:ZH-CN'>=
2) In this solution, a PE actively detects the presence of local CEs by sno=
oping IP and ARP frames received over the ACs. As the PE discovers each loc=
ally attached CE, a unicast multipoint- to-point pseudowire (mp2p PW) assoc=
iated exclusively with that CE is created by distributing the MAC address a=
nd optionally IP address of the CE along with a PW-Label to all the remote =
PE peers that participate in the same IPLS instance. So, IMHO, DDoS attacks=
 by generating large amounts of bogus IP and ARP frames should be considere=
d, and counter measures should be provided. For instance, MAC addresses of =
CEs should be distributed only in a limited frequency.<o:p></o:p></span></p=
><p class=3DMsoPlainText style=3D'margin-top:15.6pt'><i><span style=3D'font=
-size:11.0pt;font-family:"Cambria","serif";color:#0040C0;mso-fareast-langua=
ge:ZH-CN'>[himanshu&gt;] I believe the rate control should be left up to th=
e implementation.<o:p></o:p></span></i></p><p class=3DMsoPlainText style=3D=
'margin-top:15.6pt'><span style=3D'mso-fareast-language:ZH-CN'>Cheers<o:p><=
/o:p></span></p><p class=3DMsoPlainText style=3D'margin-top:15.6pt'><span s=
tyle=3D'mso-fareast-language:ZH-CN'>Dacheng<o:p></o:p></span></p></div></bo=
dy></html>=

--_000_40746B2300A8FC4AB04EE722A593182B7B575438ONWVEXCHMB04cie_--

