[secdir] SECDIR Re-Reveiw of draft-ietf-hip-dex
Donald Eastlake <d3e3e3@gmail.com> Mon, 06 July 2020 02:31 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 354473A0DAD; Sun, 5 Jul 2020 19:31:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.847
X-Spam-Level:
X-Spam-Status: No, score=-1.847 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0TNlmk0M4tJ; Sun, 5 Jul 2020 19:31:06 -0700 (PDT)
Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F2DF3A0DAC; Sun, 5 Jul 2020 19:31:06 -0700 (PDT)
Received: by mail-il1-x134.google.com with SMTP id h16so8301960ilj.11; Sun, 05 Jul 2020 19:31:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=lmdHQM4t2oBBn2kRL4dHKvBNBuaf8IIbyNIIxKsJOhc=; b=ECI/p/Q7BYDUWl1RLDn8IZLSnxIGF3et9QJ++tt6usmhu5rXrXHUBkIPBc0AE0D9bq cXqE8hSwB3IcGy1om8JghLLjs9PqTmOHpJsUAlELjBCumsmcAoFCVxzeMABfM/KE1eT4 ZbCZi10EN0mS6OvPl9XNSXKdTYzP4sjqRAtLzDqukNWLKOyJjZpiTQS1geYJqr0slD7k IWRdlUqckfZIKBsnq3IcWt/W3zAlBtdo+xphyAiLADfv5x3LhZE9PapOBI87opNzo2kX 4ROxaNy6feeOadFLNVETvcV7JqxJq/GBMJkWfoU3m9tF9b0bIUiDGbrZXQ+uyAsDvQSw 70Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lmdHQM4t2oBBn2kRL4dHKvBNBuaf8IIbyNIIxKsJOhc=; b=M1YZpbdYk11rFu5zBdGODFrxIHahjgiMC5Gq/aCRrhKt3QHZQLEN4k086UqcniYKpJ CXIFBRlXGobgRrIudsGxLZpKx9W31bk5t6vG5NGpqnSgy9ilfXB1YU/XgkPK1aHimLvt EDruP1Gcr6kZhhSb8D8QhupQmmmUC4tBFGcvq8x0GuYfD7bxm5i1uuAGYfKG485C7aCU spCG+zkz0wyRE+9L4yYSkuAWyfkc9Dg1F1N4g/YEJ/s3T9NCTYBu3ONbKOXJ6Pq8C9ff G+biAJ7WTDIB7vPvZnpJb+JR4R8kqNr0fEhnePjhDeqDbjK4CYw+Hny4NqTlPvWC30rq LE8w==
X-Gm-Message-State: AOAM5331qJWwo5e8K2AL5k0qXm4O3Ze8SQsttBmqNkZhF8lwkyGQ/Xk2 N7dK84WH/3+0yPseKWPHCD/l0AjIR7A2g2qVRJZQcrb4
X-Google-Smtp-Source: ABdhPJy1TYsPHMKoY/iQ/Qkapl2mDMgDLcTf7mDQHirGdlT1NLfcv9Ax/TA9tqWyw/G+mOgz9cWCAk5SXhUHJDKCouI=
X-Received: by 2002:a92:aa92:: with SMTP id p18mr28268949ill.199.1594002665596; Sun, 05 Jul 2020 19:31:05 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sun, 05 Jul 2020 22:30:54 -0400
Message-ID: <CAF4+nEGugeTKFvuNRFDQTvYKBG8EexAYwxVaiHMfK1rOEkwsag@mail.gmail.com>
To: "iesg@ietf.org" <iesg@ietf.org>, secdir <secdir@ietf.org>, draft-ietf-hip-dex.all@ietf.org, secdir-secretary@mit.org
Content-Type: multipart/alternative; boundary="000000000000a76bb405a9bcaa1a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/CfsIF6vN_KnIlPJQLURELZ_cuJs>
Subject: [secdir] SECDIR Re-Reveiw of draft-ietf-hip-dex
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2020 02:31:08 -0000
Hi, I have checked the current -20 version of this draft against my previous review below. All my comments are resolved except that I think the plural of SHOULD is SHOULDs, not SHOULDS, and there are still occurrences of SHOULDS in Appendix B of the draft. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com ---------- Forwarded message --------- From: Donald Eastlake <d3e3e3@gmail.com> Date: Mon, Jan 20, 2020 at 11:18 PM Subject: SECDIR Reveiw of draft-ietf-hip-dex-11 To: <draft-ietf-hip-dex.all@ietf.org> Cc: iesg@ietf.org <iesg@ietf.org>, secdir <secdir@ietf.org> I have reviewed this document as (a very late) part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. The summary of the review is Ready with Nits. Sorry to get this review in so late but, while approved by the IESG, the draft is still in revised draft needed state so this may do some good. On the security front, although the draft is pretty complex and I am not that familiar with HIP, I did not see any significant security issues that were not already called out in the draft. So I concentrated on possible editorial issues. Editorial: Section 1.1, 3rd paragraph, page 5. Delete "However," a the beginning of the 2nd sentence. It doesn't make sense. Section 2.3, Definitions should be in alphabetic order. Section 2.3: It seems to me that people who are puzzled about what something means are most likely to be puzzled by the acronym. So I would put the acronym first, where there is an acronym or acronym-like term to use, then the expansion in parenthesis or in the body of the definition. This done for a couple of entries like CMAC and CKDF but most are the other way. Section 3 last paragraph and Section 12.10 5th bullet: "to use" -> "use of" I think OGA and KEYMAT should be in the Definitions list and KEYMAT, which I assume just is short for "keying material", should be expanded on first use in Section 6.3. Alternatively, you could just replace all occurrences of KEYMAT with "Keying Material". Section 5.3.2, page 23. The first sentence of the first paragraph starting on that page has problems. Maybe "chose" should be "choses" but I'm not sure: "The DH_GROUP_LIST parameter contains the Responder's order of preference based on which the Responder chose the ECDH key contained in the HOST_ID parameter (see below)." Appendix A, first sentence, "allows to identify" -> "allows identifying" Appendix B, "IEDG" -> "IESG" Appendix B, around the middle of page 51, right after the line beginning with "Section 6," there are three line with a blank line before and after. I found this confusing at first. I suggest those three line also be indented. Appendix B, page 52, "SHOUDS" -> "SHOUDs" Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com
- [secdir] SECDIR Re-Reveiw of draft-ietf-hip-dex Donald Eastlake
- Re: [secdir] SECDIR Re-Reveiw of draft-ietf-hip-d… Eric Vyncke (evyncke)
- Re: [secdir] SECDIR Re-Reveiw of draft-ietf-hip-d… Robert Moskowitz