Re: [secdir] secdir review of draft-ietf-spring-segment-routing-13

Benjamin Kaduk <kaduk@mit.edu> Thu, 29 March 2018 00:46 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3FF8128C0A for <secdir@ietfa.amsl.com>; Wed, 28 Mar 2018 17:46:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQ32q6NlQo3S for <secdir@ietfa.amsl.com>; Wed, 28 Mar 2018 17:46:42 -0700 (PDT)
Received: from dmz-mailsec-scanner-6.mit.edu (dmz-mailsec-scanner-6.mit.edu [18.7.68.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15927126C25 for <secdir@ietf.org>; Wed, 28 Mar 2018 17:46:41 -0700 (PDT)
X-AuditID: 12074423-627ff70000005664-dd-5abc376fc72f
Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id 4E.26.22116.F673CBA5; Wed, 28 Mar 2018 20:46:40 -0400 (EDT)
Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id w2T0kctR009888; Wed, 28 Mar 2018 20:46:38 -0400
Received: from kduck.kaduk.org (24-107-191-124.dhcp.stls.mo.charter.com [24.107.191.124]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id w2T0kXv3007490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 28 Mar 2018 20:46:37 -0400
Date: Wed, 28 Mar 2018 19:46:33 -0500
From: Benjamin Kaduk <kaduk@mit.edu>
To: Tero Kivinen <kivinen@iki.fi>
Cc: "secdir@ietf.org" <secdir@ietf.org>
Message-ID: <20180329004632.GM76724@kduck.kaduk.org>
References: <3b7c6cdc-0e9e-0a57-e030-ae3a715c6a03@mandelberg.org> <e32e5f9bc00043e3a8b86205d434c35d@XCH-ALN-001.cisco.com> <56ce2942-388f-d03b-721a-3b06af5559bc@mandelberg.org> <ef5efa3a9f1d434580946f1012ebb0bc@XCH-ALN-001.cisco.com> <9521bc0e-a1f2-046e-8e92-9e4a64237036@mandelberg.org> <d259d31119534e76b1ebf45faab43941@XCH-ALN-001.cisco.com> <894918aa-b853-299c-38f4-6c56ce385c64@mandelberg.org> <20180326153348.GE44086@kduck.kaduk.org> <d0274470-5737-57f4-1d16-0631f386403c@mandelberg.org> <23228.2906.789875.266549@fireball.acr.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <23228.2906.789875.266549@fireball.acr.fi>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNIsWRmVeSWpSXmKPExsUixCmqrVtgvifKoO8+r8XR88/ZLD4sfMji wOSxZMlPJo/DXxeyBDBFcdmkpOZklqUW6dslcGXMnKJR8IWz4sHMn8wNjK/Zuxg5OSQETCR6 1i1m7GLk4hASWMwkMfnuX1YIZyOjROvctUwgVUICV5kk3nyoBbFZBFQlHvx8BdbNJqAi0dB9 mRnEFhFQlNj9ZCtYPbOAusSb+6vZQGxhAW+JxQs7GEFsXqBtt299Z4FYsIpFYsL6JywQCUGJ kzMhbGYBLYkb/14CDeIAsqUllv/jADE5BcwlJi1LB6kQFVCW2Nt3iH0Co8AsJM2zkDTPQmhe wMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdMLzezRC81pXQTIyhE2V2UdzC+7PM+xCjAwajE w2uxaHeUEGtiWXFl7iFGSQ4mJVHew2+AQnxJ+SmVGYnFGfFFpTmpxYcYJTiYlUR432sA5XhT EiurUovyYVLSHCxK4rweJtpRQgLpiSWp2ampBalFMFkZDg4lCd65ZnuihASLUtNTK9Iyc0oQ 0kwcnCDDeYCGt4LU8BYXJOYWZ6ZD5E8xGnOceD+lh5ljypJpPcxCLHn5ealS4rxXTYFKBUBK M0rz4KaB0oxE9v6aV4ziQM8J8x4FGcgDTFFw814BrWICWrWtaQfIqpJEhJRUAyPLv7+n/ie8 LinyeHVr6yGByUt/S9pLb7xvcLZg+3bW6wfubmX13d7xIud1fPPB9ydVa4Re3Z3If8WPh0++ 5XgsT+qHOb5ST+c/UuoI1BPmXTVJTunZAmeeVUnlVjeCL+6M17mXa2v587OY6t8XZXY+Z9cL mpxQSLD0v/Z5qsW5q/GulXs+ls1VYinOSDTUYi4qTgQA3T4org4DAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/D4LDu6tgF5WcZe8q7jYlmqXdcBk>
Subject: Re: [secdir] secdir review of draft-ietf-spring-segment-routing-13
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 00:46:44 -0000

Hi Tero,

On Thu, Mar 29, 2018 at 12:38:34AM +0300, Tero Kivinen wrote:
> 
> "Correct review" is meant to be used when you want to correct some
> mistke in your review. For example link points to wrong location or
> version does not match.
> 
> You can also use it to fix the "review summary" if it is incorrect for
> some reason, but it is not really meant to be used to mark whether the
> discussion triggered by the review caused the issues to be fixed.
> I.e., if the issues found in review are fixed, you do not edit the
> review, but simply reply to the review thread in mailing lists saying
> that "Yes, this solves my issues" or similar, so when ADs check the
> thread they will see that as final email in the thread and know that
> issues have been solved.

Thanks for the clarification!

> Perhaps we should make #2217 higher priority, so reviewers could enter
> unsolicited reviews themselves. 
> 
> [1] https://trac.tools.ietf.org/tools/ietfdb/ticket/2217

It's not entirely clear how often the situation comes up, so I'll
not try to influence the tools team's prioritization.  It will
probably be fine to just tell document authors who want to see a
"clean secdir review" that the system is set up to work differently.

-Ben