Re: [secdir] Review of draft-ietf-tictoc-security-requirements-05

Tal Mizrahi <talmi@marvell.com> Thu, 31 October 2013 07:58 UTC

Return-Path: <talmi@marvell.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BB8721E80C5; Thu, 31 Oct 2013 00:58:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.54
X-Spam-Level:
X-Spam-Status: No, score=-3.54 tagged_above=-999 required=5 tests=[AWL=-1.275, BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ydSKZo7qDO8g; Thu, 31 Oct 2013 00:58:40 -0700 (PDT)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by ietfa.amsl.com (Postfix) with ESMTP id 0A6BE11E8133; Thu, 31 Oct 2013 00:58:39 -0700 (PDT)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.14.5/8.14.5) with SMTP id r9V7wd2m010998; Thu, 31 Oct 2013 00:58:39 -0700
Received: from sc-owa02.marvell.com ([199.233.58.137]) by mx0b-0016f401.pphosted.com with ESMTP id 1ftb2msafm-1 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT); Thu, 31 Oct 2013 00:58:39 -0700
Received: from YK-HUB01.marvell.com (10.4.102.51) by sc-owa02.marvell.com (10.93.76.22) with Microsoft SMTP Server (TLS) id 8.3.213.0; Thu, 31 Oct 2013 00:58:38 -0700
Received: from IL-MB01.marvell.com ([10.4.102.53]) by YK-HUB01.marvell.com ([10.4.102.51]) with mapi; Thu, 31 Oct 2013 09:58:34 +0200
From: Tal Mizrahi <talmi@marvell.com>
To: Shawn M Emery <shawn.emery@oracle.com>, "secdir@ietf.org" <secdir@ietf.org>
Date: Thu, 31 Oct 2013 09:58:31 +0200
Thread-Topic: Review of draft-ietf-tictoc-security-requirements-05
Thread-Index: Ac7UdvBdPGEkt19FQgC7Tmib5nXYMABl808Q
Message-ID: <74470498B659FA4687F0B0018C19A89C01B87D833253@IL-MB01.marvell.com>
References: <51CAA254.6040303@oracle.com> <526F612D.1020005@oracle.com>
In-Reply-To: <526F612D.1020005@oracle.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-10-31_03:2013-10-31, 2013-10-31, 1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1305240000 definitions=main-1310310010
Cc: "Yaakov Stein \(yaakov_s@rad.com\)" <yaakov_s@rad.com>, "draft-ietf-tictoc-security-requirements.all@tools.ietf.org" <draft-ietf-tictoc-security-requirements.all@tools.ietf.org>, "odonoghue@isoc.org" <odonoghue@isoc.org>, "iesg@ietf.org" <iesg@ietf.org>
Subject: Re: [secdir] Review of draft-ietf-tictoc-security-requirements-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2013 07:58:46 -0000

Hi Shawn.

Thanks for your comments. 
We will accommodate them in the next draft.

Thanks,
Tal.


-----Original Message-----
From: Shawn M Emery [mailto:shawn.emery@oracle.com] 
Sent: Tuesday, October 29, 2013 9:18 AM
To: secdir@ietf.org
Cc: draft-ietf-tictoc-security-requirements.all@tools.ietf.org; iesg@ietf.org
Subject: Review of draft-ietf-tictoc-security-requirements-05

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.
These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments.

This internet-draft describes the threat analysis for time protocols, such as Precision Time Protocol (PTP) and the Network Time Protocol (NTP).

The draft itself discusses security considerations.  I believe the draft adequately covers the various threats and how to mitigate such attacks.  I just have a few comments below:

In regards to this paragraph in section 5.1.3:
    Authentication of slaves prevents unauthorized clocks from receiving
    time services. Preventing the master from serving unauthorized clocks
    can help in mitigating DoS attacks against the master. Note that the
    authentication of slaves might put a higher load on the master than
    serving the unauthorized clock, and hence this requirement is a
    SHOULD.

I think that this requirement of whether to allow for unauthorized clocks should be a MAY (as does the prior text in this section) and should state that the decision to do this should be based on the environment in which the master and slaves are deployed.

In regards to this paragraph in section 5.2.1:
    The requirement level of the first requirement is 'SHOULD' since in
    the presence of recursive authentication (Section 5.1.2.) this
    requirement may be redundant.

This should state that this is the "second requirement", not the "first requirement".

In section 5.5.1 what's the difference between a replay and playback attack?  If there is such a difference then playback needs to be defined.

In section 5.8, interception attacks is never explicitly described.

I don't understand this sentence:

The erroneous time may expose cryptographic
    algorithms that rely on time to prevent replay attacks.

Does this mean to say "security protocols" instead of "cryptographic algorithms"?

General comments:

None.

Editorial comments:

s/if a slave is/if a slave/

s/(Section 3.2.4.
    )/(Section 3.2.4.)/

s/Additional measure/Additional measures/

Looks like this sentence was truncated:

    The requirements in this subsection address MITM attacks such as the
    3.2.1.).

s/necessarily possible/possible/

s/5.1. ,/Section 5.1.,/

s/in the literature/in literature/

s/in [1588IPsec] and [Tunnel]/[1588IPsec] and [Tunnel]/

Shawn.
--