[secdir] Secdir telechat review of draft-ietf-bier-ospf-bier-extensions-11

Adam Montville <adam.w.montville@gmail.com> Tue, 13 February 2018 15:33 UTC

Return-Path: <adam.w.montville@gmail.com>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C64F126CB6; Tue, 13 Feb 2018 07:33:21 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Adam Montville <adam.w.montville@gmail.com>
To: <secdir@ietf.org>
Cc: bier@ietf.org, draft-ietf-bier-ospf-bier-extensions.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.72.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151853600160.14260.14154798734920051411@ietfa.amsl.com>
Date: Tue, 13 Feb 2018 07:33:21 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/FWX1s7A7oRWC1K2hfXE4tYrC29s>
Subject: [secdir] Secdir telechat review of draft-ietf-bier-ospf-bier-extensions-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2018 15:33:22 -0000

Reviewer: Adam Montville
Review result: Not Ready

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the security area directors.
 Document editors and WG chairs should treat these comments just like any other
last call comments.

The security ADs may prefer to see an elaborated Security Considerations
section. From my perspective, the single sentence seeking to ensure that
malformed TLV and Sub-TLV permutations don't result in hard OSPF failures is
insufficient. What could be the outcome of such hard failures (i.e. what does
an implementer need to understand about not heeding such considerations)? Also,
a reader might presume that there are no additional BIER security
considerations not otherwise handled in RFCs 8279 and 8296 respectively. If
such a presumption is correct, then I would recommend explicitly stating so and
perhaps even referring the reader to those Security Considerations for anything
that may apply to this extension. Finally, in the first sentence of the
Security Considerations, there exists "must" - is that intended to be MUST?

I don't have any further comments on this draft from a nit perspective nor from
an efficacy perspective when it comes to routing, as this isn't my area of
expertise.

Kind regards,

Adam