Re: [secdir] Review of draft-ietf-mmusic-trickle-ice-sip-12

Thomas Stach <thomass.stach@gmail.com> Thu, 01 February 2018 22:49 UTC

Return-Path: <thomass.stach@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D780126CC7; Thu, 1 Feb 2018 14:49:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wfnzFIOtGCgT; Thu, 1 Feb 2018 14:49:18 -0800 (PST)
Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5289B12EAF6; Thu, 1 Feb 2018 14:49:10 -0800 (PST)
Received: by mail-wm0-x230.google.com with SMTP id r71so9072921wmd.1; Thu, 01 Feb 2018 14:49:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=1r6GTDNDm2BDy8hRc1onJO6PJmDiRLhcbRoteF8cmYs=; b=bPXPfEwzsZuWMZS/36zVM0DPIc5bF4Xu5SlTfJJEiBJd0WoxWizYe3QffYJKnubDly v8/x5b8rTMgaYT0Z5J8JElv5DuRnoTwgW83jfPkmFBpOWsYfXuqub5C+TAund7E1vCrT 7KS6rxo8/iXaUMYmpJuDyXe2vg7vIWYotyM9l4oHdCWPikZ9jGjk856EFjyq+MrYODNZ V2dbzOeSBUsOvGyB7iRSbECHS1zSJPw8k0/X+eWEjCakdbMf1z/uqB/N5TUTjs3iE0wE rHQeNwijW0I8GvWeBCZkwbjEPiJJfU3YHesU8bygYM9/x5YcIdr1iFVrwV0b2OloV294 i4oA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=1r6GTDNDm2BDy8hRc1onJO6PJmDiRLhcbRoteF8cmYs=; b=eUnmdN1CeKHth/Wm1xDWv90utHjYGwdA11WSr2IGHM5BnrqmqpnbhNN5/SRCx1k3bh sMR6gw58c8GDcGgPKQVM4/GwOWTvsifhMrWtOMHLgTideXGKR5UcyhbLReoIvGQuWYT4 C1f3eDs2W0V3hzne1999C+uumbplXV3J+Rt787GVkAcX+iZa1ng4ZVhlm6ualmUAejhu Cb36oCD9X9HUTXqOWW/Zd7u8VajYn648ty12NwCgf/IlD2BJKbhHrZUtVa6vzhqTjgGF b27gtXhGITh3DPfqobGLNzqi86j8ytnfwSxh7dkMcjepAy4M75yNAhxLOf33lFXBb5rS GY9Q==
X-Gm-Message-State: AKwxytdCEnbBw30NnENmLDxoyRO8D63TRayIM+qFuYx7iRkTUgOcO+sa MQrBaRm71q1QiS6izHuHiXNswdg6mdk=
X-Google-Smtp-Source: AH8x227dtJNnYwutzybb75DfRKY6FJR/mrvqQE4EMOe0FNojmiv4M7WOZYU1uDXtvO5sIdgdDqrfUw==
X-Received: by 10.80.194.194 with SMTP id u2mr11656026edf.84.1517525348589; Thu, 01 Feb 2018 14:49:08 -0800 (PST)
Received: from [192.168.2.110] (dsl-linz7-18-136.utaonline.at. [81.189.18.136]) by smtp.googlemail.com with ESMTPSA id f11sm575661edf.26.2018.02.01.14.49.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2018 14:49:07 -0800 (PST)
To: Shawn Emery <shawn.emery@gmail.com>, secdir@ietf.org, draft-ietf-mmusic-trickle-ice-sip.all@tools.ietf.org, mmusic@ietf.org
References: <CAChzXmZVt4hH2KCRk-9iMAsiLT5CuncGPuEX8xw0mr=CDFsbOQ@mail.gmail.com>
From: Thomas Stach <thomass.stach@gmail.com>
Message-ID: <5aba6339-a109-9602-3266-b69aef1d08a0@gmail.com>
Date: Thu, 01 Feb 2018 23:49:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAChzXmZVt4hH2KCRk-9iMAsiLT5CuncGPuEX8xw0mr=CDFsbOQ@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------1AF24D32A8E44FBFF09D06BA"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/Fnwsf0hbqNbqkzDiX-CyfCODE5E>
Subject: Re: [secdir] Review of draft-ietf-mmusic-trickle-ice-sip-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Feb 2018 22:49:20 -0000

Shawn,

first of all apologies for the delay in responding to your review.

Thanks for your effort.

Responses inline


On 2018-01-23 01:56, Shawn Emery wrote:
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the IESG.
> These comments were written primarily for the benefit of the security
> area directors. Document editors and WG chairs should treat these
> comments just like any other last call comments.
>
> This draft specifies how the Session Initiation Protocol (SIP) can use the
> non-blocking version of the Interactive Connectivity Establishment 
> (ICE) protocol,
> Trickle ICE, and defines a new registry for this usage.
>
> The security considerations section does exist and defers security 
> concerns to
> draft-ietf-mmusic-ice-sip-sdp, RFC 6086, and draft-ietf-ice-trickle.
>
> 1. draft-ietf-mmusic-ice-sip-sdp
> This will hopefully be available for a secdir review in the near 
> future, see general
> comments concern below.
> 2. RFC 6086
> 6086 prescribes S/MIME if the environment requires payloads to be 
> private and
> also suggests a digest-challenge in order to provide integrity protection.
> 3. draft-ietf-ice-trickle
> defers to draft-ietf-ice-rfc5245bis.  ice-sip should reference the 
> 5245bis draft
> directly. I won't duplicate Stephen's efforts in reviewing 5245bis.
>
> General comments:
>
> I'm concerned about the normative references to ietf-mmusic-ice-sip-sdp.
> This draft should progress before or along with any dependents.
As far as I can tell both draft will be progresses together in order to 
have the contents in-sync
>
> Editorial comments:
>
> Some of the abbreviations that are not expanded and are not listed as well
> known by the RFC Editor:
>
> SDP
> AOR
> STUN
> TURN
> GRUU (needs to be expanded in Section 3.1)
>
> making it cumbersome to follow the specification.
Sorry for that. I'll provide the necessary expansions.

Thanks again for your review!
Regards
Thomas
>
> Shawn.
> --