[secdir] Security review of draft-ietf-rtcweb-fec-08 (was Re: Security review of draft-ietf-perc-srtp-ekt-diet-08)

Ben Campbell <ben@nostrum.com> Fri, 01 February 2019 22:49 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5526130ECE; Fri, 1 Feb 2019 14:49:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.679
X-Spam-Level:
X-Spam-Status: No, score=-1.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JN4ScH-Phmqe; Fri, 1 Feb 2019 14:49:10 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 670C1130EBE; Fri, 1 Feb 2019 14:49:10 -0800 (PST)
Received: from [10.0.1.29] (cpe-70-122-203-106.tx.res.rr.com [70.122.203.106]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x11Mn4vv009143 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 1 Feb 2019 16:49:09 -0600 (CST) (envelope-from ben@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1549061350; bh=WCNxLYN746xefMws70nLQfng0Sb1MYCQ3uiM7RZFFDc=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=eOM1xDhywwhY20BLQYpVb9TyLStwQH2FZUVODnpm/lYbhRf5PZlNiBMEph1iIV6cI sWHmM9m+XXgiBoMc1EzzJ2XkCM755R5eCokK12nb6N3PsObjVIeHCggW3RL/63loVB sERPdElc/oEi0FO9sVKey1Ps3yALJKf556U6JwBQ=
X-Authentication-Warning: raven.nostrum.com: Host cpe-70-122-203-106.tx.res.rr.com [70.122.203.106] claimed to be [10.0.1.29]
From: Ben Campbell <ben@nostrum.com>
Message-Id: <F44FA6A0-4599-4BFF-8BEB-C67774714762@nostrum.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_8B4A7818-3703-41D3-9C9D-FFB6A0D3BDEB"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Fri, 01 Feb 2019 16:49:03 -0600
In-Reply-To: <201902010742.x117gdGm030846@rumpleteazer.rhmr.com>
Cc: The IESG <iesg@ietf.org>, secdir@ietf.org, draft-ietf-rtcweb-fec.all@tools.ietf.org
To: Hilarie Orman <hilarie@purplestreak.com>
References: <201902010742.x117gdGm030846@rumpleteazer.rhmr.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/GXm-C6SvsU-NKjYXUsSYbQwEDho>
Subject: [secdir] Security review of draft-ietf-rtcweb-fec-08 (was Re: Security review of draft-ietf-perc-srtp-ekt-diet-08)
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2019 22:49:12 -0000

Hi,

Please note that this review is for draft-ietf-rtcweb-fec-08, not the PERC draft referenced in the subject.

Thanks!

Ben.


> On Feb 1, 2019, at 1:42 AM, Hilarie Orman <hilarie@purplestreak.com> wrote:
> 
> Security Review of WebRTC Forward Error Correction Requirements
> draft-ietf-rtcweb-fec-08
> 
> Do not be alarmed.  I have reviewed this document as part of the
> security directorate's ongoing effort to review all IETF documents
> being processed by the IESG.  These comments were written primarily
> for the benefit of the security area directors.  Document editors and
> WG chairs should treat these comments just like any other last call
> comments.
> 
> The document describes the appropriate uses of FEC for web content when
> using WebRTC.  It also describes how to indicate that FEC is being used.
> 
> The Security Considerations mention the possibility of additional network
> congestion when using FEC.  Although this can be a problem, I do not think
> it is a security issue, thus it does not belong in this section.
> 
> There is a security-related issue wrt to FEC and encryption.  If the
> error model is that message blocks may be lost but not altered in
> transit, then FEC with encryption is fine.  But if FEC is added for
> the purpose of correcting corrupted bits in a message block, then it
> is important that FEC is done after encryption.  The draft seems to
> ignore the issue, and it also seems to recommend a processing scheme
> that would result in encryption of the FEC data.  If there is a body
> of practice for other IETF FEC protocols that explains these issues,
> an explicit reference to it in the Security Considerations would be
> very helpful.
> 
> Hilarie
> 
>