[secdir] Secdir last call review of draft-ietf-emu-eap-session-id-03

Mališa Vučinić via Datatracker <noreply@ietf.org> Tue, 26 May 2020 13:52 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C57863A0F7C; Tue, 26 May 2020 06:52:56 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Mališa Vučinić via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: last-call@ietf.org, draft-ietf-emu-eap-session-id.all@ietf.org, emu@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159050117661.11337.1336987637854906717@ietfa.amsl.com>
Reply-To: Mališa Vučinić <malisa.vucinic@inria.fr>
Date: Tue, 26 May 2020 06:52:56 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/HByohPKzKEq9nCIunUXoM463KrE>
Subject: [secdir] Secdir last call review of draft-ietf-emu-eap-session-id-03
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2020 13:52:59 -0000

Reviewer: Mališa Vučinić
Review result: Has Nits

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the security area directors.
Document editors and WG chairs should treat these comments just like any other
last call comments.

The document updates RFC5247 to specify EAP Session-ID definition in case fast
re-authentication is used with EAP-AKA and EAP-SIM. The Session-ID definition
is based on a server-generated nonce and a MAC. The document also specifies the
Session-ID definition for the PEAP method, following the definition of EAP-TLS.

The document is clear and well written. Security considerations section is
clear and states no known security issues in the definitions used. A reference
to PEAP is missing.

Nits:
Section 3: s/to not modify/do not modify