Re: [secdir] SECDIR review of draft-ietf-xrblock-rtcp-xr-burst-gap-loss-08

Qin Wu <bill.wu@huawei.com> Thu, 21 March 2013 11:13 UTC

Message-ID: <C8D9396C95454F3F8E332149669F6959@china.huawei.com>
From: Qin Wu <bill.wu@huawei.com>
To: Chris Lonvick <clonvick@cisco.com>, iesg@ietf.org, secdir@ietf.org, draft-ietf-xrblock-rtcp-xr-burst-gap-loss.all@tools.ietf.org
References: <alpine.LRH.2.00.1303181321400.15558@sjc-xdm-114.cisco.com>
Date: Thu, 21 Mar 2013 19:13:28 +0800
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: base64
Subject: Re: [secdir] SECDIR review of draft-ietf-xrblock-rtcp-xr-burst-gap-loss-08
Precedence: list

Hi, Chris:
Your proposed change looks good to me, thanks!

Regards
-Qin
----- Original Message ----- 
From: "Chris Lonvick" <clonvick@cisco.com>
To: <iesg@ietf.org>; <secdir@ietf.org>; <draft-ietf-xrblock-rtcp-xr-burst-gap-loss.all@tools.ietf.org>
Sent: Tuesday, March 19, 2013 4:27 AM
Subject: SECDIR review of draft-ietf-xrblock-rtcp-xr-burst-gap-loss-08


> Hi,
> 
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written primarily for the benefit of the
> security area directors.  Document editors and WG chairs should treat
> these comments just like any other last call comments.
> 
> I don't see any problems with this.  The only nit that I found was that I 
> couldn't fully understand a part of section 3.2.
> 
>   Loss and Discard Combination flag (C): 1 bit
> 
>       The 'C' flag is used to indicate whether combining loss/discard
>       report is needed.  This field MUST be set to '1' if the burst gap
>       loss report is present in conjunction with the burst gap discard
>       report in the same compound RTCP packet and MUST be set to '0'
>       otherwise.  If the burst gap discard is not sent with the burst
>       gap loss, then the receiver MUST discard the burst gap loss with
>       'C' flag set to 1.  If the 'C' flag is set to 0, then receiver
>       MUST NOT discard the burst gap loss Metrics Block when the burst
>       gap discard is not received.
> 
> Maybe something like the following:
> 
> The 'C' flag is used to indicate whether the loss/discard report is 
> combined with the burst gap loss report in the same compound RTCP packet. 
> The value MUST be set to '1' if the loss/discard report and the burst gap 
> loss report are combined.  Otherwise, the value MUST be set to '0'.  If 
> the burst gap discard is not sent with the burst gap loss, then the 
> receiver MUST discard the burst gap loss with 'C' flag set to 1.  If the 
> 'C' flag is set to 0, then receiver MUST NOT discard the burst gap loss 
> Metrics Block when the burst gap discard is not received.
> 
> 
> Best regards,
> Chris

[secdir] SECDIR review of draft-ietf-xrblock-rtcp… Chris Lonvick
Re: [secdir] SECDIR review of draft-ietf-xrblock-… Qin Wu