Re: [secdir] secdir review of draft-ietf-spring-segment-routing-13

[Tero Kivinen <[e-mail]>]

David Mandelberg writes:
> On 03/26/2018 11:33 AM, Benjamin Kaduk wrote:
> > On Fri, Mar 23, 2018 at 07:18:15PM -0400, David Mandelberg wrote:
> >> No worries about the delay. And I'm just a secdir reviewer, not an IESG
> >> member, so I can't do anything about a DISCUSS.
> > 
> > FWIW, you should be able to edit the secdir review's summary
> > evaulation by going into the dattracker (while logged in), finding
> > the "my reviews" item from either the sidebar or the <username>
> > dropdown in the top, selecting the given review request from the
> > list, and using the "correct review" button.  I don't know that we
> > have a huge amount of experience with doing this, whether you can
> > change the reviewed revision as well, etc., so don't feel like you
> > have to do this.  (But if you do, please report back to the secdir
> > list how it went!)
> 
> I edited it, so the state is now Ready. One thing that surprised me 
> though, is that adding a new review version changed the review link 
> ("posted at") and status for the old review version.

"Correct review" is meant to be used when you want to correct some
mistke in your review. For example link points to wrong location or
version does not match.

You can also use it to fix the "review summary" if it is incorrect for
some reason, but it is not really meant to be used to mark whether the
discussion triggered by the review caused the issues to be fixed.
I.e., if the issues found in review are fixed, you do not edit the
review, but simply reply to the review thread in mailing lists saying
that "Yes, this solves my issues" or similar, so when ADs check the
thread they will see that as final email in the thread and know that
issues have been solved.

Perhaps we should make #2217 higher priority, so reviewers could enter
unsolicited reviews themselves. 

[1] https://trac.tools.ietf.org/tools/ietfdb/ticket/2217
-- 
[e-mail]