[secdir] Secdir last call review of draft-ietf-stir-passport-shaken-04

Takeshi Takahashi <takeshi_takahashi@nict.go.jp> Sat, 03 November 2018 02:48 UTC

Return-Path: <takeshi_takahashi@nict.go.jp>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 50FD812777C; Fri, 2 Nov 2018 19:48:09 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Takeshi Takahashi <takeshi_takahashi@nict.go.jp>
To: <secdir@ietf.org>
Cc: draft-ietf-stir-passport-shaken.all@ietf.org, stir@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.87.3
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154121328916.19556.15556330091107353459@ietfa.amsl.com>
Date: Fri, 02 Nov 2018 19:48:09 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/KKu8w0zPT5extnKqAdg8eiAKgMI>
Subject: [secdir] Secdir last call review of draft-ietf-stir-passport-shaken-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Nov 2018 02:48:10 -0000

Reviewer: Takeshi Takahashi
Review result: Ready

I do not have any particular concerns on the Security Considerations section.
As mentioned in the section, the proposed extension will not pose any
particular threats to the base specification.

Having said that, I have minor comments and clarification questions as an
individual who has read this document without prior knowledge of this topic.

1. In the abstract,

The sentence "from ATIS .... Joint Task Force" will not be neceaary.
For those who are familiar with SHAKEN specification, this sentence is obvious.
For those who are not familiar with SHAKEN, this sentence will not provide any
information that may facilitate the understanding of the overview of the draft.
In either cases, the sentence will not be necessary.

"to include information defined as part of ..." had better be refined further.
I believe the readers wish to know the details (incl., types) of the
information instead of where the specification was once defined.

2. In the abstract and/or introduction,

STIR should be spelled out. I guess it is Secure Telephony Identity Revisited.

3. Terminology

I feel that you use the terms "claims" and "indicators" for pointing to the
same objects. If that's the case, I hope you could choose to use only one of
them.

Example of the use of two terminologies.
1. In the introduction, you have the sentence "This document specifies these
indicators...". 2. In the introduction, you have the sentence "there are two
additional claims..." 3. The title of section 4 is "Passport attest claim". and
so on.

4. In section 5 "PASSporT origid claim",

There is a sentence "There will likely be best practices documents that more
precisely guide it's usage in real deployments". If you have such a document
(including work-in-progress drafts), having a reference to this sentence will
be appreciated. If there is no reference, I do not think we need this sentence
here.

5. orig and origid claims
If I understood correctly, both orig and origid represent identifies the same
objects (including service provider-initiated calls, customers, classes of
devices, etc.) In this case, if the object identified by orig and the one
identified by origid is not the same, how should the receiver interpret these
claims?

6. section 7
I am a bit confused. If the use of "attest" and "origid" is already defined
elsewhere, what does this document define? Is the document define the use of
those claims for some other protols (other than SIP)?

7. security consideration.

As mentioned in this section, the values of the new "attest" and "origid"
claims added by this extension are not used in the current validation step.
Then, do you think we should encourage people to have another step that
validates those claims added by this extension?

I would appreciate your answers on these issues.