Re: [secdir] sector review of draft-ietf-jose-jwk-thumbprint-05

"Adam W. Montville" <adam.w.montville@gmail.com> Thu, 25 June 2015 21:32 UTC

Return-Path: <adam.w.montville@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68BBC1B2AD6; Thu, 25 Jun 2015 14:32:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iQPuClLLesCO; Thu, 25 Jun 2015 14:32:42 -0700 (PDT)
Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0A001B2AD5; Thu, 25 Jun 2015 14:32:40 -0700 (PDT)
Received: by oiyy130 with SMTP id y130so62359993oiy.0; Thu, 25 Jun 2015 14:32:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=BdMAo/4bHPA5hv4im1Whn46alznssKmPZh+sWYUMV2I=; b=ieYAtTXwgQIStnfSu6DVp1XYMczgPYLGC7QS9qZAuwAmufajlS0PylIWWSpCMKMVm+ lmhNtVu+3QxXYy4LUJPwa5oXDZqBA3cLDvozoi+YXAskZGSlfi4KnJgAhLjgfDPlFdX1 Uya7uZ2dW33WdK2bVOM8+cLmUh2tjkEPRfMkWuWVSraf4UjpmibC+BJC8WeqIzv3uRy6 QDREm3PMzi7eYJSg7oLDCsIpje/HL3ti5mk/Yz3swWpw3tHso866IaCoXm66IWcNdKx5 8oMntZt1pIDgIPsTiXYVUVILiF+Dd/ciVilF05NJdCDvAeWIK3hRP3eSdmVSQuIYSgn5 hwxQ==
X-Received: by 10.202.187.138 with SMTP id l132mr39046779oif.31.1435267960384; Thu, 25 Jun 2015 14:32:40 -0700 (PDT)
Received: from adams-mac-mini.attlocal.net (99-64-100-131.lightspeed.austtx.sbcglobal.net. [99.64.100.131]) by mx.google.com with ESMTPSA id ej6sm4679724obb.2.2015.06.25.14.32.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jun 2015 14:32:39 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_2732D2AA-8F6B-49ED-8829-8599B3C5D6F1"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
From: "Adam W. Montville" <adam.w.montville@gmail.com>
In-Reply-To: <BY2PR03MB4421B3C0A9973108C1F7B6AF5AF0@BY2PR03MB442.namprd03.prod.outlook.com>
Date: Thu, 25 Jun 2015 16:32:38 -0500
Message-Id: <13E52A73-7D81-458E-880F-890809BBBC03@gmail.com>
References: <A1BD2DB0-A7D9-4635-8A3B-074303AF2E55@gmail.com> <BY2PR03MB442BD780448D808BA10D657F5BC0@BY2PR03MB442.namprd03.prod.outlook.com> <4CA0A65D-E5FD-408C-A6B9-6ECB12A81B7C@gmail.com> <BY2PR03MB44292335834F3354309E062F5A10@BY2PR03MB442.namprd03.prod.outlook.com> <E56D5AB3-AEA0-4E49-BADD-D7F86AA0BAFB@gmail.com> <BY2PR03MB44275C31276DFF36611D67DF5AF0@BY2PR03MB442.namprd03.prod.outlook.com> <C123F274-D6EA-4072-AE9C-5E6E11065C4E@gmail.com> <BY2PR03MB4421B3C0A9973108C1F7B6AF5AF0@BY2PR03MB442.namprd03.prod.outlook.com>
To: Mike Jones <Michael.Jones@microsoft.com>
X-Mailer: Apple Mail (2.2098)
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/LYx7Ehsm1ftkSwcvwKx7Mq7k36Q>
Cc: "draft-ietf-jose-jwk-thumbprint.all@ietf.org" <draft-ietf-jose-jwk-thumbprint.all@ietf.org>, The IESG <iesg@ietf.org>, "jose@ietf.org" <jose@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [secdir] sector review of draft-ietf-jose-jwk-thumbprint-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 21:32:45 -0000

I haven’t an objection to the paragraph as worded, so it works for me.  Should have made that clear before - sorry.


> On Jun 24, 2015, at 12:49 PM, Mike Jones <Michael.Jones@microsoft.com>; wrote:
> 
> Hi Adam,
>  
> I take your point that the paragraph would seem simpler without the last sentence, but I’d rather err on the side of giving readers more information than less.  While in many cases knowledge of the hash function used need not be propagated (per the example in the beginning of the paragraph), sometimes it does.  So Nat and I decided to also include a sentence about when it does.  Per the previous paragraph, which hash function to use is an application choice.
>  
> From that viewpoint, does the current paragraph work for you, or is there a specific wording change that you’d still like to see?
>  
> Thanks again for your review!
>  
>                                                             -- Mike
>  
> From: Adam W. Montville [mailto:adam.w.montville@gmail.com] 
> Sent: Wednesday, June 24, 2015 5:12 AM
> To: Mike Jones
> Cc: The IESG; secdir@ietf.org; draft-ietf-jose-jwk-thumbprint.all@ietf.org; jose@ietf.org
> Subject: Re: sector review of draft-ietf-jose-jwk-thumbprint-05
>  
> Hi Nat and Mike,
>  
> Thanks for your attention on this issue.  I see the following text in section 3.4:
>  
> Note that in many cases, only the party that creates a key will need
>    to know the hash function used.  A typical usage is for the producer
>    of the key to use the base64url-encoded JWK Thumbprint value as a
>    "kid" (key ID) value.  The consumer of the "kid" treats it as an
>    opaque value that it uses to select the key.  Only if multiple
>    parties will be reproducing the JWK Thumbprint calculation for some
>    reason, will parties other than the original producer of the JWK
>    Thumbprint need to know which hash function was used.
>  
>  
> Would it make the draft clearer if that last sentence were omitted?  The way this paragraph reads is such that draft considers and would allow for multiple parties generating key IDs, but then we’re back at not knowing which algorithm was chosen.  If that last sentence were omitted, this would be less of an issue.  
>  
>  
> On Jun 24, 2015, at 3:40 AM, Mike Jones <Michael.Jones@microsoft.com <mailto:Michael.Jones@microsoft.com>> wrote:
>  
> Hi Adam,
>  
> Thanks again for your review comments.  https://tools.ietf.org/html/draft-ietf-jose-jwk-thumbprint-06 <https://tools.ietf.org/html/draft-ietf-jose-jwk-thumbprint-06> has been posted to address them.  See sections 3.4 (Selection of Hash Function) and 6 (IANA Considerations).
>  
>                                                             Thanks again,
>                                                             -- Nat and Mike
>  
> From: Kathleen Moriarty [mailto:kathleen.moriarty.ietf@gmail.com <mailto:kathleen.moriarty.ietf@gmail.com>] 
> Sent: Monday, June 22, 2015 12:51 PM
> To: Mike Jones
> Cc: Adam W. Montville; The IESG; secdir@ietf.org <mailto:secdir@ietf.org>; draft-ietf-jose-jwk-thumbprint.all@ietf.org <mailto:draft-ietf-jose-jwk-thumbprint.all@ietf.org>; jose@ietf.org <mailto:jose@ietf.org>
> Subject: Re: sector review of draft-ietf-jose-jwk-thumbprint-05
>  
> Yes, thank you.
> Kathleen 
> 
> Sent from my iPhone
> 
> On Jun 22, 2015, at 9:18 PM, Mike Jones <Michael.Jones@microsoft.com <mailto:Michael.Jones@microsoft.com>> wrote:
> 
> I’d be glad to add the explanation below to the draft and to also include an IANA considerations section that states we are updating the expert review instructions for a registry, as Jim Schaad had suggested.  Chairs and Kathleen, do you want Nat and I to proceed to publish an updated draft?
>  
>                                                                 -- Mike
>  
> From: Adam W. Montville [mailto:adam.w.montville@gmail.com <mailto:adam.w.montville@gmail.com>] 
> Sent: Friday, June 12, 2015 5:07 AM
> To: Mike Jones
> Cc: The IESG; secdir@ietf.org <mailto:secdir@ietf.org>; draft-ietf-jose-jwk-thumbprint.all@ietf.org <mailto:draft-ietf-jose-jwk-thumbprint.all@ietf.org>; jose@ietf.org <mailto:jose@ietf.org>
> Subject: Re: sector review of draft-ietf-jose-jwk-thumbprint-05
>  
>  
> On Jun 11, 2015, at 4:25 PM, Mike Jones <Michael.Jones@microsoft.com <mailto:Michael.Jones@microsoft.com>> wrote:
>  
> Hi Adam,
> 
> Thanks for the secdir review.
> 
> 
> 
> 
> From: Adam W. Montville [mailto:adam.w.montville@gmail.com <mailto:adam.w.montville@gmail.com>]
> Sent: Monday, June 08, 2015 8:46 AM
> To: The IESG; secdir@ietf.org <mailto:secdir@ietf.org>; draft-ietf-jose-jwk-thumbprint.all@ietf.org <mailto:draft-ietf-jose-jwk-thumbprint.all@ietf.org>
> Subject: sector review of draft-ietf-jose-jwk-thumbprint-05
> 
> 
> 
> 
> Hi,
> 
> 
> 
> 
> I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments.
> 
> I believe the document is ready with (potential) issues.  The “with issues” might be due to ignorance on my part.  The draft does a very good job of explaining the canonical form of a JSON Web Key that can be used for establishing a thumbprint under varying circumstances, complete with what I found to be helpful examples.
> 
> The primary issue I have is that it’s unclear how relying parties are going to know which hash algorithm has been used.  The examples use SHA-256, but I’m not seeing where SHA-256 might be specified as a MUST or even a SHOULD.  Moreover, the example output ultimately shows only the Base-64 encoding of the resulting hash, which says nothing about the algorithm used to identify a key.
> 
> Earlier drafts had included fields whose names were intended to communicate the information about the hash function used - see the "jkt" field definitions in http://tools.ietf.org/html/draft-ietf-jose-jwk-thumbprint-01#section-4 <http://tools.ietf.org/html/draft-ietf-jose-jwk-thumbprint-01#section-4> - but several working group reviewers suggested that these fields were unnecessary and that the typical usage would be as "kid" (key ID) field values.  With that removal, it falls onto the application to specify the hash algorithm for its particular usage.
> 
> This isn't as bad as you might think, however, because typically the consumer of the "kid" doesn't need to know the algorithm because it won't be reproducing the computation.  It just relies on the fact that a unique key ID value was generated for the key and compares "kid" values as opaque strings to find the appropriate key.  In this usage, the producer of the key is the only party that needs to know the hash algorithm that it is using.  I hope this helps.
>  
> Yes, this does help, thank you.  It seems like something that could be easily added to the draft to explain why the generating algorithm needn’t be disclosed so that slow folk like myself get the picture straight away.
>  
> 
> 
> 
> 
> 
> 
> 
> 
> Additionally, in Section 4, “JSON and Unicode Considerations” some “should”s are used, but I’m not reading them as SHOULDs. Should they be SHOULDs?  For example, the start of the third paragraph in that section: “if new JWK members are defined that use non-ASCII member names, their definitions should specify the exact Unicode code point sequences used to represent them.”  It’s not clear to me whether this is a strong statement or just a recommendation - it seems that this draft could help the future by making stronger statements to encourage future interoperability.
> 
> For the other JOSE specifications, our chair Jim Schaad took the position that RFC 2119 keywords should be reserved for testable protocol behaviors and that other uses of the English word "should" should not use "SHOULD".  The authors followed that convention in this document.  I do understand that other authors and working groups have taken different positions in this regard.  If there are particular uses that you still feel should be changed to use RFC 2119 keywords, please call them out.
>  
> This is all good, too.  I was simply pointing out that there are “should”s around that may need to be considered as “SHOULD”s. I also see Jim’s (and others’) subsequent notes on the subject, so this is good from my perspective.
> 
> 
> 
> 
> 
> 
> 
> 
> Kind regards,
> Adam
> 
>                                                                 Thanks again!
>                                                                 -- Mike