[secdir] Review of draft-ietf-curdle-pkix-06

Shawn Emery <shawn.emery@gmail.com> Wed, 18 October 2017 06:30 UTC

Return-Path: <shawn.emery@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20B21133039 for <secdir@ietfa.amsl.com>; Tue, 17 Oct 2017 23:30:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lJObbiKdU01S for <secdir@ietfa.amsl.com>; Tue, 17 Oct 2017 23:30:20 -0700 (PDT)
Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 80A06132D17 for <secdir@ietf.org>; Tue, 17 Oct 2017 23:30:20 -0700 (PDT)
Received: by mail-io0-x22f.google.com with SMTP id h70so4826133ioi.4 for <secdir@ietf.org>; Tue, 17 Oct 2017 23:30:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=b1I3W7hD3xGNy8JJuTTPULhk/7welDMQoM536eiXfSE=; b=njoGo3PYxBSFjfbjrOhpomOwNQmLsE87CFmjHLV3cibP9TH+jydn8hsq0/aRFZ2ndV 15c51cLMzNTtGZH8gwbFMvQyt6Y/0eimrg7wzxdiQAdStflNakb4HR3/uVdkbyYKk3rX EvChTE1ufhY7xnqI0TuGQKgy8r18hdLP7MNW0atCyo/yCj+ABm8bXzjpTKv5Ebvv36LS +OCggsmPV2uTU7PNrshd/J/MlT30BOerD2NmeF3lqpHDnvElVhz/meuvNL89BO18rUcX ZVYKMtOunC90AEAYRxAgrjmZuGKhPTfFHrtxMHr9UVdGYlpq2hKK9wea8O/kAtUDhjAo gcdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=b1I3W7hD3xGNy8JJuTTPULhk/7welDMQoM536eiXfSE=; b=THs4VNlpc6R3ZsWrnC7eswFN8nU3W1dozXuRQRl0gmS6GfL+CciYOkJY//hn4Py+8O PWpaSjU692TOuGFH0TwGuGbqVbbI/WfkE0em1C5v/FgWKWeQz7XXmjEQXNPSuJwqOBWo BACCb/VlSqjaeQH88XXgtupCjkRddRCcvrbBp9lShur7StffoEURxR1lzAXi0u64MGof 5dex3KHP4OdswOm4bEKR8WYkUKi5JRLLjmzDKIScW5nMW28TC/MQjxClatqW3xr0+L/A dzC0O6CFvkOzuON9VRYlity2VxhON5i7qb6vFVPMOi82t7ZL+mpvmiwYMrOPxSQv5JL9 VmbQ==
X-Gm-Message-State: AMCzsaX4BjwUzw3F19SAtKNc7vSTWKiqfnCsdIciOfVZWo7rL+BqoIzZ sI1N+CI6iP1yITKlCLYVMgAiCXd5+XCdx68eZC7Sc/+g
X-Google-Smtp-Source: AOwi7QC5fsRUiRON41U6MVYLf6WrmDRDUkr1Bx5FuMJ98sJ1sYbWI8Mab+rc/Ua8mupWWAcybJQ3THo8wBrX4EwR5Zw=
X-Received: by 10.107.47.159 with SMTP id v31mr20052884iov.102.1508308219492; Tue, 17 Oct 2017 23:30:19 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.2.180.18 with HTTP; Tue, 17 Oct 2017 23:30:19 -0700 (PDT)
From: Shawn Emery <shawn.emery@gmail.com>
Date: Wed, 18 Oct 2017 00:30:19 -0600
Message-ID: <CAChzXmbd7jTr1uWNPW2jBWPDn7J5ebAmCGZWEbWE8C0ziSVctA@mail.gmail.com>
To: secdir@ietf.org, draft-ietf-curdle-pkix.all@tools.ietf.org
Content-Type: multipart/alternative; boundary="001a11c158b8a2806a055bcc5f73"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/MJDswvINXvTCbnNawDanYB-FDiY>
Subject: [secdir] Review of draft-ietf-curdle-pkix-06
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Oct 2017 06:30:22 -0000

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the IESG.
These comments were written primarily for the benefit of the security
area directors. Document editors and WG chairs should treat these
comments just like any other last call comments.

This draft specifies ASN.1 structures, consisting of algorithm identifiers,
parameters, public, private keys, and signatures, for Curve25519 and
Curve448 curves.

The security considerations section does exist and refers to RFC 5280
<https://tools.ietf.org/html/rfc5280>;, 7748
<https://tools.ietf.org/html/rfc7748>;, and 8032
<https://tools.ietf.org/html/rfc8032> for relevancy.  The section adds that
the same public key can not be used for ECDH and EdDSA.  I don't see how
this specifically relates to the ASN specification for Curve25519 and
Curve448, but since these are two procedures related to this draft, I can
see why this paragraph may exist.

General comments:

None.

Editorial comments:

For the public key field the document specifies:

subjectPublicKey BIT STRING

Shouldn't this be OCTET STRING?  The same for signatureValue.

s/algorithms need have/algorithms need to have/
s/cross-implementation naming this/cross-implementation naming, this/

OLD

   Asymmetric Key Packages [RFC5958
<https://tools.ietf.org/html/rfc5958>] describes how encode a private
key
   in a structure that both identifies what algorithm the private key is
   for, but allows for the public key and additional attributes about

       the key to be included as well.

NEW

   Asymmetric Key Packages [RFC5958
<https://tools.ietf.org/html/rfc5958>] describes how to encode a
private key
   in a structure that both identifies what algorithm the private key is
   for, but allows for the public key and additional attributes of

       the key to be included as well.

Shawn.
--