Re: [secdir] secdir review of draft-harkins-emu-eap-pwd-04.txt

"Dan Harkins" <dharkins@lounge.org> Thu, 23 July 2009 19:10 UTC

Return-Path: <dharkins@lounge.org>
X-Original-To: secdir@core3.amsl.com
Delivered-To: secdir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id DC8B33A688A; Thu, 23 Jul 2009 12:10:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.611
X-Spam-Level:
X-Spam-Status: No, score=-5.611 tagged_above=-999 required=5 tests=[AWL=0.054, BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334, J_CHICKENPOX_33=0.6, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JjxZiCReKX39; Thu, 23 Jul 2009 12:10:38 -0700 (PDT)
Received: from colo.trepanning.net (colo.trepanning.net [69.55.226.174]) by core3.amsl.com (Postfix) with ESMTP id 1800F3A69C5; Thu, 23 Jul 2009 12:10:38 -0700 (PDT)
Received: from www.trepanning.net (localhost [127.0.0.1]) by colo.trepanning.net (Postfix) with ESMTP id AABF810224074; Thu, 23 Jul 2009 12:09:05 -0700 (PDT)
Received: from 216.31.249.246 (SquirrelMail authenticated user dharkins@lounge.org) by www.trepanning.net with HTTP; Thu, 23 Jul 2009 12:09:05 -0700 (PDT)
Message-ID: <f766fe7f153098c7ab6e7791586255f4.squirrel@www.trepanning.net>
In-Reply-To: <20090722155546.GA6013@elstar.local>
References: <20090722155546.GA6013@elstar.local>
Date: Thu, 23 Jul 2009 12:09:05 -0700
From: Dan Harkins <dharkins@lounge.org>
To: dharkins@arubanetworks.com, gwz@netcube.com, iesg@ietf.org, secdir@ietf.org
User-Agent: SquirrelMail/1.4.14 [SVN]
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
Subject: Re: [secdir] secdir review of draft-harkins-emu-eap-pwd-04.txt
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2009 19:10:39 -0000

  Hi Juergen,

  Thank you for your review of our draft and your helpful suggestions
for improving it. I am in the process of editing the draft to incorporate
other Last Call comments and will include your comments as well.

  regards,

  Dan.

On Wed, July 22, 2009 8:55 am, Juergen Schoenwaelder wrote:
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written primarily for the benefit of the
> security area directors.  Document editors and WG chairs should treat
> these comments just like any other last call comments.
>
> The draft defines an EAP authentication method using a password.  Not
> being a cryptography expert, I reviewed the document form the
> perspective of an informed outsider but I did not try to verify
> whether the cryptographic claims are all correct. That said, I found
> the document well written and the security discussion convincing.
>
> Editorial nits:
>
> a) On page 6, you use the acronym PRF and it will help readability if
>    you spell it out here since it has not been introduced yet:
>
>    s/and a PRF/and a pseudo-random function PRF/
>
> b) In figure 1, you could replace
>
>                   res = PRF(key, i | label | L)
>                   K(1) = res
>    with
>                   K(1) = PRF(key, i | label | L)
>                   res = K(1)
>
>    since this makes the assignments before the loop and in the loop
>    body symmetric and thus perhaps things easier to read.
>
> c) There are two places where IANA assigned values need to be filled
>    into the text; perhaps add more explicit RFC editor instructions so
>    the editor knows what to fill in for 'TBD1'.
>
> d) s/DIffie-/Diffie-/
>
> e) You may want to complete reference [BMP00] - the proceedings were
>    published by Springer-Verlag in LNCS 1807.
>
> /js
>
> --
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1, 28759 Bremen, Germany
> Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>
> _______________________________________________
> secdir mailing list
> secdir@ietf.org
> https://www.ietf.org/mailman/listinfo/secdir
>