[secdir] SECDIR Last Call review of draft-ietf-lamps-rfc8708bis-01

Donald Eastlake <d3e3e3@gmail.com> Tue, 13 August 2024 11:40 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C7CBC17C8B3; Tue, 13 Aug 2024 04:40:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.858
X-Spam-Level:
X-Spam-Status: No, score=-1.858 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ewy71x00ffHD; Tue, 13 Aug 2024 04:40:21 -0700 (PDT)
Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A0C8EC180B4D; Tue, 13 Aug 2024 04:40:21 -0700 (PDT)
Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3db1d0fca58so3572995b6e.3; Tue, 13 Aug 2024 04:40:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723549217; x=1724154017; darn=ietf.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=uBGCZwdGLvUBckVOtfgvmbQ5IjuW3dm44l+YKehwoz8=; b=dgwYi/socjYZMC4NTmqI5crCO1KakC1qDURnaRhI68lui8/n1CCKDFV/dAc14RNd8l MT/TQrFJ6qR8kSlQm9OoUbIt5ft8fWsBWCSbUa6vIDNvQd+pzggFmWuKpTTtyy6unyWf H/W+wf7+ikqEv0dNCDjEysHYaYe+Jtc0ahDnx7/MMP3TF3+4GnyZ4QQ612ECJkvUa0Q9 CiLLxbdDAVnNQfU3MZ9YfTS/C6pglnfD4pVYzEjfV7Cx5skrZMlO8Tqxcj0B2Fnil9HH ZXPRQZssnqGUXj8DgsFiwusc3MvWNMBmCR8vOUTreHW8To9uTBr5pr91595dQR/H93Ji LLyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723549217; x=1724154017; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uBGCZwdGLvUBckVOtfgvmbQ5IjuW3dm44l+YKehwoz8=; b=MO3lWIa0GNLPO0xP+xx6XdFTRLRfmXldRUaumtOAgTH5M0pBXlUkMo5JdqLemO4HVw Zcu68n5JIgwGxhtxcFmUMGcLGzYqbGrUzn7+62i1cRWDAXeRcJTUoXLdw4Ta0l23UM/X AwkLyI5I4lHVtXmIY9bEfb7uDyNsaxrX939Cee7rTa2RcX2xvuFXF+9knOm23euuAmwX miAcG01ZOX0bHGPeXMV6sHrRJv8yHTm6SXpACgaLoo/wv8xHQKOHr4SsqXhc4mR/X1gN 3RdH8Wp4hABBaSKcg2vej/7xvn54wmPJ+RMiwGmFfn/J4oOsYEJnGvMRKYD5hdpuxNwB wrIQ==
X-Forwarded-Encrypted: i=1; AJvYcCU6h6cJ8Ttbzs1WpjWaDhcnf2ZTHertdfL5JU81cEnMycjpBDd9qqkdhuD1r+gRMhPgCLGZEb6sXNOQMD89W/7UhMwlZb1kIj6W1hdXy8k1BxrQvhoHUlLs6HTgvwlHfBnShzoVrVBnP5EmTqI=
X-Gm-Message-State: AOJu0YyW/DI8mBz6IcEjB5tXwkjFj0nOFeKrqrzovg7QrGkrapcbUIaX LxVrREFopkkYMhLudJ+71b1aws+L0PmeFo0T3rgEZ/qItZOsUmLexLDlt3gy2w44AAiSqrNd+mH Bw8o5+vluAMZmGG6z9EOzCuz4mf8WkjcW
X-Google-Smtp-Source: AGHT+IE+QpSmtdh+A7kbRzTM/oWoshMGgVWQMcrfD6nf4MQETvi5PHFaPNsQGVxmHlynvHDaq3dJG1BTn8BMkjJ0jNI=
X-Received: by 2002:a05:6808:3193:b0:3d9:3649:9087 with SMTP id 5614622812f47-3dd1efebe87mr3870823b6e.41.1723549216824; Tue, 13 Aug 2024 04:40:16 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 13 Aug 2024 07:39:56 -0400
Message-ID: <CAF4+nEEn12BDAjFQ88t-6PL9m5d93M7HhPLC3iyp+Lbkfv3vig@mail.gmail.com>
To: "iesg@ietf.org" <iesg@ietf.org>, draft-ietf-lamps-rfc8708bis.all@ietf.org
Content-Type: text/plain; charset="UTF-8"
Message-ID-Hash: FYBWD7WHXXFG3R5YR5H7CBPGQZG25BKG
X-Message-ID-Hash: FYBWD7WHXXFG3R5YR5H7CBPGQZG25BKG
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: secdir <secdir@ietf.org>, Last Call <last-call@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [secdir] SECDIR Last Call review of draft-ietf-lamps-rfc8708bis-01
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/OI162k-6lrIUWtFkSpHgSpKPNxU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG. Document editors and WG chairs should treat these comments just
like any other last call comments.

The summary of the review is Ready with Nits.

This document specifies the conventions for using the Hierarchical
Signature System (HSS) / Leighton-Micali Signature (LMS) hash-based
signature algorithm with the Cryptographic Message Syntax (CMS) and
provides the algorithm identifier and public key syntax.

All my comments below are minor to very minor.

Section 6, Security Considerations, 1st paragraph. Why is it that
compromise of the private keys only "may" lead to the ability to
forge? "May" seems right for something like "result in forged
signatures" but doesn't compromise of the private key lead pretty
certainly to the *ability* to forge a signature?
Somehow the presence of "non-volatile" is a bit jarring. I understand
that you are talking about exceptional problems but perhaps it would
be good to also say the "volatile" storage must not be used?

Section 1.3, 3rd paragraph: Would it be reasonable to add just before
the comma in the first sentence "but on the difficulty of finding
pre-images of a strong hash function" or something like that? While I
believe it, is there a reference for the "considered to be
post-quantum secure" statement?

Section 2.1, last sentence: While it is somewhat a matter of taste,
arguably, except in the most surprising cases, the words "Note that"
are mostly superfluous noise. (Ditto for two more "Note that"s in
Section 4.)

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com