IETF Logo Mail Archive

Re: [secdir] Secdir last call review of draft-ietf-lsr-ip-flexalgo-11

Yoav Nir <ynir.ietf@gmail.com> Wed, 17 May 2023 20:01 UTC

Return-Path: <ynir.ietf@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86E2CC14F75F; Wed, 17 May 2023 13:01:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sz90p_bfQoAS; Wed, 17 May 2023 13:01:16 -0700 (PDT)
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 41D56C14CEF9; Wed, 17 May 2023 13:01:13 -0700 (PDT)
Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3090408e09bso831852f8f.2; Wed, 17 May 2023 13:01:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684353671; x=1686945671; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=37S+BE7tF0ML0b6OdACboKBnjhQ0sUGsuLGz5OsHBBc=; b=pmj/JdTRh434CGJXDY5RP9L/R4VBna60wwbPWojXT9rZtABjeAYfqHOW5FoGTvOKDq 1r/9h8FvmihorGfMN9ggXYEAHaa5xdpZGuDlRs9hgtYPUlReBfmw0p7HPsgpE9w51NND HbROZWGntFO3+pJW2ECk2E33n41unqtg4rEnqmex8cpJnoHUvOvHkOhUpdc4JAd0MMyt i6p60JVoc9zlglp8qAUm7MVJ/9VmIkMdUIFGuveG0YV9gfRKLJguyK6/0TjWQbAkx4sY hJ4lj+Fbqe8hjLVdsDPaDj+3h+qLeLtdhhNYEtH2ypm/ig22nOc7xqt92oGSd97g0KKR AhFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684353671; x=1686945671; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=37S+BE7tF0ML0b6OdACboKBnjhQ0sUGsuLGz5OsHBBc=; b=jw908E2AS5dvbVTsQkCly7xTru8MlYv2zZ09Tm84sFDmufFKbar4R3++ensPqvdlUg +Z2H1v3gF1OiRkTM75tz3IZDRIoYm4deMgJZek/Xr00BPGaIC4N1yAOfp/39PnBQt6iZ xlGZXVAEzAKeCdlmUNdlVyJme752114tVjoY/tAD3sILEkdvngMJVG7QmF4YZ4uxTm1S C1KbmPDPn+fD7fPSjbZMSUxB7cI7PKkpRcs0xeNsMTYXJYOdbszPFm7C5MeIfgdf9swJ tUkHARTnfThBPEkifRJ52oWnzRPQoMN7ZnhCbotGrHalUeBDsZpbpvk18DRJz7l8Wkq/ 9OMg==
X-Gm-Message-State: AC+VfDydbNmGcEIQa6kd1uAuvXRqwP4Snm3P+dg4f1jB5f63caXA93z+ QuoLHtoWqghU+w/ud6mh4Rc=
X-Google-Smtp-Source: ACHHUZ7vjmHr7CTjFDORec+GmuGteQipxIrBfq4AmsDlYw/2NNoT/5Pa5i1ASYcvLfF3pQBX242UNQ==
X-Received: by 2002:adf:ea44:0:b0:309:4227:829c with SMTP id j4-20020adfea44000000b003094227829cmr1510849wrn.36.1684353671368; Wed, 17 May 2023 13:01:11 -0700 (PDT)
Received: from smtpclient.apple (84.94.37.215.cable.012.net.il. [84.94.37.215]) by smtp.gmail.com with ESMTPSA id o8-20020a5d4088000000b0030647d1f34bsm3744246wrp.1.2023.05.17.13.01.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2023 13:01:10 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
From: Yoav Nir <ynir.ietf@gmail.com>
In-Reply-To: <9c32dbf9-52fa-75e5-f1c8-62dc3cc05b9b@cisco.com>
Date: Wed, 17 May 2023 23:00:58 +0300
Cc: secdir <secdir@ietf.org>, draft-ietf-lsr-ip-flexalgo.all@ietf.org, last-call@ietf.org, lsr@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E3B4C47F-76D1-45C2-8035-2E041D3572F5@gmail.com>
References: <168417940610.53793.18295304184728744557@ietfa.amsl.com> <9c32dbf9-52fa-75e5-f1c8-62dc3cc05b9b@cisco.com>
To: Peter Psenak <ppsenak@cisco.com>
X-Mailer: Apple Mail (2.3731.200.110.1.12)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/PhZOSXa2jSZP3jbUIwvEHXvj0PM>
Subject: Re: [secdir] Secdir last call review of draft-ietf-lsr-ip-flexalgo-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 May 2023 20:01:18 -0000


> On 16 May 2023, at 10:25, Peter Psenak <ppsenak@cisco.com> wrote:
> 
> Yoav,
> 
> thanks for comments, please see inline:
> 
> 
> On 15/05/2023 21:36, Yoav Nir via Datatracker wrote:
>> Reviewer: Yoav Nir
>> Review result: Has Nits
>> Hi.
>> I have reviewed this document as part of the security directorate's
>> ongoing effort to review all IETF documents being processed by the
>> IESG. These comments were written primarily for the benefit of the
>> security area directors. Document editors and WG chairs should treat
>> these comments just like any other last call comments.
>> I am no expert on routing in general or IGP flex algorithms in particular. That
>> said, I found the Abstract and Introduction jarring. The first paragraph of the
>> Abstract would be better as part of the introduction than the abstract.
> 
> I moved the first paragraph from Abstract to Introduction.

Sounds good.

> 
>> The Security Considerations section seems mostly copy-pasted from RFC 9350 with
>> mild editing.  The substance may be correct - that the only new attack possible
>> is suppressing reachability for a prefix, but I think only the second paragraph
>> is necessary for that.
> 
> I would prefer to keep the first paragraph.

OK.

Yoav

v2.23.0 | Report a Bug | By Email