[secdir] Secdir last call review of draft-ietf-detnet-ip-over-mpls-07

Vincent Roca via Datatracker <noreply@ietf.org> Mon, 07 September 2020 11:38 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 61C123A0C29; Mon, 7 Sep 2020 04:38:13 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Vincent Roca via Datatracker <noreply@ietf.org>
To: <secdir@ietf.org>
Cc: last-call@ietf.org, detnet@ietf.org, draft-ietf-detnet-ip-over-mpls.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.15.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159947869329.11456.14733447920077619501@ietfa.amsl.com>
Reply-To: Vincent Roca <vincent.roca@inria.fr>
Date: Mon, 07 Sep 2020 04:38:13 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/R2xqUDWqbqy4-aINpT0OURrB_Ts>
Subject: [secdir] Secdir last call review of draft-ietf-detnet-ip-over-mpls-07
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2020 11:38:14 -0000

Reviewer: Vincent Roca
Review result: Has Nits


I have reviewed this document as part of the security directorate’s ongoing
effort to review all IETF documents being processed by the IESG. These
comments were written primarily for the benefit of the security area
directors.  Document editors and WG chairs should treat these comments just
like any other last call comments.

Summary: Has Nits

I have no major concern. However I think that the Security considerations section
could and should better leverage on [I-D.ietf-detnet-security] (currently it is mainly
cited but that's all). Indeed, the [I-D.ietf-detnet-security] document is all about 
DetNet security, it introduces the problem in a clear manner, then it discusses with 
much detail both security risks and mitigation technics, providing high level synthesis
tables, and sections 9.1 and 9.2 are even dedicated to IP and MPLS DetNet security. 
This is a MUST read document that provides valuable discussion (perhaps more than
in the present document, sorry).

I also think the  [I-D.ietf-detnet-security] reference (""Deterministic Networking (DetNet)
Security Considerations") should be a Normative Reference (it's currently in the Informative
Reference list).

Minor comments:

- Section 4.1 uses the S-PE acronym when refering to the Relay Node, whereas S-PE is not 
expended in the Abbreviations list of section 2.2.

Regards,    Vincent