Re: [secdir] secdir review of draft-turner-asymmetrickeyformat-algs-01

Sean Turner <turners@ieca.com> Thu, 22 April 2010 13:57 UTC

Return-Path: <turners@ieca.com>
X-Original-To: secdir@core3.amsl.com
Delivered-To: secdir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 082A628C11C for <secdir@core3.amsl.com>; Thu, 22 Apr 2010 06:57:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.871
X-Spam-Level:
X-Spam-Status: No, score=-0.871 tagged_above=-999 required=5 tests=[AWL=-0.873, BAYES_50=0.001, UNPARSEABLE_RELAY=0.001]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id neueAty0CI59 for <secdir@core3.amsl.com>; Thu, 22 Apr 2010 06:57:50 -0700 (PDT)
Received: from smtp112.biz.mail.re2.yahoo.com (smtp112.biz.mail.re2.yahoo.com [66.196.116.97]) by core3.amsl.com (Postfix) with SMTP id 3B5183A6ABF for <secdir@ietf.org>; Thu, 22 Apr 2010 06:56:57 -0700 (PDT)
Received: (qmail 49459 invoked from network); 22 Apr 2010 13:56:47 -0000
Received: from thunderfish.local (turners@71.191.8.248 with plain) by smtp112.biz.mail.re2.yahoo.com with SMTP; 22 Apr 2010 06:56:46 -0700 PDT
X-Yahoo-SMTP: ZrP3VLSswBDL75pF8ymZHDSu9B.vcMfDPgLJ
X-YMail-OSG: OVFvGOEVM1lGQSZq1vVUmZCT_tFOad2FgrYx2EHDH3_750FpPjKd5oND
X-Yahoo-Newman-Property: ymail-3
Message-ID: <4BD0559D.2030609@ieca.com>
Date: Thu, 22 Apr 2010 09:56:45 -0400
From: Sean Turner <turners@ieca.com>
User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
MIME-Version: 1.0
To: scott@hyperthought.com
References: <1271786580.275918665@192.168.2.231>
In-Reply-To: <1271786580.275918665@192.168.2.231>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "iesg@ietf.org" <iesg@ietf.org>, draft-turner-asymmetrickeyformat-algs@tools.ietf.org, secdir@ietf.org
Subject: Re: [secdir] secdir review of draft-turner-asymmetrickeyformat-algs-01
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2010 13:57:51 -0000

scott@hyperthought.com wrote:
> I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.
> 
> This document describes conventions for crypto algorithms for use with a companion document (http://tools.ietf.org/html/draft-turner-asymmetrickeyformat-03) which is intended to replace rfc5208. 
> 
> I couldn't give this review the amount of time I would have liked to, but I hope my comments are useful nonetheless.
> 
> In section 2, it says that the de facto standard for PrivateKeyInfo encryption is Password Based Encryption using either PKCS5 or PKCS12, and that the major difference between these is the password encoding. I was surprised that no mention was made of the more robust crypto algorithms supported by PKCS12, which seems like an important consideration for this application.
> 
> Also, I was confused as to whether the draft is mixing the documentation of current practices with some recommendations, or whether it intends to specify a required usage profile. If the latter, it seems reasonable to ask why deprecated algorithms are included. If the former, maybe the document could do a better job of making this intention clear, and of demarcating which is which.

I revisited section 2 and agree.  It's not clear what the actual must
algorithms.  It's waxing poetic about PBES1.  I double checked RFC 2898
and it recommends PBES2 be used in new applications, which I think this
is one.  Further someone notes that the sip-certs ID
(http://tools.ietf.org/html/draft-ietf-sip-certs-12) wants to use a
PBES2 algorithm.  I'll work on the wording to make it clear what the
requirement is (follow what sip-certs wanted), delete the tutorial about
PBES1, and follow the recommendation from RFC 2898.

Tim's worked up an RFC editor's note to incorporate this change.

> The only other nit I had was that no mention is made of the implications of wrapping various asymmetric key sizes with potentially weaker symmetric keys/algorithms, but the security considerations section references a mighty list of related RFCs, at least one of which discusses this (RFC5649), so maybe that is good enough.

That is exactly why I included the reference to RFC 5649.

> --Scott
> 
> 
>