[secdir] SecDir review of draft-ietf-pce-vendor-constraints
Warren Kumari <warren@kumari.net> Fri, 29 November 2013 22:03 UTC
Return-Path: <warren@kumari.net>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E88B11ADEB4 for <secdir@ietfa.amsl.com>; Fri, 29 Nov 2013 14:03:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YSpmg5Oprp7x for <secdir@ietfa.amsl.com>; Fri, 29 Nov 2013 14:03:26 -0800 (PST)
Received: from vimes.kumari.net (smtp1.kumari.net [204.194.22.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB37F1ADE7C for <secdir@ietf.org>; Fri, 29 Nov 2013 14:03:26 -0800 (PST)
Received: from [192.168.0.187] (c-98-244-98-35.hsd1.va.comcast.net [98.244.98.35]) by vimes.kumari.net (Postfix) with ESMTPSA id F264E1B405AA; Fri, 29 Nov 2013 17:03:24 -0500 (EST)
From: Warren Kumari <warren@kumari.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Nov 2013 17:03:23 -0500
Message-Id: <51830795-3E6A-4386-9CE9-67B9E3874E48@kumari.net>
To: "secdir@ietf.org" <secdir@ietf.org>, draft-ietf-pce-vendor-constraints.all@tools.ietf.org
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
X-Mailer: Apple Mail (2.1510)
Subject: [secdir] SecDir review of draft-ietf-pce-vendor-constraints
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Nov 2013 22:03:28 -0000
Be ye not afraid... I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments. Summary: LGTM. Version reviewed: Conveying Vendor-Specific Constraints in the Path Computation Element communication Protocol draft-ietf-pce-vendor-constraints-11.txt Notes: I did *not* perform a formal language check. At a quick glance it looks good though. Nits: I would like to have a table of contents. This may be a personal preference though…. While performing this review I kept thinking "Mwahaha. This can be used to carry arbitrary information with any PCEP object that supports TLVs.... I can kvetch about the DoS potential". But, the authors foiled my plan to rant by mentioning this in the Security Considerations section and even mentioning a mitigation. Curses! Foiled again. W -- Outside of a dog, a book is your best friend, and inside of a dog, it's too dark to read
- [secdir] SecDir review of draft-ietf-pce-vendor-c… Warren Kumari
- Re: [secdir] SecDir review of draft-ietf-pce-vend… Adrian Farrel