Re: [secdir] SecDir review of draft-ietf-pce-vendor-constraints

"Adrian Farrel" <afarrel@juniper.net> Fri, 29 November 2013 22:24 UTC

Return-Path: <afarrel@juniper.net>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E2BF1ADFDC for <secdir@ietfa.amsl.com>; Fri, 29 Nov 2013 14:24:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.235
X-Spam-Level:
X-Spam-Status: No, score=-1.235 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_SOFTFAIL=0.665] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TL3KgOeBRGSG for <secdir@ietfa.amsl.com>; Fri, 29 Nov 2013 14:24:45 -0800 (PST)
Received: from asmtp1.iomartmail.com (asmtp1.iomartmail.com [62.128.201.248]) by ietfa.amsl.com (Postfix) with ESMTP id 9F5EF1ADF71 for <secdir@ietf.org>; Fri, 29 Nov 2013 14:24:45 -0800 (PST)
Received: from asmtp1.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id rATMOgeA028665; Fri, 29 Nov 2013 22:24:42 GMT
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id rATMOfZI028642 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 29 Nov 2013 22:24:41 GMT
From: Adrian Farrel <afarrel@juniper.net>
To: 'Warren Kumari' <warren@kumari.net>
References: <51830795-3E6A-4386-9CE9-67B9E3874E48@kumari.net>
In-Reply-To: <51830795-3E6A-4386-9CE9-67B9E3874E48@kumari.net>
Date: Fri, 29 Nov 2013 22:24:41 -0000
Message-ID: <0a1201ceed51$ccf31660$66d94320$@juniper.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFew8/4vHFrwArBIhpZzB1BHo0aP5sdGtnA
Content-Language: en-gb
Cc: draft-ietf-pce-vendor-constraints.all@tools.ietf.org, secdir@ietf.org
Subject: Re: [secdir] SecDir review of draft-ietf-pce-vendor-constraints
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: afarrel@juniper.net
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Nov 2013 22:24:47 -0000

Thanks Warren,

Sorry to have disappointed you.

Adrian

> -----Original Message-----
> From: Warren Kumari [mailto:warren@kumari.net]
> Sent: 29 November 2013 22:03
> To: secdir@ietf.org; draft-ietf-pce-vendor-constraints.all@tools.ietf.org
> Cc: Warren Kumari
> Subject: SecDir review of draft-ietf-pce-vendor-constraints
> 
> Be ye not afraid...
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written primarily for the benefit of the
> security area directors.  Document editors and WG chairs should treat
> these comments just like any other last call comments.
> 
> Summary: LGTM.
> 
> Version reviewed:
> Conveying Vendor-Specific Constraints in the Path Computation
> Element communication Protocol
> draft-ietf-pce-vendor-constraints-11.txt
> 
> 
> Notes: I did *not* perform a formal language check. At a quick glance it looks
> good though.
> 
> Nits: I would like to have a table of contents. This may be a personal
preference
> though..
> 
> While performing this review I kept thinking "Mwahaha. This can be used to
carry
> arbitrary information with any PCEP object that supports TLVs....  I can
kvetch
> about the
> DoS potential". But, the authors foiled my plan to rant by mentioning this in
the
> Security Considerations section and even mentioning a mitigation.
> Curses! Foiled again.
> 
> W
> 
> 
> 
> 
> --
> Outside of a dog, a book is your best friend, and inside of a dog, it's too
dark to
> read