IETF Logo Mail Archive

[secdir] Re: Secdir last call review of draft-ietf-idr-bgp-sendholdtimer-13

Job Snijders <job@fastly.com> Mon, 29 July 2024 10:25 UTC

Return-Path: <job@fastly.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 69286C151075 for <secdir@ietfa.amsl.com>; Mon, 29 Jul 2024 03:25:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.103
X-Spam-Level:
X-Spam-Status: No, score=-2.103 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qbr4luenXKJE for <secdir@ietfa.amsl.com>; Mon, 29 Jul 2024 03:25:30 -0700 (PDT)
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2D7FC14F70A for <secdir@ietf.org>; Mon, 29 Jul 2024 03:25:30 -0700 (PDT)
Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2f040733086so35872791fa.1 for <secdir@ietf.org>; Mon, 29 Jul 2024 03:25:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1722248728; x=1722853528; darn=ietf.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gXMMQ729UPhTotYTcW4N6JaOcHyWuXEl74evzP5QBCc=; b=J7DMg+Ojt84U7tEoFowdZO0edtU3aL11ZmMKReaB58AEUDTz77c86qBxBn3QAyt5ge MtUCsYkYCqZJ7gVGRlJ46jOfirxHOAvYNjn3R3HcXrUFEebc6RtDsyNJ25vkBILbuvxa WYCVjQ7LVuPLf3m0PcE7KSi+S2HiE235umFrM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722248728; x=1722853528; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gXMMQ729UPhTotYTcW4N6JaOcHyWuXEl74evzP5QBCc=; b=Vs7KjykeefRTC92lvDFLTeSWaWj1OSVgKUapatrOrVz23BI4FfJhiyAd5ChRIHlqn5 j6hz7lEv3uqV2bOHdM5YoR98CXL+JhMx9c9urAoRjs3evfnSHzA3r6wtQO2uOmn3MrwZ bHodK+dkCHc5QADwYQd39MpBS+WfCTV5QlwuZ9fRW+89nXaKgy2dAtQacWT6QDcq9aoq miMfLdu7HdLgXA3LKc0dUU660RDepa20MK6LURcsUWHK5pAGY+7zi5VB9aCoqgWrfOC5 4vrHs5axbPaBHVsRAb1D9O8m/tXHNwRuriLXM7g7S4OJDvykZm45iM+QulbnAzO7RjMp df5A==
X-Gm-Message-State: AOJu0Ywk3Swt/JW+1DiJKS6o/xH6c9sLl5Wlk/4daOXaDgpjOKW2M7UU jOfKrxxe3vL49pxHXk73dVA0sAMq3Qu0Gh9CgQI9nOnCSoLJyGb28y/xYztRXY4=
X-Google-Smtp-Source: AGHT+IF0UvsNFx19p6JIbjK9aagrD3lCEzbOEaUPEcnlmzm9LaQrariqQ8Vng1agkBiJotaWJykZmw==
X-Received: by 2002:a2e:9903:0:b0:2ec:5b17:29a2 with SMTP id 38308e7fff4ca-2f12ee423c1mr48796161fa.32.1722248728542; Mon, 29 Jul 2024 03:25:28 -0700 (PDT)
Received: from snel ([2a10:3781:276:0:16f6:d8ff:fe47:2eb7]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac655811d6sm5551594a12.83.2024.07.29.03.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 03:25:28 -0700 (PDT)
Date: Mon, 29 Jul 2024 12:25:26 +0200
From: Job Snijders <job@fastly.com>
To: Carl Wallace <carl@redhoundsoftware.com>
Message-ID: <ZqduFs9Xe9fLj3oc@snel>
References: <172218105300.1558539.17525621904498066822@dt-datatracker-659f84ff76-9wqgv>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <172218105300.1558539.17525621904498066822@dt-datatracker-659f84ff76-9wqgv>
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID-Hash: BN4UI7WAJMUSV7UYJXVZJRTLWZZAHNV4
X-Message-ID-Hash: BN4UI7WAJMUSV7UYJXVZJRTLWZZAHNV4
X-MailFrom: job@fastly.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: secdir@ietf.org, draft-ietf-idr-bgp-sendholdtimer.all@ietf.org, idr@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [secdir] Re: Secdir last call review of draft-ietf-idr-bgp-sendholdtimer-13
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/_nRtXciv36tWL9F-z591oZHHe8w>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

Dear Carl,

On Sun, Jul 28, 2024 at 08:37:33AM -0700, Carl Wallace via Datatracker wrote:
> Reviewer: Carl Wallace
> Review result: Ready
> 
> This draft defines the SendHoldtimer and SendHoldTimer_Expires for the BGP
> state machine. The draft is straightforward and well written but I had one
> minor nit. In section 3.3, there is a NEW block to be added that begins "If the
> SendHoldTimer_Expires (Event 29), the local system:". This seems to be
> incomplete. From similar text in 4271, one fix would be to put the word
> "occurs" before the comma.

Thank you for your review and attention to detail!

It appears I copy+pasted this pattern in from RFC 4271's section with
"If the HoldTimer_Expires (Event 10), the local system:" :-)

I appreciate your suggestion, it's been fixed in the edit-buffer
https://github.com/bgp/draft-ietf-idr-bgp-sendholdtimer/commit/948449d93218d7dbfc04f7b9663611a4a2d68c1c

Kind regards,

Job

v2.26.15 | Report a Bug | By Email | System Status