[secdir] Secdir last call review of draft-ietf-bess-evpn-df-election-framework-06

Russ Housley <housley@vigilsec.com> Sat, 08 December 2018 23:29 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DE1FC130FA2; Sat, 8 Dec 2018 15:29:22 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley <housley@vigilsec.com>
To: <secdir@ietf.org>
Cc: draft-ietf-bess-evpn-df-election-framework.all@ietf.org, ietf@ietf.org, bess@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.89.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154431176283.1419.9002617678445961562@ietfa.amsl.com>
Date: Sat, 08 Dec 2018 15:29:22 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/bNfKVyiqxSH1fjBtMWAMFiwfLIs>
Subject: [secdir] Secdir last call review of draft-ietf-bess-evpn-df-election-framework-06
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Dec 2018 23:29:23 -0000

Reviewer: Russ Housley
Review result: Has Nits

I reviewed this document as part of the Security Directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the Security Area
Directors.  Document authors, document editors, and WG chairs should
treat these comments just like any other IETF Last Call comments.

Document: draft-ietf-bess-evpn-df-election-framework-06
Reviewer: Russ Housley
Review Date: 2018-12-09
IETF LC End Date: 2018-12-18
IESG Telechat date: unknown

Summary: Has Nits

Major Concerns: None

Minor Concerns:

Please spell out EVPN on first use.  I suspect that "Ethernet VPN" is
good enough since "VPN" is quite well known.

The Abstract seems to be overly complete, so it reads more like an
Introduction.  I suggest someting like:

   An alternative to the default Designated Forwarder (DF) selection
   algorithm in Ethernet VPN (EVPN) networks is defined. The DF is the
   Provider Edge (PE) router responsible for sending broadcast, unknown
   unicast and multicast (BUM) traffic to multi-homed Customer Equipment
   (CE) on a particular Ethernet Segment (ES) within a VLAN. In addition,
   the capability to influence the DF election result for a VLAN based
   on the state of the associated Attachment Circuit (AC) is specified.

I suggest that the original Abstract text become Section 2.

Section 3 says:

   ...  In addition, since the specification in EVPN
   [RFC7432] does leave several questions open as to the precise final
   state machine behavior of the DF election, section 3.1 describes
   precisely the intended behavior.

This seems like an update to RFC 7432.  If that is the intent, please
update the Introduction and the Title Page Heading to say so.


Section 2.2.1:  s/multi homed/multi-homed/

Section 4:  s/the state of the server states/the server states./